[Piglit] [PATCH] cl: fixed test create-context to test what it was supposed to test

2013-08-23 Thread Ville Korhonen
fixed function parameters to match description. diff --git a/tests/cl/api/create-context.c b/tests/cl/api/create-context.c index 7858940..f4929f0 100644 --- a/tests/cl/api/create-context.c +++ b/tests/cl/api/create-context.c @@ -251,10 +251,10 @@ piglit_cl_test(const int argc,

Re: [Piglit] [PATCH V2] ARB_seamless_cube_map: test that sample from three faces returns value without border color

2013-08-23 Thread Paul Berry
On 22 August 2013 11:38, Steve Miller dervi...@gmail.com wrote: add new test to existing arb_seamless_cube_map group: sample three adjoining faces and use average. if three faces are the same color, that color must be used. add test to makelists and all.tests V2 : test now uses

Re: [Piglit] [PATCH 5/8] arb_gpu_shader5: Add ldexp constant eval execution test.

2013-08-23 Thread Paul Berry
On 22 August 2013 16:07, Matt Turner matts...@gmail.com wrote: --- .../built-in-functions/const-ldexp.shader-test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-ldexp.shader-test diff

Re: [Piglit] [PATCH 3/4] fbo-storage-formats: Fix reporting of invalid formats.

2013-08-23 Thread Ian Romanick
On 08/20/2013 01:12 PM, Kenney Phillis wrote: Currently Invalid formats is reported from the formats data structure. This is incorrect because the invalid formats set should not use this system. Oops. Looks like a copy-and-paste bug. Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

Re: [Piglit] [PATCH 4/4] fbo-storage-formats: enable tests for OpenGl 3.0 formats.

2013-08-23 Thread Ian Romanick
On 08/20/2013 01:12 PM, Kenney Phillis wrote: This enabled the Floating point and Integer formats introduced in OpenGL 3.0. This currently uses an OpenGL 3.1 Core context to enable this for Mesa based drivers, however the test should work without any faults on any drivers that also support

Re: [Piglit] [PATCH 5/8] arb_gpu_shader5: Add ldexp constant eval execution test.

2013-08-23 Thread Ian Romanick
On 08/23/2013 07:24 AM, Paul Berry wrote: On 22 August 2013 16:07, Matt Turner matts...@gmail.com mailto:matts...@gmail.com wrote: --- .../built-in-functions/const-ldexp.shader-test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644

Re: [Piglit] [PATCH 1/8] arb_gpu_shader5: Add frexp fragment shader execution test.

2013-08-23 Thread Ian Romanick
On 08/22/2013 04:07 PM, Matt Turner wrote: --- .../built-in-functions/fs-frexp.shader_test| 64 ++ 1 file changed, 64 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-frexp.shader_test diff --git

[Piglit] [PATCH v2 1/5] fbo-storage-formats: Fix reporting of invalid formats.

2013-08-23 Thread Kenney Phillis
Currently Invalid formats is reported from the formats data structure. This is incorrect because the invalid formats set should not use this system. --- tests/fbo/fbo-storage-formats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-storage-formats.c

[Piglit] [PATCH v2 2/5] fbo-storage-formats: enable tests for OpenGl 3.0 formats.

2013-08-23 Thread Kenney Phillis
Enable the Floating point and Interformats that are introduced in the OpenGL 3.0 specification. Currently the test uses an OpenGL 3.1 Core context for Mesa based drivers, and this test should also work just fine when Compatibility contexts support Opengl 3.1 or newer. ---

[Piglit] [PATCH v2 0/5] Minor Improvements.

2013-08-23 Thread Kenney Phillis
Applied some of the Suggested improvements to the previous patch set. Kenney Phillis (5): fbo-storage-formats: Fix reporting of invalid formats. fbo-storage-formats: enable tests for OpenGl 3.0 formats. fbo-storage-formats:minor improvements to error detection. piglit-util-gl-common: Add

Re: [Piglit] [PATCH] glsl-1.50: Remove gl_Position from fragment shader.

2013-08-23 Thread Paul Berry
On 22 August 2013 22:37, Kenneth Graunke kenn...@whitecape.org wrote: This must've been cut and pasted from a vertex shader by accident. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Nicholas Mack nichm...@gmail.com --- tests/spec/glsl-1.50/compiler/layout-global-only.frag | 2

[Piglit] [PATCH v2 3/5] fbo-storage-formats:minor improvements to error detection.

2013-08-23 Thread Kenney Phillis
sometimes errors can sneak in when generating the context and interfere with the test. This clears out all errors before the actual test begins. --- tests/fbo/fbo-storage-formats.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/fbo/fbo-storage-formats.c

[Piglit] [PATCH v2 4/5] piglit-util-gl-common: Add Function to clear extensions list.

2013-08-23 Thread Kenney Phillis
The default handling of the extensions does not allow for proper fall back of contexts to work as inteded. There is currently no guarantee that any implementations of OpenGL will have the pointer of supported extensions will remain constant after contexts change. ---

[Piglit] [PATCH v2 5/5] util/waffle: reinitialize extensions

2013-08-23 Thread Kenney Phillis
When context creation fails, Inform piglit to reinitialize the list of supported extensions. --- .../piglit-framework-gl/piglit_wfl_framework.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c

Re: [Piglit] [v10 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-23 Thread Chad Versace
On 08/20/2013 03:16 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list

Re: [Piglit] [PATCH 1/8] arb_gpu_shader5: Add frexp fragment shader execution test.

2013-08-23 Thread Paul Berry
On 23 August 2013 09:03, Ian Romanick i...@freedesktop.org wrote: On 08/22/2013 04:07 PM, Matt Turner wrote: --- .../built-in-functions/fs-**frexp.shader_test| 64 ++ 1 file changed, 64 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/**

Re: [Piglit] [PATCH 2/2] Use utility function piglit_srgb_to_linear()

2013-08-23 Thread Anuj Phogat
On Thu, Aug 22, 2013 at 2:53 PM, Paul Berry stereotype...@gmail.com wrote: On 20 August 2013 16:04, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/spec/ext_framebuffer_multisample/common.cpp | 18 ++ 1 file changed, 2

Re: [Piglit] [v10 10/13] tests/spec: EXT_image_dma_buf_import sample argb

2013-08-23 Thread Chad Versace
On 08/20/2013 03:16 AM, Topi Pohjolainen wrote: Tests that one can sample the given buffer without other mipmap levels by setting texture filtering accordingly. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list

Re: [Piglit] [PATCH 1/8] arb_gpu_shader5: Add frexp fragment shader execution test.

2013-08-23 Thread Matt Turner
On Fri, Aug 23, 2013 at 9:03 AM, Ian Romanick i...@freedesktop.org wrote: draw rect -1 -1 2 2 ... in all the tests. I tried to do this recently at your suggestion on some other tests, but as Paul says, it doesn't work in core contexts. ___ Piglit

Re: [Piglit] [PATCH 5/8] arb_gpu_shader5: Add ldexp constant eval execution test.

2013-08-23 Thread Matt Turner
On Fri, Aug 23, 2013 at 7:24 AM, Paul Berry stereotype...@gmail.com wrote: On 22 August 2013 16:07, Matt Turner matts...@gmail.com wrote: --- .../built-in-functions/const-ldexp.shader-test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644

[Piglit] [PATCH 1/2] GLSL 1.50: Test that geometry shader output may be a struct

2013-08-23 Thread Nicholas Mack
--- tests/spec/glsl-1.50/compiler/output-struct.geom | 52 1 file changed, 52 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/output-struct.geom diff --git a/tests/spec/glsl-1.50/compiler/output-struct.geom

[Piglit] [PATCH 2/2] GLSL 1.50: Test that struct varyings are passed correctly from GS to FS

2013-08-23 Thread Nicholas Mack
--- .../varying-struct-basic-vs-gs-fs.shader_test | 141 + 1 file changed, 141 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/varying-struct-basic-vs-gs-fs.shader_test diff --git

[Piglit] [PATCH 2/2] glsl-3.30: Port the profile tests forward.

2013-08-23 Thread Kenneth Graunke
These are the tests from glsl-1.50/compiler/profiles with the version numbers changed. It seemed worth testing for 3.30 as well. --- .../compiler/profiles/core-profile-default.vert | 16 .../glsl-3.30/compiler/profiles/core-profile-define.frag | 7 +++

[Piglit] [PATCH 1/2] glsl-3.30: Add a test for __VERSION__ == 330.

2013-08-23 Thread Kenneth Graunke
This is copy and pasted from glsl-1.50/compiler/version-macro.frag with the version changed. Since this is the first test for GLSL 3.30, this patch also hooks up the directory so all.tests scans it for parsertests and shader runner tests. --- tests/all.tests | 8

Re: [Piglit] [PATCH] gs: Test EndPrimitive() functionality.

2013-08-23 Thread Kenneth Graunke
On 08/11/2013 10:32 PM, Paul Berry wrote: --- tests/all.tests| 9 + tests/spec/glsl-1.50/execution/CMakeLists.txt | 1 + .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 13 + .../glsl-1.50/execution/geometry/CMakeLists.txt| 1 +

Re: [Piglit] [PATCH 2/2] glsl-3.30: Port the profile tests forward.

2013-08-23 Thread Anuj Phogat
On Fri, Aug 23, 2013 at 11:46 AM, Kenneth Graunke kenn...@whitecape.org wrote: These are the tests from glsl-1.50/compiler/profiles with the version numbers changed. It seemed worth testing for 3.30 as well. --- .../compiler/profiles/core-profile-default.vert | 16

Re: [Piglit] [PATCH 2/2] glsl-3.30: Port the profile tests forward.

2013-08-23 Thread Kenneth Graunke
On 08/23/2013 12:51 PM, Anuj Phogat wrote: On Fri, Aug 23, 2013 at 11:46 AM, Kenneth Graunke kenn...@whitecape.org wrote: These are the tests from glsl-1.50/compiler/profiles with the version numbers changed. It seemed worth testing for 3.30 as well. ---

[Piglit] [PATCH 1/3] GLSL 1.50: Test that geometry shader must specify input type, output type and maximum output vertices

2013-08-23 Thread Nicholas Mack
--- .../linker/gs-must-specify-input-type.shader_test | 52 + .../gs-must-specify-max-vertices.shader_test | 53 ++ .../linker/gs-must-specify-output-type.shader_test | 53 ++ 3 files changed, 158 insertions(+) create mode 100644

[Piglit] [PATCH 3/3] GLSL 1.50: Test that linking fails if there is a geom shader without a vert shader

2013-08-23 Thread Nicholas Mack
--- .../glsl-1.50/linker/gs-without-vs.shader_test | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 tests/spec/glsl-1.50/linker/gs-without-vs.shader_test diff --git a/tests/spec/glsl-1.50/linker/gs-without-vs.shader_test

[Piglit] [PATCH 2/3] GLSL 1.50: Test that differently specified input/output layouts results in link error

2013-08-23 Thread Nicholas Mack
--- ...ax-vertices-multiple-shader-objects.shader_test | 64 ++ ...output-type-multiple-shader-objects.shader_test | 64 ++ 2 files changed, 128 insertions(+) create mode 100644

[Piglit] [PATCH] Add new test for MRT alpha test

2013-08-23 Thread Chris Forbes
This test exercises alpha test with multiple render targets. This is one part of FDO #67864. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests | 1 + tests/fbo/CMakeLists.gl.txt | 1 + tests/fbo/fbo-mrt-alphatest.c | 153

Re: [Piglit] [PATCH 1/2] glsl-3.30: Add a test for __VERSION__ == 330.

2013-08-23 Thread Matt Turner
On Fri, Aug 23, 2013 at 11:46 AM, Kenneth Graunke kenn...@whitecape.org wrote: This is copy and pasted from glsl-1.50/compiler/version-macro.frag with the version changed. Since this is the first test for GLSL 3.30, this patch also hooks up the directory so all.tests scans it for parsertests

Re: [Piglit] [PATCH] Add new test for MRT alpha test

2013-08-23 Thread Kenneth Graunke
On 08/23/2013 03:30 PM, Chris Forbes wrote: This test exercises alpha test with multiple render targets. This is one part of FDO #67864. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests | 1 + tests/fbo/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH] arb_gpu_shader5: Use array sizing to catch bad constant folding.

2013-08-23 Thread Matt Turner
The GLSL spec doesn't guarantee that a linking error won't happen. --- .../built-in-functions/const-bitCount.shader_test | 40 -- .../const-bitfieldExtract.shader_test | 23 + .../const-bitfieldInsert.shader_test | 20 ---

Re: [Piglit] [PATCH 8/8] arb_gpu_shader5: Add fma constant eval execution test.

2013-08-23 Thread Matt Turner
On Fri, Aug 23, 2013 at 7:29 AM, Paul Berry stereotype...@gmail.com wrote: This test doesn't verify that fma() is constant-folded. I'd recommend doing the array size trick (see my comments on patch 5/8) here as well. With that changed, the patch is: Reviewed-by: Paul Berry

[Piglit] [PATCH] glsl-3.30: Add a coverage test for bitcasting functions.

2013-08-23 Thread Kenneth Graunke
This ensures that the bitcasting functions are available in 3.30 without having to use #extension GL_ARB_shader_bit_encoding: require. Serious functional testing of those functions is left to Matt's thorough generated tests for the GL_ARB_shader_bit_encoding extension. Signed-off-by: Kenneth

[Piglit] [PATCH] KHR_debug: test ObjectLabel(), GetObjectLabel(), ObjectPtrLabel() and GetObjectPtrLabel()

2013-08-23 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.tests | 5 + tests/spec/khr_debug/CMakeLists.gl.txt| 14 ++ tests/spec/khr_debug/CMakeLists.txt | 1 + tests/spec/khr_debug/debug-object-label.c | 258 ++ 4 files

Re: [Piglit] [PATCH] KHR_debug: test ObjectLabel(), GetObjectLabel(), ObjectPtrLabel() and GetObjectPtrLabel()

2013-08-23 Thread Chris Forbes
Perhaps consider using subtests, so that one problem doesn't prevent other parts of the test from running; and so the individual cases show up in the results summary.? -- Chris On Sat, Aug 24, 2013 at 3:52 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: Signed-off-by: Timothy Arceri