[Piglit] [PATCH] core: Catch all exceptions when collect_system_info() programs fail

2014-06-24 Thread Tom Stellard
Otherwise it is not possible to run piglit without X, because glxinfo will requires a running X server. --- framework/core.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/framework/core.py b/framework/core.py index de5afa0..af36d8c 100644 --- a/framework/core.py +++

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

2014-06-24 Thread Kenneth Graunke
On Friday, June 20, 2014 12:04:01 AM Dylan Baker wrote: This reverts commit 40b5d5288991fec2cc76ea4af7050555be467126. The patch to be reverted breaks users of *BSD, solaris, and OSX which don't provide a python2 symlink, making it a regression. The patch however, fixes python for arch

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

2014-06-24 Thread Ilia Mirkin
On Tue, Jun 24, 2014 at 11:20 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Friday, June 20, 2014 12:04:01 AM Dylan Baker wrote: This reverts commit 40b5d5288991fec2cc76ea4af7050555be467126. The patch to be reverted breaks users of *BSD, solaris, and OSX which don't provide a python2

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

2014-06-24 Thread Ilia Mirkin
On Tue, Jun 24, 2014 at 11:53 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Tuesday, June 24, 2014 11:27:13 AM Ilia Mirkin wrote: On Tue, Jun 24, 2014 at 11:20 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Friday, June 20, 2014 12:04:01 AM Dylan Baker wrote: This reverts commit

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

2014-06-24 Thread Ian Romanick
On 06/24/2014 10:08 AM, Ilia Mirkin wrote: On Tue, Jun 24, 2014 at 1:04 PM, Ian Romanick i...@freedesktop.org wrote: On 06/24/2014 08:27 AM, Ilia Mirkin wrote: On Tue, Jun 24, 2014 at 11:20 AM, Kenneth Graunke kenn...@whitecape.org wrote: For the record, I dislike that Arch has installed

[Piglit] Time to switch to Python 3 already?

2014-06-24 Thread Matt Turner
It was more than a year ago now [1] that we agreed to hold these patches back for a short time (maybe a month) to give people time to get ready for the transition In the mean time, we've struggled with Python 2.7 regressions and dealt with many this breaks with Python 2.6 comments. Is it time to

[Piglit] [PATCH] core.py: Add additional catch to collect_system_info()

2014-06-24 Thread Dylan Baker
Catch subprocess.CalledProcessError, which is an exception that subprocess.check_call() raises if the binary returns a non 0 status. The usual culprit for this is glxinfo on systems not running X Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- Tom, I'm not a fan of catching exceptions in

[Piglit] [PATCH] arb_arrays_of_arrays: fix required extensions

2014-06-24 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid2.vert | 3 +-- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid3.vert | 3 +-- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid4.vert | 3 +--

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

2014-06-24 Thread Chad Versace
On Mon, Jun 23, 2014 at 05:36:13PM -0700, Dylan Baker wrote: Chad, you mentioned you had comments on this patch? Right, I commented on the Bugzilla ticket. https://bugs.freedesktop.org/show_bug.cgi?id=80261 ___ Piglit mailing list

Re: [Piglit] [PATCH] ARB_explicit_attrib_location: Remove commas from require_extensions line.

2014-06-24 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Jun 25, 2014 at 9:23 AM, Matt Turner matts...@gmail.com wrote: --- tests/spec/arb_explicit_attrib_location/1.10/compiler/layout-12.frag | 2 +- tests/spec/arb_explicit_attrib_location/1.10/compiler/layout-13.frag | 2 +- 2 files changed, 2

[Piglit] [PATCH 1/1] cl: generated store: reduce the number of elements to 4

2014-06-24 Thread Jan Vesely
8 ulong16 crashes r600. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- Crashing on lack of resources is probably not the intended behavior. generated_tests/cl/store/store-kernels-global.inc | 4 generated_tests/generate-cl-store-tests.py| 18 +- 2 files

[Piglit] Piglit build fails: NameError: global name 'fake_whitespace' is not defined

2014-06-24 Thread Tom Stellard
Hi, Building piglit fails for me with HEAD at 7e699cdb47f328206afa6dd454de8d6f28d7ffe9 Here is the error: [ 0%] Generating tests/util/piglit-dispatch-gen.c, tests/util/piglit-dispatch-gen.h, tests/util/piglit-util-gl-enum-gen.c debug: registry.gl: etree is xml.etree.cElementTree debug:

Re: [Piglit] Piglit build fails: NameError: global name 'fake_whitespace' is not defined

2014-06-24 Thread Dylan Baker
just saw that. Glad you got it working On Tuesday, June 24, 2014 08:43:49 PM Tom Stellard wrote: On Tue, Jun 24, 2014 at 08:34:37PM -0400, Tom Stellard wrote: On Tue, Jun 24, 2014 at 05:29:44PM -0700, Dylan Baker wrote: what does: python -c 'import mako; print mako.__version__' return?

[Piglit] [PATCH] results.py: Fix JSONWriter.close_json()

2014-06-24 Thread Dylan Baker
This bug was caused by calling close_dict() too many times for piglit-run (but the correct number of times for piglit-resume), the solution is to actually count the number of open dicts and close them until the stack is empty Signed-off-by: Dylan Baker baker.dyla...@gmail.com cc:

[Piglit] [Patch v2] results.py: Fix JSONWriter.close_json()

2014-06-24 Thread Dylan Baker
A previous patch created a bug which caused an AssertionError at the end of a piglit run. This bug is the result of calling JSONWriter.close_dict() too many times. This solution is to split the start of the test dict out of initialize_json() and do it in the calling function instead. v2: - take

Re: [Piglit] Time to switch to Python 3 already?

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 10:30:56 AM Matt Turner wrote: It was more than a year ago now [1] that we agreed to hold these patches back for a short time (maybe a month) to give people time to get ready for the transition In the mean time, we've struggled with Python 2.7 regressions and dealt

[Piglit] [PATCH] glsl-1.10: Test reductions of integer vectors

2014-06-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Mesa has an optimization that converts expressions like v.x + v.y + v.z + v.w into dot(v, 1.0). And therein lies the rub: the other operand to the dot-product is always a float... even if the vector is an ivec or uvec. The result is not pretty: