Re: [Piglit] [PATCH v3] programs/run.py add file sync command line option

2014-08-15 Thread Dylan Baker
On Friday, August 15, 2014 04:12:59 PM Atwood, Matthew S wrote: > Ah, I was wondering what the proper way to do that was, sorry for the > confusion. My go to was to respond to previous version messages as > whether or not the feedback had been added. As far as default behavior > for igt tests, I wo

[Piglit] [PATCH] s3tc-errors: check GL_ARB_compressed_texture_pixel_storage errors

2014-08-15 Thread Brian Paul
Basic checking that the SKIP_PIXELS, SKIP_ROWS parameters are multiples of the block size. And check that if a GL error is generated, the glCompressedTexSubImage2D() call is no-op'd (to exercise a Mesa bug.) --- tests/texturing/s3tc-errors.c | 78 + 1 fil

Re: [Piglit] Default window sizes and NPOT

2014-08-15 Thread Ilia Mirkin
On Fri, Aug 15, 2014 at 11:19 AM, Brian Paul wrote: > On 08/15/2014 08:52 AM, Ilia Mirkin wrote: >> >> Brian, >> >> You recently went on a campaign against setting .window_width/height >> in piglit tests, in order to fix issues on Windows I guess? I noticed >> that a bunch of failures on a NV17 ca

Re: [Piglit] [PATCH v3] programs/run.py add file sync command line option

2014-08-15 Thread Atwood, Matthew S
Ah, I was wondering what the proper way to do that was, sorry for the confusion. My go to was to respond to previous version messages as whether or not the feedback had been added. As far as default behavior for igt tests, I wouldn't be averse to it, maybe Thomas Wood can chime in on that?

Re: [Piglit] Default window sizes and NPOT

2014-08-15 Thread Brian Paul
On 08/15/2014 08:52 AM, Ilia Mirkin wrote: Brian, You recently went on a campaign against setting .window_width/height in piglit tests, in order to fix issues on Windows I guess? I noticed that a bunch of failures on a NV17 card (GeForce4 MX 440) are due to the fact that the window sizes are now

[Piglit] Default window sizes and NPOT

2014-08-15 Thread Ilia Mirkin
Brian, You recently went on a campaign against setting .window_width/height in piglit tests, in order to fix issues on Windows I guess? I noticed that a bunch of failures on a NV17 card (GeForce4 MX 440) are due to the fact that the window sizes are now 160x160 (NPOT) and the tests use that in ord

[Piglit] [PATCH] maxuniformblocksize: fix vs/fsexceed test index

2014-08-15 Thread Brian Paul
For the exceed test, we create an array in a UBO that's one vector larger than what's supposed to be supported. The shader program is allowed to link or not link in this situation. But if it does link, the behavior of indexing beyond the UBO size probably isn't well defined. Instead of testing/pr

Re: [Piglit] [PATCH v3] programs/run.py add file sync command line option

2014-08-15 Thread Daniel Vetter
On Tue, Jan 03, 2012 at 09:08:25PM -0800, Matthew Atwood wrote: > From: Matt Atwood > > Currently while running igt tests a kernel panic causes the results json > file to lose all data. This patch adds a command line option (-s, > --sync) that syncs the file descriptor to disk after every test al