[Piglit] [PATCH v2] arb_explicit_uniform_location: lower GL and GLSL requirements

2014-09-04 Thread Tapani Pälli
v2: ask for Open GL 3.0 (Matt, Chris) Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/spec/arb_explicit_uniform_location/array-elements.c | 6 -- .../spec/arb_explicit_uniform_location/compiler/layout-01.frag | 7 ---

Re: [Piglit] [PATCH v2] arb_explicit_uniform_location: lower GL and GLSL requirements

2014-09-04 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/4] cl: Add atan2 tests

2014-09-04 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 414e397..1c6add4 100644

[Piglit] [PATCH 4/4] cl: Add tan tests

2014-09-04 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 0677569..394207a

[Piglit] [PATCH 2/4] cl: Add asin tests

2014-09-04 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 1c6add4..124acf6 100644

[Piglit] [PATCH] s3tc-errors: check GL_ARB_compressed_texture_pixel_storage errors

2014-09-04 Thread Brian Paul
Basic checking that the SKIP_PIXELS, SKIP_ROWS parameters are multiples of the block size. And check that if a GL error is generated, the glCompressedTexSubImage2D() call is no-op'd (to exercise a Mesa bug.) --- tests/texturing/s3tc-errors.c | 78 + 1

[Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c

2014-09-04 Thread Brian Paul
From: Meng-Lin Wu mengl...@vmware.com Reviewed-by: Brian Paul bri...@vmware.com --- tests/spec/ext_timer_query/CMakeLists.gl.txt |5 +-- tests/spec/ext_timer_query/time-elapsed.c| 58 +++--- 2 files changed, 44 insertions(+), 19 deletions(-) diff --git

[Piglit] [PATCH 2/2] arb_timer_query: add Windows support for timestamp-get.c

2014-09-04 Thread Brian Paul
From: Meng-Lin Wu mengl...@vmware.com And silence MinGW compiler warnings when printing 64-bit ints. Reviewed-by: Brian Paul bri...@vmware.com --- tests/spec/arb_timer_query/CMakeLists.gl.txt |4 +--- tests/spec/arb_timer_query/timestamp-get.c | 32 -- 2 files

Re: [Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c

2014-09-04 Thread Emil Velikov
Hi Brian, Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time and piglit_sleep ? This way we'll be able to keep the tests clean and OS-agnostic and avoid the trivial duplication introduced with the second patch :) Cheers, Emil On 04/09/14 20:34, Brian Paul wrote:

Re: [Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Dylan Baker
On Wednesday, September 03, 2014 09:44:08 PM Ilia Mirkin wrote: [snip] H right. In the Test constructor: self.result = TestResult({'result': 'fail'}) And in case that wasn't there, right before the self.interpret_result() call in Test.run(): self.result['result']

[Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. CC: Jason Ekstrand ja...@jlekstrand.net Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/summary.py | 14 ++ 1 file changed, 10 insertions(+), 4

Re: [Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c

2014-09-04 Thread Brian Paul
On 09/04/2014 02:25 PM, Emil Velikov wrote: Hi Brian, Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time and piglit_sleep ? This way we'll be able to keep the tests clean and OS-agnostic and avoid the trivial duplication introduced with the second patch :) I want

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Ilia Mirkin
On Thu, Sep 4, 2014 at 4:54 PM, Dylan Baker baker.dyla...@gmail.com wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. CC: Jason Ekstrand ja...@jlekstrand.net Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com

[Piglit] [PATCH] exectest.py: remove unneeded setting of result

2014-09-04 Thread Dylan Baker
The result defaults to 'fail' already, so this is just resetting the result to the same value again. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/exectest.py | 1 - 1 file changed, 1 deletion(-) diff --git a/framework/exectest.py b/framework/exectest.py index

Re: [Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c

2014-09-04 Thread Emil Velikov
On 04/09/14 21:56, Brian Paul wrote: On 09/04/2014 02:25 PM, Emil Velikov wrote: Hi Brian, Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time and piglit_sleep ? This way we'll be able to keep the tests clean and OS-agnostic and avoid the trivial duplication

[Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-04 Thread Jan Vesely
This fixes hidden failures where summary would report the result of the last test with given name. v2: Tag tss variants Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- generated_tests/genclbuiltins.py | 65 1 file changed, 33 insertions(+), 32

Re: [Piglit] [PATCH] array-index-as-uint-02: Move test to proper location

2014-09-04 Thread Dylan Baker
This looks fine to me. I'm far from a GLSL expert, but it seem straight forward enough that I'm willing to call it good. Do you have push access? If you don't I'll push this tomorrow if no one complains. Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Wednesday, September 03, 2014 03:32:37

[Piglit] [PATCH] results.py: add piglit to junit class name

2014-09-04 Thread Dylan Baker
This adds 'piglit' as the first group in the junit xml (the classname), this allows piglit to be run alongside other test suites on jenkins without poluting the root node. CC: Jose Fonseca jfons...@vmware.com Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/results.py | 9

Re: [Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Dylan Baker
On Thursday, September 04, 2014 05:25:56 PM Jan Vesely wrote: On Thu, 2014-09-04 at 13:39 -0700, Dylan Baker wrote: On Wednesday, September 03, 2014 09:44:08 PM Ilia Mirkin wrote: [snip] H right. In the Test constructor: self.result = TestResult({'result': 'fail'})

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Emil Velikov
On 04/09/14 21:54, Dylan Baker wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. From a quick look it seems that it might help with a funny issue that I'm seeing: Whenever piglit is ran on Windows the testname uses

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: On 04/09/14 21:54, Dylan Baker wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. From a quick look it seems that it might help with a funny issue

[Piglit] [PATCH v2 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Jan Vesely
v2: don't mix tabs and spaces use 'in' instead of 'has_key' Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- framework/results.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/framework/results.py b/framework/results.py index ddadcc1..820b39c 100644 ---

Re: [Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c

2014-09-04 Thread Brian Paul
On 09/04/2014 03:07 PM, Emil Velikov wrote: On 04/09/14 21:56, Brian Paul wrote: On 09/04/2014 02:25 PM, Emil Velikov wrote: Hi Brian, Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time and piglit_sleep ? This way we'll be able to keep the tests clean and

Re: [Piglit] [PATCH v2 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Dylan Baker
Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Thursday, September 04, 2014 06:14:11 PM Jan Vesely wrote: v2: don't mix tabs and spaces use 'in' instead of 'has_key' Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- framework/results.py | 8 +--- 1 file changed, 5

[Piglit] [PATCH] arb_texture_view-sampling-2d-array-as-cubemap: Probe the correct rectangle

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com Cc: Ilia Mirkin imir...@alum.mit.edu --- tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c

Re: [Piglit] [PATCH] arb_texture_view-sampling-2d-array-as-cubemap: Probe the correct rectangle

2014-09-04 Thread Ilia Mirkin
I believe ChrisF already fixed that in 25a322ccfd (arb_texture_view: Fix bogus probe rects). Or am I missing something? On Thu, Sep 4, 2014 at 6:43 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com Cc: Ilia Mirkin imir...@alum.mit.edu ---