[Piglit] [PATCH] cl: add clLinkProgram test

2014-12-19 Thread EdB
--- tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/link-program.c| 386 + 2 files changed, 387 insertions(+) create mode 100644 tests/cl/api/link-program.c diff --git a/tests/cl/api/CMakeLists.cl.txt b/tests/cl/api/CMakeLists.cl.txt index

[Piglit] [PATCH v2] cl: add clLinkProgram test

2014-12-19 Thread EdB
v2: Use piglit_cl_get_program_build_info instead of piglit_cl_get_program_info, I was expected it to fail so I didn't paid attention. Remove -invalid- --link-- options on CL_INVALID_OPERATION test. --- tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/link-program.c| 394

Re: [Piglit] [PATCH] arb_texture_buffer_object-formats: Initialize variable.

2014-12-19 Thread Brian Paul
On 12/18/2014 10:22 PM, Vinson Lee wrote: Fix Clang Static Analyzer Assigned value is garbage or undefined bugs. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/arb_texture_buffer_object/formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Piglit] [PATCH] arb_shader_precision: add tests for floating point precision

2014-12-19 Thread Micah Fedke
This generated_tests script creates a suite of tests that measure the floating point precision of most GLSL built-ins, according to ARB_shader_precision. Test vectors come from builtin_function.py, but are filtered down to avoid non-float types. These tests are reporting precision errors in

Re: [Piglit] [PATCH 02/24] arb_direct_state_access: glTextureSubImage*D test.

2014-12-19 Thread Laura Ekstrand
I agree with you that DSA really needs minimal testing. I used this test because it was a quick way to test most of the entry points in a trivial manner (but not so trivial as to not use any image data). In my DSA patches, the DSA entry points share the same implementation as the traditional

Re: [Piglit] [PATCH] arb_shader_precision: add tests for floating point precision

2014-12-19 Thread Dylan Baker
I have a few little things, but they're pretty small. With my requested changes you have my rb on the python portion. You should probably still try to get someone who understands GL better than I do to review the actual tests. Reviewed-by: Dylan Baker dylanx.c.ba...@intel.com On Friday, December

Re: [Piglit] [Patch v2] generated_tests: Actually catch exception in os.makedirs

2014-12-19 Thread Dylan Baker
Sorry Mark, in got my in-reply-to and cc flags backwards, I meant to cc you on this. On Wednesday, December 17, 2014 03:33:53 PM Dylan Baker wrote: Patch b59ff71eb was supposed to fix os.makedirs exceptions, but falls short because of a missing else statement that causes all of the caught

Re: [Piglit] [PATCH v2] cl: add clLinkProgram test

2014-12-19 Thread Tom Stellard
On Fri, Dec 19, 2014 at 02:39:06PM +0100, EdB wrote: v2: Use piglit_cl_get_program_build_info instead of piglit_cl_get_program_info, I was expected it to fail so I didn't paid attention. Remove -invalid- --link-- options on CL_INVALID_OPERATION test. Reviewed-by: Tom Stellard

Re: [Piglit] [Patch v2] generated_tests: Actually catch exception in os.makedirs

2014-12-19 Thread Mark Janes
It looks like this patch omits the utils.py module which is being called. This would have been hard to spot in a build-test, because the pyc from your previous patch was still in place. -Mark Dylan Baker baker.dyla...@gmail.com writes: Patch b59ff71eb was supposed to fix os.makedirs

Re: [Piglit] [Patch v2] generated_tests: Actually catch exception in os.makedirs

2014-12-19 Thread Dylan Baker
Sigh. Well, the good news is I just forgot to check it in and it's sitting safe and sound in my tree. I'll send a v3. On Friday, December 19, 2014 12:42:11 PM Mark Janes wrote: It looks like this patch omits the utils.py module which is being called. This would have been hard to spot in

[Piglit] [PATCH] arb_direct_state_access: Simplified texturesubimage test.

2014-12-19 Thread Laura Ekstrand
--- .../spec/arb_direct_state_access/texturesubimage.c | 390 - 1 file changed, 66 insertions(+), 324 deletions(-) diff --git a/tests/spec/arb_direct_state_access/texturesubimage.c b/tests/spec/arb_direct_state_access/texturesubimage.c index b3a09e6..9f3e0fb 100644 ---

[Piglit] [Patch v3] generated_tests: Actually catch exception in os.makedirs

2014-12-19 Thread Dylan Baker
Patch b59ff71eb was supposed to fix os.makedirs exceptions, but falls short because of a missing else statement that causes all of the caught exceptions to fall back to raise. This corrects, it also pulls the duplicate functions out into a shared module. v2: - remove accidentally included hunk

Re: [Piglit] [PATCH 02/24] arb_direct_state_access: glTextureSubImage*D test.

2014-12-19 Thread Laura Ekstrand
I just sent out a patch that simplifies this test a lot. Laura On Fri, Dec 19, 2014 at 9:47 AM, Laura Ekstrand la...@jlekstrand.net wrote: I agree with you that DSA really needs minimal testing. I used this test because it was a quick way to test most of the entry points in a trivial manner

Re: [Piglit] [Patch v3] generated_tests: Actually catch exception in os.makedirs

2014-12-19 Thread Mark Janes
Dylan Baker baker.dyla...@gmail.com writes: Patch b59ff71eb was supposed to fix os.makedirs exceptions, but falls short because of a missing else statement that causes all of the caught exceptions to fall back to raise. This corrects, it also pulls the duplicate functions out into a shared

[Piglit] [Bug 87513] New: NameError: name 'dirname' is not defined

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87513 Bug ID: 87513 Summary: NameError: name 'dirname' is not defined Product: piglit Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Piglit] [Bug 87513] NameError: name 'dirname' is not defined

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87513 --- Comment #1 from Dylan baker.dyla...@gmail.com --- copy and paste error. I'll fix it imediately. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Piglit] [PATCH] generate-cl-store-tests.py: fix copy and paste error from 68829470

2014-12-19 Thread Dylan Baker
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87513 Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- generated_tests/generate-cl-store-tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-store-tests.py

[Piglit] [Bug 87513] NameError: name 'dirname' is not defined

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87513 Dylan baker.dyla...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2

[Piglit] [Bug 87513] NameError: name 'dirname' is not defined

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87513 Dylan baker.dyla...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Piglit] [PATCH] Fix recently introduced GCC warnings in glsl-deriv-varyings

2014-12-19 Thread Andres Gomez
On Tue, 2014-12-16 at 20:18 +0100, Andres Gomez wrote: Previous patch at: http://lists.freedesktop.org/archives/piglit/2014-December/013648.html Introduced a couple of GCC warnings in the last 2 newly introduced tests. After correcting the warnings I'm realizing these tests are exposing