Re: [Piglit] [PATCH] texture-packed-formats: Don't try bother with ABGR_EXT formats

On Tue, Jan 13, 2015 at 2:24 AM, Samuel Iglesias Gonsálvez sigles...@igalia.com wrote: On Monday, January 12, 2015 01:14:23 PM Jason Ekstrand wrote: Since GL_ABGR_EXT was extension number 1 to the GL spec, it didn't take packed formats into account. As far as I can tell from the way the

[Piglit] [PATCH] glean/pixelformats: restrict GL_ABGR_EXT format test to the types in the spec

Packed types are not explicitly allowed to work with GL_ABGR_EXT format in the OpenGL spec nor GL_EXT_abgr spec. NVIDIA allows it but AMD doesn't and Intel driver hasn't allowed it with UNSIGNED_SHORT_5_5_5_1 and UNSIGNED_INT_10_10_10_2 as of c471b09bf4. Signed-off-by: Samuel Iglesias Gonsalvez

[Piglit] [PATCH 11/12] gen_dispatch.py: Remove unnecessary parens from assert keyword

Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/util/gen_dispatch.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/util/gen_dispatch.py b/tests/util/gen_dispatch.py index 6bfd6c0..34f3704 100644 --- a/tests/util/gen_dispatch.py +++

[Piglit] [PATCH 02/12] regirsry/gl.py: remove unused import

Spotted by pylint Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- registry/gl.py | 1 - 1 file changed, 1 deletion(-) diff --git a/registry/gl.py b/registry/gl.py index b7d2340..9e0e7c8 100644 --- a/registry/gl.py +++ b/registry/gl.py @@ -30,7 +30,6 @@ import os.path import re import

[Piglit] [PATCH 12/12] gen_dispatch.py: silence error

This script manipulates the python path to get at some modules, because of this pylint gives an error (as opposed to a warning) about not being able to import that module. This patch silences that error. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/util/gen_dispatch.py | 2 +- 1

[Piglit] [PATCH 10/12] gen_dispatch.py: remove use of cmp.

gen_dispatch.py contains a function used to sort Enums, and uses cmp. This patch moves that logic into the Enum class using rich comparison methods instead. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- registry/gl.py | 62 ++

[Piglit] [PATCH 00/12] cleanup dispatch generation code

This series is mainly aimed at removing the obsolete cmp function and corresponding __cmp__ method, and replace them with rich comparison methods (__lt__, __eq__, etc). It also makes some opportunistic cleanups of the code, mostly errors in the code, or style changes that are prone to turning into

[Piglit] [PATCH 01/12] piglit-displatch-gen.h.mako: sort comments

From: Dylan Baker dylanx.c.ba...@intel.com Currently the comments are not sorted, and therefor not deterministic, which makes it very difficult to diff the output when trying to make changes and ensure not changes. This makes the output deterministic. Signed-off-by: Dylan Baker

[Piglit] [PATCH 03/12] registry/gl.py: fix no-attribute error

The Command class defines self.requirements, but not self.__requirements, but the vendor_namespace property checks self.__requirements. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- registry/gl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/registry/gl.py

[Piglit] [PATCH 05/12] registry/gl.py: Strip superfluous parens from the assert keyword

In C assert is a function and requires parens, in python it is a keyword, and doesn't require parens. This might not be that big of a deal, but if you put a comma in those parens then then argument becomes a tuple, which will not do what one intends. Signed-off-by: Dylan Baker

[Piglit] [PATCH 06/12] registry/gl.py: remove unused variable

This was spotted by pylint. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- registry/gl.py | 1 - 1 file changed, 1 deletion(-) diff --git a/registry/gl.py b/registry/gl.py index 10078e0..c1ba2ef 100644 --- a/registry/gl.py +++ b/registry/gl.py @@ -926,7 +926,6 @@ class

[Piglit] [PATCH 09/12] gen_dispatch.py: sort imports into groups

From: Dylan Baker dylanx.c.ba...@intel.com PEP8 specifies that imports should be sorted into groups, separated by a blank line. The first should by core modules, the second should be system wide modules, and the third local modules. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com ---

[Piglit] [PATCH 07/12] regsitry/gl.py: Make Error class inherit from Exception

In python 2 it is expected that errors descend from Exception, but there is no requirement that they do so, in python 3 it is required. This also is problematic because it makes the exception class an old style class, which has all the problems associated with old style classes. Signed-off-by:

Re: [Piglit] [PATCH 00/12] cleanup dispatch generation code

Sorry, Chad, I meant to CC you on this, since you wrote most of this code. Dylan On Tuesday, January 13, 2015 05:48:10 PM Dylan Baker wrote: This series is mainly aimed at removing the obsolete cmp function and corresponding __cmp__ method, and replace them with rich comparison methods

Re: [Piglit] [PATCH] texture-packed-formats: Don't try bother with ABGR_EXT formats

On Monday, January 12, 2015 01:14:23 PM Jason Ekstrand wrote: Since GL_ABGR_EXT was extension number 1 to the GL spec, it didn't take packed formats into account. As far as I can tell from the way the packed formats extensions are written, packed formats with GL_ABGR_EXT isn't allowed by the

[Piglit] [PATCH] arb-provoking-vertex-render: a new test that actually checks all prim types

None of the other provoking vertex tests actually check the rendering of all the different primitive types with first/last provoking vertex. --- tests/all.py | 1 + tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH] arb-provoking-vertex-render: a new test that actually checks all prim types

Looks good to me, just a minor nit below. Does not quite check all prim types as it misses the adjacency ones but I guess that would require some more strict gl version check... Reviewed-by: Roland Scheidegger srol...@vmware.com Am 13.01.2015 um 17:57 schrieb Brian Paul: None of the other

Re: [Piglit] [PATCH] arb_get_program_binary: Check piglit_check_gl_error results.

On 01/08/2015 03:24 PM, Vinson Lee wrote: Fix dead assignment bugs reported by Clang Static Analyzer. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/arb_get_program_binary/retrievable_hint.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git