[Piglit] [PATCH 2/2] DSA: CreateTextures() with a NULL argument is allowed to crash

2015-04-24 Thread Arthur Huillet
From: Arthur Huillet ahuil...@nvidia.com The pointer passed to CreateTextures() isn't required by the specification to be checked for validity, and the implementation is allowed to crash (as happens with NVIDIA's). Remove the bogus tests. Signed-off-by: Arthur Huillet ahuil...@nvidia.com ---

Re: [Piglit] [PATCH 1/2] shader_runner: add ARB_shader_subroutine support (v3)

2015-04-24 Thread Brian Paul
On 04/23/2015 06:36 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This adds basic support for executing shader subroutine tests. it comes with two intro tests, and probably a lot of bugs. tested against NVIDIA, for some reason -auto fails here. It might pass if you build

Re: [Piglit] [PATCH 00/14] Fixes for EGL and EGL tests

2015-04-24 Thread Chad Versace
On Mon 13 Apr 2015, Marek Olšák wrote: Hi everyone, These are mostly fixes that I took from Daniel Kurtz's github repository because I think they are good and he said he had no time to upstream them. I've been working on the fence extensions for Mesa/egl_dri2, so I've tested them all. All

[Piglit] [PATCH] arb_shader_image_size: test GLSL's builtin imageSize

2015-04-24 Thread Martin Peres
Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- tests/all.py | 5 + tests/quick.py | 7 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_shader_image_size/CMakeLists.gl.txt | 16

Re: [Piglit] [PATCH 1/2 v2] DSA: fix incorrect errors expected for BindTextureUnit()

2015-04-24 Thread Arthur Huillet
Fix typo and indentation, specify GL spec version the quotes are from. Thanks! ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] DSA: fix incorrect errors expected for BindTextureUnit()

2015-04-24 Thread Arthur Huillet
From: Arthur Huillet ahuil...@nvidia.com Updated BindTextureUnit() to match the OpenGL specification: GL_INVALID_OPERATION is expected when the texture object doesn't exist, not GL_INVALID_ENUM. When the texture unit doesn't exist, the specification doesn't strictly speaking define the error,

Re: [Piglit] [PATCH 2/2] DSA: CreateTextures() with a NULL argument is allowed to crash

2015-04-24 Thread Fredrik Höglund
On Friday 24 April 2015, Arthur Huillet wrote: From: Arthur Huillet ahuil...@nvidia.com The pointer passed to CreateTextures() isn't required by the specification to be checked for validity, and the implementation is allowed to crash (as happens with NVIDIA's). Remove the bogus tests.

Re: [Piglit] [PATCH V3 2/2] arb_arrays_of_arrays: compile test all basic types

2015-04-24 Thread Timothy Arceri
There seems to be no other feedback on this. Do you guys mind if I push this now? On Wed, 2015-04-01 at 16:44 +1100, Timothy Arceri wrote: V3: Tell piglit that GL_ARB_arrays_of_arrays is required V2: fix glsl-1.20-basic-types.vert previously it contained the glsl-4.20-basic-types.frag test

Re: [Piglit] [PATCH 14/14] khr_debug/debug-push-pop-group: fix test

2015-04-24 Thread Timothy Arceri
On Mon, 2015-04-13 at 20:28 +0200, Marek Olšák wrote: From: Daniel Kurtz djku...@chromium.org AFAICT from [0], only PopDebugGroup() adds a message to the log, not PushDebugGroup(). [0] https://www.opengl.org/registry/specs/KHR/debug.txt Thus, there should only be three messages in

Re: [Piglit] [PATCH 1/2] DSA: fix incorrect errors expected for BindTextureUnit()

2015-04-24 Thread Fredrik Höglund
On Friday 24 April 2015, Arthur Huillet wrote: From: Arthur Huillet ahuil...@nvidia.com Updated BindTextureUnit() to match the OpenGL specification: GL_INVALID_OPERATION is expected when the texture object doesn't exist, not GL_INVALID_ENUM. When the texture unit doesn't exist, the

Re: [Piglit] [PATCH 1/2 v2] DSA: fix incorrect errors expected for BindTextureUnit()

2015-04-24 Thread Arthur Huillet
On 2015-04-24 17:58, Arthur Huillet wrote: Fix typo and indentation, specify GL spec version the quotes are from. ... and I apologize for publicly shooting myself in the foot with git-send-email. :) -- Greetings, A.H. ___ Piglit mailing list

Re: [Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

2015-04-24 Thread Chad Versace
On Mon 13 Apr 2015, Marek Olšák wrote: From: Daniel Kurtz djku...@chromium.org eglGetProcAddress() only supports extension functions. Therefore, we must use dlsym() directly on the GL client library to look up core functions. The implementation here is a much simplified version of the one