[Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-18 Thread Timothy Arceri
fragment shader tests already exist, this adds vertex and geometry tests for completeness. Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass Cc: Ilia Mirkin imir...@alum.mit.edu --- .../gs-struct-nonconst-sampler-const.shader_test | 91

[Piglit] [PATCH] all.py: Actually add_texwrap_target_tests's target parameter to the test.

2015-06-18 Thread Jose Fonseca
The target was only being used for the test name -- all test instances were duplicate of one another. Noticed this because llvmpipe started failing several tests when offset was added, and all test command lines were exactly the same. --- tests/all.py | 12 +++- 1 file changed, 7

Re: [Piglit] [PATCH] sampler_array_indexing: also check that texture coordinates work

2015-06-18 Thread Neil Roberts
Looks good to me. Thanks for doing that. Reviewed-by: Neil Roberts n...@linux.intel.com Regards, - Neil Timothy Arceri t_arc...@yahoo.com.au writes: Previously the shaders were using a checkerboard texture with identical colours for each part of the grid. That meant that it didn't actually

[Piglit] [PATCH] sampler_array_indexing: also check that texture coordinates work

2015-06-18 Thread Timothy Arceri
Previously the shaders were using a checkerboard texture with identical colours for each part of the grid. That meant that it didn't actually matter what texture coordinates were used to sample. This patch changes it so that they all have a dark red colour for one of the colours and then it

Re: [Piglit] [PATCH] arb_dsa: avoid non-determinism in create-programpipelines subtests

2015-06-18 Thread Jose Fonseca
On 18/06/15 03:37, Ilia Mirkin wrote: Right now the default label size test fails due to mesa not implementing the call, and length is uninitialized, which causes the subtest name to keep changing. A well-behaved impl won't modify the param on error, so initialize it to a known-bad value.

Re: [Piglit] [PATCH] all.py: Actually add_texwrap_target_tests's target parameter to the test.

2015-06-18 Thread Roland Scheidegger
Am 18.06.2015 um 15:10 schrieb Jose Fonseca: The target was only being used for the test name -- all test instances were duplicate of one another. Noticed this because llvmpipe started failing several tests when offset was added, and all test command lines were exactly the same. ---

Re: [Piglit] [PATCH] khr-debug: fix broken label test

2015-06-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Thu, Jun 18, 2015 at 5:06 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- tests/spec/khr_debug/debug-object-label.c | 36 --- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-18 Thread Kenneth Graunke
On Saturday, June 06, 2015 07:11:26 PM Kenneth Graunke wrote: Hi all, This patch series ports all vpfp-generic tests to shader_runner, and then deletes vpfp-generic. A bit of history: - vpfp-generic was introduced by Nicolai Hähnle in 2009, as a generic ARB_vertex|fragment_program test

Re: [Piglit] [1/2] sample-mask-execution: fix misleading description

2015-06-18 Thread Timothy Arceri
Was just looking at patchwork seems this is the oldest unreviewed patch in there. If you also fix line 37 then to * - render a green thing Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] all.py: Actually add_texwrap_target_tests's target parameter to the test.

2015-06-18 Thread Dylan Baker
Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Jun 18, 2015 6:11 AM, Jose Fonseca jfons...@vmware.com wrote: The target was only being used for the test name -- all test instances were duplicate of one another. Noticed this because llvmpipe started failing several tests when offset was

Re: [Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu I can't say I read this in *extensive* detail, but it basically looks right. Thanks! On Thu, Jun 18, 2015 at 9:28 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: fragment shader tests already exist, this adds vertex and geometry tests for

[Piglit] [PATCH] khr-debug: fix broken label test

2015-06-18 Thread Timothy Arceri
--- tests/spec/khr_debug/debug-object-label.c | 36 --- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/tests/spec/khr_debug/debug-object-label.c b/tests/spec/khr_debug/debug-object-label.c index 151e684..ad4c9fc 100644 ---