Re: [Piglit] [PATCH 4/5] all.py: fix misnamed tests

2015-07-13 Thread Timothy Arceri
This patch is: Reviewed-by: Timothy Arceri t_arceri at yahoo.com.au On Tue, 2015-02-03 at 12:09 -0800, Dylan Baker wrote: At some point OpenGL 3.2 was shortened to OpenGL, which is clearly wrong Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/all.py | 4 ++-- 1 file

Re: [Piglit] [PATCH v2] cl: add clLinkProgram test

2015-07-13 Thread Timothy Arceri
On Tue, 2015-01-06 at 21:20 +0100, EdB wrote: I don't have commit acces. Can someone push it? I think you need to update tests/cl.py before this can be pushed. Le 2014-12-19 20:41, Tom Stellard a écrit : On Fri, Dec 19, 2014 at 02:39:06PM +0100, EdB wrote: v2: Use

Re: [Piglit] [PATCH] framework: add a timeout command line parameter

2015-07-13 Thread Thomas Wood
On 10 July 2015 at 19:24, Dylan Baker baker.dyla...@gmail.com wrote: Hi Thomas, I meant to get back to you earlier on this, but I forgot yesterday when I got bogged down in Jenkins madness. Anyway, if you have a look at the (I think) 2nd patch in my python3 series, you'll notice that I had

Re: [Piglit] [PATCH v2] glsl-1.10 Adds tests on how void functions are handled

2015-07-13 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com I have already pushed this piglit patch. Just confirm me to do the same for the mesa patch. Sam On Sat, 2015-07-11 at 22:59 +0200, Renaud Gaubert wrote: Mesa currently doesn't handle void functions and segfaults on almost all of the

[Piglit] [PATCH] ext_packed_float: fix getteximage-invalid-format-for-packed-type test

2015-07-13 Thread Brian Paul
The GL spec doesn't explicitly say that glGetTexImage should generate GL_INVALID_OPERATION when attempting to retrieve a non-existant texture image, but that's what NVIDIA's driver does. The purpose of this test is to check the format/type parameters, so let's define a packed float texture to

[Piglit] [PATCH] point-vertex-id: Additionally test with gl_InstanceID

2015-07-13 Thread Neil Roberts
The point-vertex-id test was originally created to test gl_VertexID in combination with glPolygonMode(GL_POINT) because of a bug with the i965 driver in Mesa. The same bug exists with gl_InstanceID and the code for BDW has some extra complications in this case so I think it's worth extending the

[Piglit] [PATCH 3/3] framework/tests: reduce code duplication between test modules

2015-07-13 Thread Dylan Baker
Shares the setup and teardown functions for locking compression modes between the various backend test modules. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/tests/json_backend_tests.py| 16 ++-- framework/tests/json_results_update_tests.py | 15

[Piglit] [PATCH 2/3] compression.py: fix compression to be updated when piglit.conf is reloaded

2015-07-13 Thread Dylan Baker
There is currently a bug in piglit (demonstrated by the previous patch), that shows that compression is hard set before piglit.conf is loaded in run, and not affected by any subsequent re-reads of piglit.conf. This is problematic, resulting in the compression mode being either PIGLIT_COMPRESSION

[Piglit] [PATCH 0/3] framework: fix setting compression for piglit.conf

2015-07-13 Thread Dylan Baker
Here's a case of we pass all the unit tests, but we missed testing some very important corners. The basic problem is that if piglit.conf is updated and reloaded, the compression mode will not reflect that. Dylan Baker (3): compressed_backend_tests.py: add test to demonstrate bug in

[Piglit] [PATCH 1/3] compressed_backend_tests.py: add test to demonstrate bug in compression

2015-07-13 Thread Dylan Baker
Currently the compression code has no way to handle a change in piglit.conf (which incidentally it needs to, since that happens immediately in run mode). This results in the default mode (bz2) being picked when a PIGLIT_COMPRESSION environment variable isn't specified, even when a piglit.conf

Re: [Piglit] [PATCH 4/5] all.py: fix misnamed tests

2015-07-13 Thread Dylan Baker
On Mon, Jul 13, 2015 at 07:02:25PM +1000, Timothy Arceri wrote: This patch is: Reviewed-by: Timothy Arceri t_arceri at yahoo.com.au I think everything in this series except the last patch landed. Eric wanted to keep es3conform so it was kept. signature.asc Description: Digital signature

Re: [Piglit] [PATCH] framework: add a timeout command line parameter

2015-07-13 Thread Dylan Baker
On Mon, Jul 13, 2015 at 02:09:26PM +0100, Thomas Wood wrote: On 10 July 2015 at 19:24, Dylan Baker baker.dyla...@gmail.com wrote: Hi Thomas, I meant to get back to you earlier on this, but I forgot yesterday when I got bogged down in Jenkins madness. Anyway, if you have a look at

[Piglit] [PATCH] arb_get_texture_sub_image: new tests for GL_ARB_get_texture_sub_image

2015-07-13 Thread Brian Paul
errors.c - test error detection get.c - test glGetTextureSubImage getcompressed.c - test glGetCompressedTextureSubImage cubemap.c - extra tests for getting cubemap images --- tests/all.py | 7 + tests/spec/CMakeLists.txt | 1 +