Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-23 Thread Ian Romanick
On 11/20/2015 04:56 PM, Dylan Baker wrote: > On Fri, Nov 20, 2015 at 03:05:49PM -0800, Ian Romanick wrote: >> On 11/20/2015 02:14 PM, Dylan Baker wrote: >>> On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: From: Ian Romanick If this test has

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ian Romanick
On 11/21/2015 04:08 PM, Ilia Mirkin wrote: > In the check_error case, decompressed_tex is completely uninitialized > and might point to any texture. This can wreak various havoc. I might suggest a different approach. In the check_error case, ensure that decompress_texture is zero. Remove the

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

2015-11-23 Thread Martin Peres
On 02/11/15 16:57, yann.argo...@linux.intel.com wrote: This adds a policy which advises when user should reboot system to avoid noisy test results due to system becoming unstable, for instance, and therefore continues testing successfully. To do this, a new Dmesg class is proposed which is not

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: Test linking programs with large copies

2015-11-23 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga I guess you will also send the struct version of this, right? Iago On Fri, 2015-11-20 at 10:58 -0800, Jordan Justen wrote: > We test linking of programs that copy a large array, and a large > structure. > > Signed-off-by: Jordan Justen

[Piglit] [PATCH V2] arb_separate_shader_objects: test mixed explicit and non-explicit locations

2015-11-23 Thread Timothy Arceri
This tests a bug in Mesa where explicit locations are not taken into account when assigning varying locations which results in two inputs/outputs being given the same location. Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.1-dev: pass V2: use pick_a_glsl_version() helper

Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-23 Thread Dylan Baker
On Mon, Nov 23, 2015 at 12:16:33PM -0800, Ian Romanick wrote: > On 11/20/2015 04:56 PM, Dylan Baker wrote: > > On Fri, Nov 20, 2015 at 03:05:49PM -0800, Ian Romanick wrote: > >> On 11/20/2015 02:14 PM, Dylan Baker wrote: > >>> On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: >

Re: [Piglit] [PATCH V2] arb_separate_shader_objects: test mixed explicit and non-explicit locations

2015-11-23 Thread Timothy Arceri
On Mon, 2015-11-23 at 17:21 -0500, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 5:15 PM, Timothy Arceri > wrote: > > diff --git a/tests/all.py b/tests/all.py > > index e80f3af..3adc503 100644 > > --- a/tests/all.py > > +++ b/tests/all.py > > @@ -2160,6 +2160,8 @@ with

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 Igor Gnatenko changed: What|Removed |Added Status|NEEDINFO|NEW ---

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 Dylan changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 20:48, Ian Romanick wrote: > On 11/22/2015 03:43 AM, Emil Velikov wrote: >> On 11 November 2015 at 18:07, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Noticed as some of these have been

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 --- Comment #3 from Dylan --- I don't know what I did wrong the first time by I can replicate now. You're missing a configure option to get CL tests, they're off by default. add -DPIGLIT_BUILD_CL_TESTS=1 and you should

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

2015-11-23 Thread Dylan Baker
On Mon, Nov 23, 2015 at 08:54:46PM -0500, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 8:41 PM, Dylan Baker wrote: > > On Mon, Nov 23, 2015 at 08:24:22PM -0500, Ilia Mirkin wrote: > >> On Mon, Nov 23, 2015 at 8:07 PM, Dylan Baker > >> wrote: >

[Piglit] (no subject)

2015-11-23 Thread baker . dylan . c
From 2e48338e4e4f20bc9923d7b731de660361f75b83 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Mon, 23 Nov 2015 21:47:44 -0800 Subject: [PATCH 0/6] Make dmesg tests more robust and cleanup a few nits This was meant to be a single patch that reworked the dmesg tests to

[Piglit] [PATCH 6/6] dmesg.py: use all future imports that are supported by the project.

2015-11-23 Thread baker . dylan . c
From: Dylan Baker Since division isn't used in the module this is a trivial change. Signed-off-by: Dylan Baker --- framework/dmesg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/dmesg.py b/framework/dmesg.py

[Piglit] [PATCH 5/6] dmesg.py: sort import and exports

2015-11-23 Thread baker . dylan . c
From: Dylan Baker Trivial. Signed-off-by: Dylan Baker --- framework/dmesg.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/framework/dmesg.py b/framework/dmesg.py index f44d4a8..42ac48f 100644 ---

[Piglit] [PATCH 2/6] dmesg.py: fix indents which are 8 space but should be 4

2015-11-23 Thread baker . dylan . c
From: Dylan Baker Trivial. Signed-off-by: Dylan Baker --- framework/dmesg.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/framework/dmesg.py b/framework/dmesg.py index daeeeae..1982dec 100644 ---

[Piglit] [PATCH 4/6] dmesg.py: Remove DmesgError.

2015-11-23 Thread baker . dylan . c
From: Dylan Baker This exception predates the exceptions module. The only instance of this error is used in a place where piglit should stop because it cannot continue, which is what PiglitFatalError is for. Signed-off-by: Dylan Baker ---

[Piglit] [PATCH 1/6] dmesg_tests.py: rework entire module to be better

2015-11-23 Thread baker . dylan . c
From: Dylan Baker This module reworks the dmesg testing to be much more robust, largely by taking advantage of the mock module. This allows us test test dmesg without actually calling dmesg, which eliminates the need for root privileges, and allowing all tests to run on

[Piglit] [PATCH 0/6] Make dmesg tests more robust and cleanup a few nits

2015-11-23 Thread baker . dylan . c
From: Dylan Baker This was meant to be a single patch that reworked the dmesg tests to use mock, thus not requiring root. During this I noticed a few small things that needing fixing/updating in the dmesg module. The changes are *very* minor, most of them to the point

[Piglit] [PATCH 3/6] dmesg.py: Actually make the BaseDmesg an ABC.

2015-11-23 Thread baker . dylan . c
From: Dylan Baker Currently this class uses the abc decorators, but its type isn't actually abc.ABCMeta, which makes the abc decorators no-ops. This fixes that. Signed-off-by: Dylan Baker --- framework/dmesg.py | 2 ++ 1 file changed, 2

Re: [Piglit] (no subject)

2015-11-23 Thread Dylan Baker
On Mon, Nov 23, 2015 at 09:59:22PM -0800, baker.dyla...@gmail.com wrote: > From 2e48338e4e4f20bc9923d7b731de660361f75b83 Mon Sep 17 00:00:00 2001 > From: Dylan Baker > Date: Mon, 23 Nov 2015 21:47:44 -0800 > Subject: [PATCH 0/6] Make dmesg tests more robust and cleanup a

[Piglit] [PATCH] sso: test program pipeline with atomic counters

2015-11-23 Thread Tapani Pälli
Test fails on current Mesa and NVIDIA binary driver version 355.11, don't have currently AMD machine to test with. Signed-off-by: Tapani Pälli --- tests/all.py | 2 + .../arb_separate_shader_objects/CMakeLists.gl.txt | 1 +

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 --- Comment #5 from Dylan --- I agree, and I was looking into it. In the meantime, did this fix the issue for you? -- You are receiving this mail because: You are the QA Contact for the bug.

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 --- Comment #6 from Igor Gnatenko --- It's still building. -- You are receiving this mail because: You are the QA Contact for the bug. ___ Piglit mailing list

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 --- Comment #4 from Igor Gnatenko --- I think we shouldn't install opencl profile also if we dont build ocl tests. -- You are receiving this mail because: You are the QA Contact for the bug.

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 --- Comment #7 from Igor Gnatenko --- Yes, it fixed issue. I got some fails in test suite, but I will open other bugs. -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

2015-11-23 Thread Dylan Baker
On Mon, Nov 23, 2015 at 02:48:35PM +0200, Martin Peres wrote: > On 02/11/15 16:57, yann.argo...@linux.intel.com wrote: > >This adds a policy which advises when user should reboot system to avoid > >noisy test results due to system becoming unstable, for instance, and > >therefore continues testing

[Piglit] [PATCH 2/2] cmake: only install files for APIs that are built

2015-11-23 Thread baker . dylan . c
From: Dylan Baker This configures piglit to only install the following features if they're enabled: - profiles - generated files - shader_test,program_test,{shader stage},ktx,cl,etc The basic idea is that if one doesn't build OpenGL, then the OpenGL tests and profiles

[Piglit] [Bug 93064] no generated_tests for CL

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93064 Dylan changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-23 Thread Ian Romanick
On 11/23/2015 03:07 PM, Emil Velikov wrote: > On 23 November 2015 at 20:48, Ian Romanick wrote: >> On 11/22/2015 03:43 AM, Emil Velikov wrote: >>> On 11 November 2015 at 18:07, Emil Velikov wrote: From: Emil Velikov

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 8:07 PM, Dylan Baker wrote: > On Mon, Nov 23, 2015 at 02:48:35PM +0200, Martin Peres wrote: >> On 02/11/15 16:57, yann.argo...@linux.intel.com wrote: >> >This adds a policy which advises when user should reboot system to avoid >> >noisy test

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 8:41 PM, Dylan Baker wrote: > On Mon, Nov 23, 2015 at 08:24:22PM -0500, Ilia Mirkin wrote: >> On Mon, Nov 23, 2015 at 8:07 PM, Dylan Baker wrote: >> > On Mon, Nov 23, 2015 at 02:48:35PM +0200, Martin Peres wrote: >> >> On

Re: [Piglit] [PATCH 5/6] dmesg.py: sort import and exports

2015-11-23 Thread Vinson Lee
On Mon, Nov 23, 2015 at 10:01 PM, wrote: > From: Dylan Baker > > Trivial. > > Signed-off-by: Dylan Baker > --- > framework/dmesg.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Piglit] [PATCH 2/6] dmesg.py: fix indents which are 8 space but should be 4

2015-11-23 Thread Vinson Lee
On Mon, Nov 23, 2015 at 10:01 PM, wrote: > From: Dylan Baker > > Trivial. > > Signed-off-by: Dylan Baker > --- > framework/dmesg.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Piglit] non-concurrent piglit tests

2015-11-23 Thread Eric Anholt
Ilia Mirkin writes: > On Sun, Nov 22, 2015 at 7:12 PM, Eric Anholt wrote: >> Ilia Mirkin writes: >> >>> It looks like we're up to something like 1K non-concurrent piglit >>> tests... maybe more. Can someone who actually understands

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 3:48 PM, Ian Romanick wrote: > On 11/22/2015 03:43 AM, Emil Velikov wrote: >> On 11 November 2015 at 18:07, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Noticed as some of these have been

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick wrote: > On 11/21/2015 04:08 PM, Ilia Mirkin wrote: >> In the check_error case, decompressed_tex is completely uninitialized >> and might point to any texture. This can wreak various havoc. > > I might suggest a different

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-23 Thread Ian Romanick
On 11/22/2015 03:43 AM, Emil Velikov wrote: > On 11 November 2015 at 18:07, Emil Velikov wrote: >> From: Emil Velikov >> >> Noticed as some of these have been intermittently failing on llvmpipe, >> resulting in a few "not run" test across

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ian Romanick
On 11/23/2015 12:43 PM, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick wrote: >> On 11/21/2015 04:08 PM, Ilia Mirkin wrote: >>> In the check_error case, decompressed_tex is completely uninitialized >>> and might point to any texture. This can wreak

Re: [Piglit] [PATCH] texture-integer: use usampler/uint value

2015-11-23 Thread Ian Romanick
On 11/20/2015 09:24 PM, Ilia Mirkin wrote: > All of the random values are positive. Mixing uint texture with isampler > is not allowed, and happens to cause problems for freedreno. Using uint > works. I guess I'm confused what the actual problem is. The test previously used isampler with ivec4.

Re: [Piglit] [PATCH] texture-integer: use usampler/uint value

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 4:17 PM, Ian Romanick wrote: > On 11/20/2015 09:24 PM, Ilia Mirkin wrote: >> All of the random values are positive. Mixing uint texture with isampler >> is not allowed, and happens to cause problems for freedreno. Using uint >> works. > > I guess I'm