[Piglit] [PATCH 5/5] texwrap: Allow compressed test to run with GL_EXT_texture_compression_dxt1 and friends

2015-12-02 Thread Ian Romanick
From: Ian Romanick All of the data is pre-compressed DXT[134] textures, so there is no need for any of the more functional S3TC related extensions. Signed-off-by: Ian Romanick --- tests/texturing/texwrap.c | 31

[Piglit] [PATCH 4/5] texwrap: Refactor getting the test vector for a name

2015-12-02 Thread Ian Romanick
From: Ian Romanick The indentation was getting a bit out of hand, and the next patch was going to make it even worse. Signed-off-by: Ian Romanick --- tests/texturing/texwrap.c | 38 +- 1 file changed, 25

[Piglit] [PATCH 3/5] arb_get_texture_sub_image: Allow compressed test to run with GL_EXT_texture_compression_dxt1 and friends

2015-12-02 Thread Ian Romanick
From: Ian Romanick All of the data is pre-compressed DXT[134] textures, so there is no need for any of the more functional S3TC related extensions. Also... GL_ARB_texture_non_power_of_two is a required part of OpenGL 2.0. Since the test already requires OpenGL 2.0,

[Piglit] [PATCH 1/4] primitive-restart: Remove comment about GLEW 1.5.2

2015-12-02 Thread Ian Romanick
From: Ian Romanick Piglit doesn't use GLEW, so the GLEW version doesn't matter. Signed-off-by: Ian Romanick --- tests/general/primitive-restart.c | 4 1 file changed, 4 deletions(-) diff --git a/tests/general/primitive-restart.c

[Piglit] [PATCH 2/4] primitive-restart: Remove compile-time tests for GL 3.1

2015-12-02 Thread Ian Romanick
From: Ian Romanick These were added in 28ca3c1, and they were a good idea in 2010. I think it's safe to count on glext.h with the proper functions today. Signed-off-by: Ian Romanick Cc: Brian Paul ---

[Piglit] [PATCH 4/4] primitive-restart: Replace assert(glGetError()==0)

2015-12-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- tests/general/primitive-restart.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/general/primitive-restart.c b/tests/general/primitive-restart.c index

[Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

2015-12-02 Thread Ian Romanick
From: Ian Romanick Further discussion in Khronos has determined that UTF-8 in unused preprocessor defines as well. See Khronos internal bug #14939. Signed-off-by: Ian Romanick --- .../glsl-es-3.00/compiler/utf8-unused-define.vert | 26

[Piglit] [PATCH 3/4] primitive-restart: Use stdbool

2015-12-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- tests/general/primitive-restart.c | 60 +++ 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/tests/general/primitive-restart.c

[Piglit] [PATCH 0/4] Clean ups that were sitting in my tree

2015-12-02 Thread Ian Romanick
These are just some cleanups for the primitive restart tests. I did these while I was getting ready to do something else with the tests. I got distracted and forgot about about whatever I was originally going to do. :( ___ Piglit mailing list

[Piglit] [PATCH 2/5] ext_texture_array: Use piglit_build_simple_program

2015-12-02 Thread Ian Romanick
From: Ian Romanick I don't think piglit_build_simple_program supported piglit_vertex and piglit_texcoord when this test was written, but it does now. Use it! Signed-off-by: Ian Romanick --- tests/spec/ext_texture_array/compressed.c | 17

[Piglit] [PATCH 1/5] ext_texture_array: Allow compressed test to run with GL_EXT_texture_compression_dxt1

2015-12-02 Thread Ian Romanick
From: Ian Romanick All of the data is pre-compressed DXT1 textures, so there is no need for any of the more functional S3TC related extensions. Also... GL_ARB_texture_compress is a required part of OpenGL 1.3. Since the test already requires OpenGL 2.1, there is no

Re: [Piglit] [PATCH 0/4] Clean ups that were sitting in my tree

2015-12-02 Thread Matt Turner
This series is also Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/5] ext_texture_array: Allow compressed test to run with GL_EXT_texture_compression_dxt1

2015-12-02 Thread Matt Turner
This series is Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

2015-12-02 Thread Matt Turner
On Wed, Dec 2, 2015 at 8:42 AM, Ian Romanick wrote: > From: Ian Romanick > > Further discussion in Khronos has determined that UTF-8 in unused > preprocessor defines as well. > > See Khronos internal bug #14939. > > Signed-off-by: Ian Romanick

[Piglit] [PATCH 2/3] tests/all.py: Make MSAA_SAMPLE_COUNTS contain str() instead of int()

2015-12-02 Thread baker . dylan . c
From: Dylan Baker In every case MSAA_SAMPLES_COUNTS are converted to str() anyway, (either explicitly by calling str(), or implicitly by str.format(). This is often done with a pattern like: (str(x) for x in MSAA_SAMPLE_COUNTS). This is just a waste of time when the

[Piglit] [PATCH 3/3] tests/all.py: Make MSAA_SAMPLE_COUNTS a list instead of a tuple

2015-12-02 Thread baker . dylan . c
From: Dylan Baker The problem with using MSAA_SAMPLE_COUNTS as a tuple is that it isn't a tuple. It's a sequence of like values, and is combined with other sequences of values, this is what a list is for. Signed-off-by: Dylan Baker ---

[Piglit] [PATCH 1/3] tests/all.py: hide some pylint warnings that can't be (easily) fixed.

2015-12-02 Thread baker . dylan . c
From: Dylan Baker Signed-off-by: Dylan Baker --- tests/all.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index 9f1b4f3..03da7cd 100644 --- a/tests/all.py +++ b/tests/all.py @@ -20,6

[Piglit] [PATCH 0/3] replace MSAA sample counts with strings

2015-12-02 Thread baker . dylan . c
From: Dylan Baker The current implementation is a tuple of ints, and this series changes that to a list of strs. In nearly every case the ints were being either explicitly converted to str, or implicitly (using str.format). In the couple of cases that it wasn't being

Re: [Piglit] [PATCH 1/3] tests/all.py: hide some pylint warnings that can't be (easily) fixed.

2015-12-02 Thread Vinson Lee
On Wed, Dec 2, 2015 at 2:36 PM, wrote: > From: Dylan Baker > > Signed-off-by: Dylan Baker > --- > tests/all.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tests/all.py b/tests/all.py

Re: [Piglit] [PATCH] shader_runner: Add basic SSO support to shader runner

2015-12-02 Thread Timothy Arceri
On Thu, 2015-12-03 at 17:41 +1100, Timothy Arceri wrote: > This sets up the basics for using SSO with shader runner. This will > only support vertex and fragment shaders but is easily extended. > > Example shader: > > [require] > GLSL >= 1.50 > > [vertex sso] Git commit ate the version and

Re: [Piglit] [PATCH 4/4] primitive-restart: Replace assert(glGetError()==0)

2015-12-02 Thread Vinson Lee
On Wed, Dec 2, 2015 at 8:49 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > tests/general/primitive-restart.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > >

[Piglit] [PATCH] shader_runner: Add basic SSO support to shader runner

2015-12-02 Thread Timothy Arceri
This sets up the basics for using SSO with shader runner. This will only support vertex and fragment shaders but is easily extended. Example shader: [require] GLSL >= 1.50 [vertex sso] layout(location = 0) in vec4 piglit_vertex; layout(location = 2) out vec3 a; layout(location = 3) out vec3

Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

2015-12-02 Thread Michel Dänzer
On 03.12.2015 01:42, Ian Romanick wrote: > > +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。 The nouns are reversed in the Japanese text, so it actually means "eat chopsticks using sushi". :) There should also be an を particle for the chopsticks, so it should be 箸を使用して寿司を食べます。 -- Earthling

Re: [Piglit] [PATCH 2/3] tests/all.py: Make MSAA_SAMPLE_COUNTS contain str() instead of int()

2015-12-02 Thread Vinson Lee
On Wed, Dec 2, 2015 at 2:36 PM, wrote: > From: Dylan Baker > > In every case MSAA_SAMPLES_COUNTS are converted to str() anyway, (either > explicitly by calling str(), or implicitly by str.format(). This is > often done with a pattern like:

Re: [Piglit] [PATCH] glsl-1.10: add a test that has an a while loop with unconditional return

2015-12-02 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 12/03/2015 01:44 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- This crashes on nouveau, passes on i965/hsw and llvmpipe. .../glsl-1.10/execution/fs-loop-return.shader_test | 20 1

Re: [Piglit] [PATCH 3/3] tests/all.py: Make MSAA_SAMPLE_COUNTS a list instead of a tuple

2015-12-02 Thread Ilia Mirkin
On Wed, Dec 2, 2015 at 9:04 PM, Dylan Baker wrote: > On Wed, Dec 02, 2015 at 06:13:48PM -0500, Ilia Mirkin wrote: >> On Wed, Dec 2, 2015 at 5:36 PM, wrote: >> > From: Dylan Baker >> > >> > The problem with using

Re: [Piglit] [PATCH 3/3] tests/all.py: Make MSAA_SAMPLE_COUNTS a list instead of a tuple

2015-12-02 Thread Ilia Mirkin
On Wed, Dec 2, 2015 at 5:36 PM, wrote: > From: Dylan Baker > > The problem with using MSAA_SAMPLE_COUNTS as a tuple is that it isn't a > tuple. It's a sequence of like values, and is combined with other > sequences of values, this is what a list

[Piglit] [PATCH] glsl-1.10: add a test that has an a while loop with unconditional return

2015-12-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This crashes on nouveau, passes on i965/hsw and llvmpipe. .../glsl-1.10/execution/fs-loop-return.shader_test | 20 1 file changed, 20 insertions(+) create mode 100644

[Piglit] Piglit and Android (Was Re: [PATCH v3] khr_texture_compression_astc: Enable subtest reports)

2015-12-02 Thread Emil Velikov
On 1 December 2015 at 19:14, Ilia Mirkin wrote: > There's no easy way (currently) to run piglit tests against android > userspace, and even if there were, their drivers tend to be pretty > weak in terms of ... working. > While I cannot comment on the driver side there has