Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

Hi Jan/Tom, Sorry to resurrect an ancient thread, but I was poking at the piglit CL ULP issue last night, and thought I'd try to get us closer to a solution after dropping the matter for too long. I've modified your test program with what I was thinking of trying, and I wouldn't mind your

Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

On Tue, Dec 29, 2015 at 1:01 PM, Aaron Watry wrote: > Hi Jan/Tom, > > Sorry to resurrect an ancient thread, but I was poking at the piglit CL ULP > issue last night, and thought I'd try to get us closer to a solution after > dropping the matter for too long. > > I've modified

[Piglit] [PATCH 1/4] arb_enhanced_layouts: fix up test comments

Remove line describing the test that is wrong and tidy up alignment of spec quote. Cc: Emil Velikov --- .../explicit-offsets/ssbo-offset-multiple-of-base-member-align.vert | 6 ++ .../explicit-offsets/ubo-offset-multiple-of-base-member-align.vert | 6 ++ 2

[Piglit] [PATCH 3/4] arb_enhanced_layouts: test offset is a multiple of base alignment for vec4

Cc: Emil Velikov --- ...-offset-multiple-of-base-member-align-vec4.vert | 25 ++ ...-offset-multiple-of-base-member-align-vec4.vert | 24 + 2 files changed, 49 insertions(+) create mode 100644

[Piglit] [PATCH 2/4] arb_enhanced_layouts: fix constant expression offset tests

Offset must be a multiple of the base alignment which is 16 for a vec4. Cc: Emil Velikov --- .../explicit-offsets/ssbo-integral-constant-expression-offset.vert | 2 +- .../explicit-offsets/ubo-integral-constant-expression-offset.vert | 2 +- 2 files changed,

[Piglit] [PATCH] arb_enhanced_layouts: fix offset link tests to work with GLSL 1.40

Cc: Emil Velikov --- .../intrastage-ssbo-different-offset-across-shaders.shader_test | 4 +++- .../intrastage-ubo-different-offset-across-shaders.shader_test| 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Piglit] [PATCH 4/4] arb_enhanced_layouts: fix comments in component layout test

--- .../execution/component-layout/vs-tcs-tes-fs.shader_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_enhanced_layouts/execution/component-layout/vs-tcs-tes-fs.shader_test

Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

On Tue, Dec 29, 2015 at 3:18 PM, Aaron Watry wrote: > Regardless of whether 0.0 is the absolutely correct answer for > cos(1.57079632679), we can hopefully all agree that -4.0 is NOT a valid > answer for cosine of anything Right so that's clearly wrong :) I was largely warning

Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

On Tue, Dec 29, 2015 at 2:28 PM, Ilia Mirkin wrote: > On Tue, Dec 29, 2015 at 3:18 PM, Aaron Watry wrote: > > Regardless of whether 0.0 is the absolutely correct answer for > > cos(1.57079632679), we can hopefully all agree that -4.0 is NOT a valid > >

Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

On Tue, Dec 29, 2015 at 12:16 PM, Ilia Mirkin wrote: > On Tue, Dec 29, 2015 at 1:01 PM, Aaron Watry wrote: > > Hi Jan/Tom, > > > > Sorry to resurrect an ancient thread, but I was poking at the piglit CL > ULP > > issue last night, and thought I'd try to