[Piglit] [PATCH v2] built-in-constants: Add geometry shader #extension work-around for ES

From: Ian Romanick I thought I had this in my previous series, but I cannot find any trace of it. Prevents a regression in tests/spec/glsl-es-3.10/minimum-maximums.txt after GL_OES_geometry_shader is enabled. It also fixes tests/spec/oes_geometry_shader/minimum-maximums.txt v2: Add extension e

Re: [Piglit] [PATCH] Use right comparison function for double

On Wed, 2016-08-24 at 20:19 +0100, Ian Romanick wrote: > The subject line should be tagged "cl:" so that people know it's an > OpenCL related patch. I added the prefix before pushing. Jan > > On 08/24/2016 05:33 AM, arse...@gmail.com wrote: > > > > From: Matt Arsenault > > > > --- > >  tests

Re: [Piglit] [PATCH] Use right comparison function for double

On Wed, 2016-08-24 at 12:16 -0700, Matt Arsenault wrote: > > > > On Aug 24, 2016, at 08:11, Jan Vesely > u> wrote: > > > > On Tue, 2016-08-23 at 21:33 -0700, arse...@gmail.com wrote: > > > > > > From: Matt Arsenault > > > > I guess more cases can be consolidated this way... > > > > Reviewed-

Re: [Piglit] [PATCH] glsl: Verify that #version 0 generates an error instead of crashing

Quoting Ian Romanick (2016-08-24 12:32:15) > From: Ian Romanick > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97420 > --- > tests/spec/glsl-1.10/compiler/version-0.frag| 8 > tests/spec/glsl-1.10/compiler/version-0.vert| 8 >

[Piglit] [PATCH] glsl: Verify that #version 0 generates an error instead of crashing

From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97420 --- tests/spec/glsl-1.10/compiler/version-0.frag| 8 tests/spec/glsl-1.10/compiler/version-0.vert| 8 tests/spec/glsl-es-3.00/compiler/version-0.frag | 8 +++

Re: [Piglit] [PATCH] Use right comparison function for double

The subject line should be tagged "cl:" so that people know it's an OpenCL related patch. On 08/24/2016 05:33 AM, arse...@gmail.com wrote: > From: Matt Arsenault > > --- > tests/cl/program/program-tester.c | 12 ++-- > tests/util/piglit-util-cl.c | 2 +- > 2 files changed, 7 inse

Re: [Piglit] [PATCH] Use right comparison function for double

> On Aug 24, 2016, at 08:11, Jan Vesely wrote: > > On Tue, 2016-08-23 at 21:33 -0700, arse...@gmail.com wrote: >> From: Matt Arsenault > > I guess more cases can be consolidated this way... > > Reviewed-by: Jan Vesely > > Jan > I need someone to commit this for me

[Piglit] [PATCH] built-in-constants: Add geometry shader #extension work-around for ES

From: Ian Romanick I thought I had this in my previous series, but I cannot find any trace of it. Prevents a regression in tests/spec/glsl-es-3.10/minimum-maximums.txt after GL_OES_geometry_shader is enabled. Signed-off-by: Ian Romanick --- tests/shaders/built-in-constants.c | 11 +++

Re: [Piglit] [PATCH] Fix use of uninitialized variable valgrind error

On Tue, 2016-08-23 at 21:37 -0700, arse...@gmail.com wrote: > From: Matt Arsenault Reviewed-by: Jan Vesely although I would not expect random value to be a valid mem object. Jan > > --- >  tests/cl/api/set-kernel-arg.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [Piglit] [PATCH] Use right comparison function for double

On Tue, 2016-08-23 at 21:33 -0700, arse...@gmail.com wrote: > From: Matt Arsenault I guess more cases can be consolidated this way... Reviewed-by: Jan Vesely Jan > > --- >  tests/cl/program/program-tester.c | 12 ++-- >  tests/util/piglit-util-cl.c   |  2 +- >  2 files changed, 7

Re: [Piglit] [PATCH v2] arb_program_interface_query: add compare-with-shader-subroutine test

Reviewed-by: Tapani Pälli On 08/23/2016 06:43 PM, Alejandro Piñeiro wrote: There are some queries using methods defined at ARB_shader_subroutine that are equivalent to some queries defined at ARB_program_interface_query, specifically those related with the number of active subroutine uniforms.