Re: [Piglit] faster piglit start-up

2017-04-12 Thread Brian Paul
On 04/12/2017 02:32 PM, Eric Anholt wrote: Brian Paul writes: When we run piglit the all.py script traverses the entire tests/ and generated/tests/ directories looking for *.shader_test, *.vert, *.frag, etc. shaders to run. In the generated_tests/ directory, there's about 60,000 entries to sc

[Piglit] [PATCH] arb_shading_language_420pack: test binding different sampler types to the same tex unit

2017-04-12 Thread Timothy Arceri
https://bugs.freedesktop.org/show_bug.cgi?id=97524 --- tests/all.py | 1 + .../execution/CMakeLists.gl.txt| 1 + .../execution/active-sampler-conflict.c| 197 + 3 files changed, 199 insertions(+) create

[Piglit] [PATCH] arb_bindless_texture: Fix memory leaks.

2017-04-12 Thread Vinson Lee
CID: 1405026 Fixes: 66676a2fcd48 ("add API-related tests for ARB_bindless_texture") Signed-off-by: Vinson Lee --- tests/spec/arb_bindless_texture/legal.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_bindless_texture/legal.c b/tests/spec/arb_bindless_te

Re: [Piglit] faster piglit start-up

2017-04-12 Thread Chad Versace
On Wed 12 Apr 2017, Eric Anholt wrote: > For a solution to the startup time, I wish we would just build our whole > test list using filesystem walks or whatever at piglit build time, > instead of executing python to build the test list per piglit run. A nice benefit of building the test list just

Re: [Piglit] faster piglit start-up

2017-04-12 Thread Eric Anholt
Brian Paul writes: > When we run piglit the all.py script traverses the entire tests/ and > generated/tests/ directories looking for *.shader_test, *.vert, *.frag, > etc. shaders to run. In the generated_tests/ directory, there's about > 60,000 entries to scan (ls -R generated_tests|wc) > > T

[Piglit] faster piglit start-up

2017-04-12 Thread Brian Paul
When we run piglit the all.py script traverses the entire tests/ and generated/tests/ directories looking for *.shader_test, *.vert, *.frag, etc. shaders to run. In the generated_tests/ directory, there's about 60,000 entries to scan (ls -R generated_tests|wc) This takes some time, especial

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

2017-04-12 Thread Brian Paul
On 04/12/2017 11:55 AM, Dylan Baker wrote: It doesn't makes sense to run if a user has removed all tests from a selected profile, and currently if all tests are removed, then an assertion will be hit in the backend that isn't extremely clear about what went wrong. This should be much easier to un

[Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

2017-04-12 Thread Dylan Baker
It doesn't makes sense to run if a user has removed all tests from a selected profile, and currently if all tests are removed, then an assertion will be hit in the backend that isn't extremely clear about what went wrong. This should be much easier to understand. Signed-off-by: Dylan Baker --- f

[Piglit] [PATCH 1/3] framework: Add a name to test profiles

2017-04-12 Thread Dylan Baker
Attaching a name has infinite uses, in this case it's groundwork for the next patch to give better error messages. Signed-off-by: Dylan Baker --- framework/profile.py | 6 -- framework/test/deqp.py | 4 ++-- tests/all.py | 2 +- tests/cl.py| 2 +- tests/cpu.py

[Piglit] [PATCH 2/3] framework/exceptions: Add an exception class for user errors

2017-04-12 Thread Dylan Baker
It's nice to separate "something internally went wrong" and "you mis-configured or passed bad flags". Signed-off-by: Dylan Baker --- framework/exceptions.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/framework/exceptions.py b/framework/exceptions.py index ffee7f315..6ca3ed7

Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

2017-04-12 Thread Lionel Landwerlin
Oops sorry, I thought I did too... On 11/04/17 17:28, Manolova, Plamena wrote: Hi Ilia, This series got Reviewed-by: Lionel Landwerlin, but unfortunately I don't have write access to the repo to merge them. Lionel would you mind doing that for me? Thank you, Pam On Tue, Apr 11, 2017 at 5:24

[Piglit] assertion when test pattern not found

2017-04-12 Thread Brian Paul
Hi Dylan, I found that if I use the -t option for piglit-run.py but there's no match for the test name regex, we die with an assertion: $ ./piglit-run.py -t GL_ARB_texture_storage tests/quick.py results/foobar /home/brianp/piglit/framework/test/base.py:78: UserWarning: Timeouts are not avail

[Piglit] [PATCH] fbo-getframebufferattachmentparameter-01: fix for a test failure

2017-04-12 Thread Sandra Koroniewska
This fixes the test fbo-getframebufferattachmentparameter-01 on Intel OpenGL driver. The test is expecting GL_INVALID_OPERATION in some cases, but this behaviour is problematic and is not mentioned in the specification. --- tests/fbo/fbo-getframebufferattachmentparameter-01.c | 4 ++-- 1 file ch