[Piglit] [PATCH] util: fix Windows stdout/stderr buffering

2017-06-07 Thread Brian Paul
Windows doesn't immediately flush stdout/stderr after printf(). Use setbuf() to disable buffering on Windows. Refactor the init code a bit to avoid calling setbuf() from some arbitrary place otherwise. --- tests/util/piglit-framework-gl.h | 2 +- tests/util/piglit-util.c | 24

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Brian Paul
On 06/07/2017 12:03 PM, Eric Anholt wrote: Brian Paul writes: Otherwise, on Windows, we don't see the printf() output until the program exits. That's fine with the -auto option, but a problem w/out -auto. That's pretty broken. Actually, I think it's allowed behavior.

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, June 7, 2017 8:51:52 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] util: call fflush() after printf()

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Neha Bhende
Looks good. Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Wednesday, June 7, 2017 8:51:52 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] util: call

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Eric Anholt
Brian Paul writes: > Otherwise, on Windows, we don't see the printf() output until the program > exits. That's fine with the -auto option, but a problem w/out -auto. That's pretty broken. Could we just wrap printf/fprintf on windows to call down and then fflush(), instead

Re: [Piglit] [PATCH v5] CMake: define GBM_BO_MAP only when symbol is found

2017-06-07 Thread Dylan Baker
Pushed. Quoting Daniel Díaz Rodríguez (2017-06-07 07:14:22) > Ping. > > -- > ddiaz > > > On 30 May 2017 at 12:52, Dylan Baker wrote: > > Quoting Daniel Díaz (2017-05-16 17:06:40) > >> gbm_bo_map() and _unmap() have been added recently to Mesa, > >> and this update

Re: [Piglit] [PATCH] arb_bindless_texture: add new compiler tests for struct with image arrays

2017-06-07 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 05.06.2017 16:34, Samuel Pitoiset wrote: ping? On 05/25/2017 08:02 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../nested-struct-arrays-mismatch-format.frag | 27

[Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Brian Paul
Otherwise, on Windows, we don't see the printf() output until the program exits. That's fine with the -auto option, but a problem w/out -auto. --- tests/util/piglit-util-gl.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/util/piglit-util-gl.c