Re: [Piglit] [PATCH] util: Avoid asking GL to transpose the ortho_uniform matrix.

2017-06-26 Thread Brian Paul
On 06/26/2017 05:51 PM, Eric Anholt wrote: From the GLES2 spec: If the transpose parameter to any of the UniformMatrix* commands is not FALSE, an INVALID_VALUE error is generated, and no uniform values are changed. Fixes spurious failures in draw-vertices-half-float_gles2. ---

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? With that fixed, patch is: Reviewed-by: Samuel Pitoiset Thanks! On 06/26/2017 08:00 AM, Timothy Arceri wrote: ---

[Piglit] [PATCH] util: Avoid asking GL to transpose the ortho_uniform matrix.

2017-06-26 Thread Eric Anholt
From the GLES2 spec: If the transpose parameter to any of the UniformMatrix* commands is not FALSE, an INVALID_VALUE error is generated, and no uniform values are changed. Fixes spurious failures in draw-vertices-half-float_gles2. --- tests/util/piglit-util-gl.c | 10 +- 1

Re: [Piglit] [PATCH v6] pbo: Change the value expected from GetPixelMap.

2017-06-26 Thread Ian Romanick
On 06/22/2017 05:17 AM, Sandra Koroniewska wrote: > This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. I'm assuming this fixes the test because GL_MAX_PIXEL_MAP_TABLE is not 256. What is that value? I'll add that information to the commit message when I push the patch for you.

Re: [Piglit] [PATCH 1/1] cmake: bump gbm dependency to 17.1

2017-06-26 Thread Marek Olšák
Reviewed-by: Marek Olšák On Jun 22, 2017 3:52 PM, "Jan Vesely" wrote: > c6e1dc5247 switched to use gbm_bo_get_offset and > gbm_bo_get_stride_for_plane. > These symbols were added in mesa 17.1. Since there is no alternative to > using them, bump the

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Samuel Pitoiset
Looks like you forgot to update fbo-storage-formats.c. With that fixed, patch is: Reviewed-by: Samuel Pitoiset Thanks! On 06/26/2017 08:00 AM, Timothy Arceri wrote: --- tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c

[Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
--- tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c | 1 + tests/fbo/fbo-alpha.c | 1 + tests/fbo/fbo-alphatest-formats.c | 1 + tests/fbo/fbo-alphatest-nocolor-ff.c | 1 +