[Piglit] [PATCH] arb_shader_storage_buffer_object: don't do out-of-bounds writes

2017-08-24 Thread Samuel Iglesias Gonsálvez
From GLGL 4.5 spec, 5.11 "Out-of-Bounds Accesses": "In the subsections described above for array, vector, matrix and structure accesses, any out-of-bounds access produced undefined behavior. However, if robust buffer access is enabled via the OpenGL API, such accesses will be bound within the m

Re: [Piglit] [PATCH] draw-pixels: fix KHR_no_error logic

2017-08-24 Thread Timothy Arceri
On 23/08/17 17:23, Samuel Pitoiset wrote: On 08/23/2017 06:11 AM, Timothy Arceri wrote: --- This was my fault. The flaw was in my suggestion from the code review. You probably need to use PIGLIT_HAS_ERRORS as well. I don't think so. This skips testing draws with invalid types, the t

[Piglit] [PATCH] image_load_store: add a new test for a bug seen on AMD VEGA.

2017-08-24 Thread Dave Airlie
From: Dave Airlie This is ported from a vulkan cts test showing the same brokenness. --- .../execution/image_checkerboard.shader_test | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/execution/image_checkerboard.shade

Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

2017-08-24 Thread Jan Vesely
On Wed, 2017-08-23 at 14:54 -0700, Dylan Baker wrote: > Quoting Jan Vesely (2017-08-23 12:38:53) > > Hi Dylan, > > > > do you mind taking a look at the python parts? > > > > thanks, > > Jan > > Sure, I have a few comments, but mostly this looks okay, my comments are > mostly > style nits anyway

Re: [Piglit] [PATCH 1/1] cl: Add failing case to exp test

2017-08-24 Thread Jan Vesely
On Thu, 2017-08-24 at 12:54 -0400, Jan Vesely wrote: > From: Tom Stellard Hi Tom, this patch was never pushed. Do you remember what hw failed in this case? Do you mind if I push it? thanks, Jan > > --- > generated_tests/gen_cl_math_builtins.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

[Piglit] [PATCH 1/1] cl: Add failing case to exp test

2017-08-24 Thread Jan Vesely
From: Tom Stellard --- generated_tests/gen_cl_math_builtins.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_cl_math_builtins.py b/generated_tests/gen_cl_math_builtins.py index 29b4e1a3f..d1e0e3c24 100644 --- a/generated_tests/gen_cl_math_builtins.p