Re: [Piglit] [PATCH] tox: use pytest >= 3.0.3

2017-10-20 Thread Dylan Baker
It's unfortunate that tox doesn't support multiple conditionals, but at this point 3.0.3 is probably old enough that it's okay to rely on it. Reviewed-by: Dylan Baker Quoting Juan A. Suarez Romero (2017-10-19 02:08:59) > This is an improvement over 286dbf3e3fb5, which banned 3.0.2 due an > issue

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-20 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > Quoting Martin Peres (2017-10-20 00:38:18) >> On 19/10/17 19:50, Dylan Baker wrote: >> > Quoting Martin Peres (2017-10-19 07:17:25) >> >> On 30/09/17 23:42, Dylan Baker wrote: >> >>> Actually CC'ing him this time >> >>> >> >>> Quoting Dylan

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-20 Thread Dylan Baker
Quoting Martin Peres (2017-10-20 00:38:18) > On 19/10/17 19:50, Dylan Baker wrote: > > Quoting Martin Peres (2017-10-19 07:17:25) > >> On 30/09/17 23:42, Dylan Baker wrote: > >>> Actually CC'ing him this time > >>> > >>> Quoting Dylan Baker (2017-09-29 20:29:34) > Quoting Arkadiusz Hiler (

Re: [Piglit] [PATCH v2] khr_texture_compression_astc: change the subtest array declaration to prevent the crash coming from Visual Studio's optimisation

2017-10-20 Thread sandra koroniewska
Hi, can someone please review or push this code? Regards, Sandra On Thu, Jul 20, 2017 at 12:14 PM, sandra koroniewska < sandra.koroniew...@gmail.com> wrote: > Hi, is this code alright now, and if so, can someone push it? > The purpose of these changes was to get rid of the compound literal which

Re: [Piglit] [PATCH] minmax: change the glGet functions to accept 64-bit variables

2017-10-20 Thread sandra koroniewska
Is this fix alright now? If so, can anyone push please? Regards, Sandra On Wed, Sep 20, 2017 at 4:22 PM, Sandra Koroniewska < sandra.koroniew...@gmail.com> wrote: > This fixes > spec/gl-3.2/minmax.c and spec/gl-3.3/minmax.c on Windows Intel driver. > --- > tests/spec/gl-3.2/minmax.c | 2 +- > t

Re: [Piglit] [PATCH] glx-tfp: Use a nice orange color instead of red

2017-10-20 Thread Kenneth Graunke
On Thursday, October 19, 2017 8:08:24 PM PDT Jason Ekstrand wrote: > The orange is not a 0/1 color. If the driver messes up and gives the > client sRGB decode on the texture, the test will now fail. > --- > tests/glx/glx-tfp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-20 Thread Martin Peres
On 19/10/17 19:50, Dylan Baker wrote: Quoting Martin Peres (2017-10-19 07:17:25) On 30/09/17 23:42, Dylan Baker wrote: Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) Quoting Arkadiusz Hiler (2017-09-26 03:27:50) Because in Python we have `bool([]}) == False`, pro