Re: [Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

2018-01-24 Thread Jason Ekstrand
On Wed, Jan 24, 2018 at 6:53 AM, Tapani Pälli wrote: > This fixes test for me after Mesa commit 1f79d986af which will > make device expose entrypoints only for enabled extensions. > > Signed-off-by: Tapani Pälli > --- >

Re: [Piglit] [PATCH] util: s/3/num_components/ in probe_rect_ubyte()

2018-01-24 Thread Fabian Bieler
Oopps. Nice catch, thanks. Reviewed-by: Fabian Bieler On 2018-01-24 16:21, Brian Paul wrote: > --- > tests/util/piglit-util-gl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c > index

Re: [Piglit] [PATCH] arb_arrays_of_arrays: add ubo test with explicit binding

2018-01-24 Thread Fabian Bieler
On 2018-01-24 15:20, Alejandro Piñeiro wrote: > Although seems somewhat too specific, with mesa HEAD at: > 766589d89a211e67f313e8cb38f2d05b09975f96 > > this test crashes, so it would be good to include a test for this. > --- > .../ubo/fs-const-explicit-binding.shader_test | 42 >

Re: [Piglit] [PATCH 01/15] tests/util: Add config value to enumerate subtests

2018-01-24 Thread Dylan Baker
No worries. I'd rather get this right the first time before we convert 100+ tests than afterwards :) I also appreciate that you've converted some of the tests to use piglit_run_selected_subtests. I've lamented with others that it's unfortunate that we've never really used that feature, since it

[Piglit] [PATCH 2/3] gl-1.1-color-material-array: test GL_COLOR_MATERIAL with vertex color array

2018-01-24 Thread Brian Paul
Both with and without display lists. --- tests/all.py | 1 + tests/spec/gl-1.1/CMakeLists.gl.txt | 1 + tests/spec/gl-1.1/color-material-array.c | 118 +++ 3 files changed, 120 insertions(+) create mode 100644

[Piglit] [PATCH 1/3] gl-1.1-draw-arrays-start: exercise glDrawArrays with non-zero 'start'

2018-01-24 Thread Brian Paul
Both with and without display lists. --- tests/all.py | 1 + tests/spec/gl-1.1/CMakeLists.gl.txt | 1 + tests/spec/gl-1.1/draw-arrays-start.c | 121 ++ 3 files changed, 123 insertions(+) create mode 100644

[Piglit] [PATCH 3/3] gl-2.0-shader-materials: test vertex shader with material attributes

2018-01-24 Thread Brian Paul
Both with and without display lists. --- tests/all.py | 1 + tests/spec/gl-2.0/CMakeLists.gl.txt | 1 + tests/spec/gl-2.0/shader-materials.c | 141 +++ 3 files changed, 143 insertions(+) create mode 100644

[Piglit] [PATCH] util: s/3/num_components/ in probe_rect_ubyte()

2018-01-24 Thread Brian Paul
--- tests/util/piglit-util-gl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index e9c2038..df39c1c 100644 --- a/tests/util/piglit-util-gl.c +++ b/tests/util/piglit-util-gl.c @@ -1249,7 +1249,7 @@

[Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

2018-01-24 Thread Tapani Pälli
This fixes test for me after Mesa commit 1f79d986af which will make device expose entrypoints only for enabled extensions. Signed-off-by: Tapani Pälli --- src/tests/func/sync/semaphore-fd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Piglit] [PATCH] arb_arrays_of_arrays: add ubo test with explicit binding

2018-01-24 Thread Alejandro Piñeiro
Although seems somewhat too specific, with mesa HEAD at: 766589d89a211e67f313e8cb38f2d05b09975f96 this test crashes, so it would be good to include a test for this. --- .../ubo/fs-const-explicit-binding.shader_test | 42 ++ 1 file changed, 42 insertions(+) create mode