Re: [Piglit] [PATCH v3] travis: add docker based cmake build job

2018-01-29 Thread Eric Anholt
Andres Gomez writes: > Until now we were only running the python unit tests. > > It seems desirable to also check that the CMake based build compiles > successfully. We do that now using docker. > > The docker build can be tweaked with some environment variables and, > also,

Re: [Piglit] [PATCH] cl: Add test for MUBUF access with a negative vaddr

2018-01-29 Thread Jan Vesely
On Fri, 2018-01-19 at 14:43 -0500, Matt Arsenault wrote: > > On Jan 18, 2018, at 15:02, Jan Vesely wrote: > > > > Why is this necessary? can't you just pass the offset argument as a > > kernel input? > > > > Jan > > It needs to specifically be in a VGPR OK LGTM. I'll

Re: [Piglit] [PATCH 3/3] arb_internalformat_query2: some formats are not compatible with TBOs

2018-01-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro wrote: > On those cases, the resource is not supported, so we should expect the > unsupported outcome. > --- > .../spec/arb_internalformat_query2/image-texture.c | 55

Re: [Piglit] [v2 PATCH 1/3] arb_internalformat_query2: minmax GL_ALPHA8 deprecated on 3.1+

2018-01-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro wrote: > When ARB_compatibility is missing or the context is Core. > > v2: check for ARB_compatibility or core (Marek) > --- >

Re: [Piglit] [v2 PATCH 2/3] arb_internalformat_query2: more than one way to support GEOMETRY_TEXTURE

2018-01-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro wrote: > v2: GL_EXT_geometry_shader should not be checked, as is only for GLES > (Ilia Mirkin) > --- > tests/spec/arb_internalformat_query2/common.c | 3 ++- > 1