Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

I think the bad enum is some copy and paste from an above test case. I feel it should be changed as well, right now the test is relying on the level / size being validated before the format. - Anthony P.S. Sorry for the spam on these changes, I had a problem with my filters and thought the

[Piglit] [PATCH] util: reorganize read_pixels_float()

Use a simple if/else to organize the ES vs desktop GL code paths. --- tests/util/piglit-util-gl.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 3a41a5e..f851f82 100644 ---

Re: [Piglit] [PATCH v3] fix read_pixels_float() on GLES2 when format is not GL_RGBA

Yes I do; I don't have commit rights. On Wed, Mar 28, 2018 at 6:12 PM, Brian Paul wrote: > On 03/28/2018 10:44 AM, Rhys Perry wrote: >> >> GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels >> --- >> tests/util/piglit-util-gl.c | 18 +++--- >>

[Piglit] [PATCH v3] tests: add nvidia conservative rasterization tests

Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate and GL_NV_conservative_raster_pre_snap_triangles. Changes in v2: - cleanup the tests - fix some test failures - remove the gles version of the dilation test as the extension is not exposed in gl.xml Changes in v3: - fix

Re: [Piglit] [PATCH v3] fix read_pixels_float() on GLES2 when format is not GL_RGBA

On 03/28/2018 10:44 AM, Rhys Perry wrote: GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels --- tests/util/piglit-util-gl.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c

[Piglit] [PATCH v3] fix read_pixels_float() on GLES2 when format is not GL_RGBA

GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels --- tests/util/piglit-util-gl.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index df39c1c87..3a41a5eb0 100644 ---

Re: [Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to complete the cube map

I'm less confident than for the others but Reviewed-by: Arthur Huillet On 28.03.2018 17:15, Anthony Pesch wrote: From: Anthony Pesch Update cube map tests to complete the cube map before performing the final query. This final query is expected to

Re: [Piglit] [PATCH 2/3] arb_get_texture_sub_image: fix depth parameter when performing zero-sized texture queries

Reviewed-by: Arthur Huillet Thanks -- Arthur On 28.03.2018 17:15, Anthony Pesch wrote: From: Anthony Pesch Change zero-sized texture queries to pass a valid depth parameter, otherwise they should error as per the OpenGL 4.6 Core spec: "An

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

I'm confused why the test is passing a bad enum when its purpose seems to be to test a non-existent level. In any case, your change looks correct to me. Reviewed-by: Arthur Huillet On 28.03.2018 17:15, Anthony Pesch wrote: From: Anthony Pesch Change

[Piglit] [PATCH 2/3] arb_get_texture_sub_image: fix depth parameter when performing zero-sized texture queries

From: Anthony Pesch Change zero-sized texture queries to pass a valid depth parameter, otherwise they should error as per the OpenGL 4.6 Core spec: "An INVALID_VALUE error is generated if the effective target is TEXTURE_1D, TEXTURE_1D_ARRAY, TEXTURE_2D or TEXTURE_RECTANGLE,

[Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

From: Anthony Pesch Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a level which hasn't been explicitly defined. This is a valid operation, the error set should be due to the requested width and height being greater than the default width and

[Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to complete the cube map

From: Anthony Pesch Update cube map tests to complete the cube map before performing the final query. This final query is expected to succeed, however, querying a cube map which is not cube complete should set INVALID_OPERATION as per the OpenGL 4.6 Core spec: "An

Re: [Piglit] [PATCH v2] fix read_pixels_float() on GLES2 when format is not GL_RGBA

On 03/28/2018 05:37 AM, Rhys Perry wrote: GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels --- tests/util/piglit-util-gl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index

[Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to complete the cube map

From: Anthony Pesch Update cube map tests to complete the cube map before performing the final query. This final query is expected to succeed, however, querying a cube map which is not cube complete should set INVALID_OPERATION as per the OpenGL 4.6 Core spec: "An

[Piglit] [PATCH v2] tests: add nvidia conservative rasterization tests

Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate and GL_NV_conservative_raster_pre_snap_triangles. Changes in v2: - cleanup the tests - fix some test failures - remove the gles version of the dilation test as the extension is not exposed in gl.xml Signed-off-by: Rhys

Re: [Piglit] [PATCH] Add support for Crucible

On Mon, 2018-03-26 at 11:53 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-03-23 04:37:16) > > Allow to run Crucible testsuite from piglit > > > > Signed-off-by: Juan A. Suarez Romero > > --- > > tests/crucible.py | 84 > >

[Piglit] [PATCH v2] fix read_pixels_float() on GLES2 when format is not GL_RGBA

GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels --- tests/util/piglit-util-gl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index df39c1c87..0504be063 100644 ---