[Piglit] [PATCH] ext_texture_norm16-render: refactor subtest execution

Patch moves subtest execution in a separate function that returns total result for each format, this fixes issues in test with current pass/fail reporting. Also remove reporting from verify_contents_float, this caused duplicate subtest result reporting. Signed-off-by: Tapani Pälli --- tests/spe

Re: [Piglit] [PATCH v2] glsl-1.30: add tests for using immediates in common operations

On 05/03/2018 02:59 PM, Ilia Mirkin wrote: > On Thu, May 3, 2018 at 5:58 PM, Ian Romanick wrote: >> On 04/27/2018 04:56 PM, Ilia Mirkin wrote: >>> On Fri, Apr 27, 2018 at 9:07 AM, Ian Romanick wrote: On 04/27/2018 12:01 AM, Ilia Mirkin wrote: > NVIDIA hardware has "short" immediates, and

Re: [Piglit] [PATCH v2] glsl-1.30: add tests for using immediates in common operations

On Thu, May 3, 2018 at 5:58 PM, Ian Romanick wrote: > On 04/27/2018 04:56 PM, Ilia Mirkin wrote: >> On Fri, Apr 27, 2018 at 9:07 AM, Ian Romanick wrote: >>> On 04/27/2018 12:01 AM, Ilia Mirkin wrote: NVIDIA hardware has "short" immediates, and some instructions have both long and short

Re: [Piglit] [PATCH v2] glsl-1.30: add tests for using immediates in common operations

On 04/27/2018 04:56 PM, Ilia Mirkin wrote: > On Fri, Apr 27, 2018 at 9:07 AM, Ian Romanick wrote: >> On 04/27/2018 12:01 AM, Ilia Mirkin wrote: >>> NVIDIA hardware has "short" immediates, and some instructions have both >>> long and short immediate variants. Nouveau was picking the wrong one >>> u

[Piglit] [PATCH] nv_fog_distance: Simple rendering test

From: Ian Romanick A heavily modified version of this test passes on a Geforce3 (NV20) running NVIDIA's 71.86.15 drivers. These are the last drivers that support NV10 through NV2x, and they are shipped in 2011. v2: Use piglit_draw_rect_z instead of the VBO complexity. Cuts about 80 lines of co

Re: [Piglit] [PATCH 7/7] nv_fog_distance: Test interactions with GL_FOG_COORDINATE

On 05/02/2018 11:06 AM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Ian Romanick >> >> The issuses section of GL_NV_fog_distance says: >> >> How does this extension interact with the EXT_fog_coord extension? >> >> If FOG_COORDINATE_SOURCE_EXT is set to FOG_COORDINATE_EXT, t

[Piglit] [PATCH] nv_fog_distance: Simple touch test for the enums

From: Ian Romanick v2: Explicitly use GL_NO_ERROR instead of expected_error in the 'piglit_is_extension_supported("GL_NV_fog_distance") && !piglit_is_extension_supported("GL_SGIS_fog_function")' block. Based on conversation with Eric. Signed-off-by: Ian Romanick --- tests/all.py

[Piglit] [PATCH] gl-1.0-blend: Enable EXT_blend_subtract tests on implementations that lack EXT_blend_minmax

From: Ian Romanick And vice versa. v2: Elimintate the static arrays used to populate operators[]. This simplifies the code a lot. Suggested by Eric. Signed-off-by: Ian Romanick --- tests/spec/gl-1.0/blend.c | 36 1 file changed, 16 insertions(+), 20 dele

Re: [Piglit] [PATCH 6/7] nv_fog_distance: Simple rendering test

On 05/02/2018 11:02 AM, Eric Anholt wrote: > Ian Romanick writes: >> diff --git a/tests/spec/nv_fog_distance/simple-draw.c >> b/tests/spec/nv_fog_distance/simple-draw.c >> new file mode 100644 >> index 0..e7be6bf5e >> --- /dev/null >> +++ b/tests/spec/nv_fog_distance/simple-draw.c >> @@ -

[Piglit] [PATCH] name no_error profile depen on shader generation

Since it includes shaders. --- tests/CMakeLists.no_api.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/CMakeLists.no_api.txt b/tests/CMakeLists.no_api.txt index e3ff33b4d..a3542d2f7 100644 --- a/tests/CMakeLists.no_api.txt +++ b/tests/CMakeLists.no_api.txt @@ -59,7 +5

Re: [Piglit] [PATCH 5/7] nv_fog_distance: Simple touch test for the enums

On 05/02/2018 10:54 AM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> tests/all.py | 5 + >> tests/spec/CMakeLists.txt| 1 + >> tests/spec/nv_fog_distance/CMakeLists.gl.txt |

Re: [Piglit] [PATCH 2/7] gl-1.0-blend: Enable EXT_blend_subtract tests on implementations that lack EXT_blend_minmax

On 05/02/2018 10:47 AM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Ian Romanick >> >> And vice versa. >> >> Signed-off-by: Ian Romanick >> --- >> tests/spec/gl-1.0/blend.c | 40 ++-- >> 1 file changed, 26 insertions(+), 14 deletions(-) >> >> diff -

Re: [Piglit] [PATCH 1/7] gl-1.0-blend: Fix problems with blend extension detection

On 05/02/2018 10:47 AM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Ian Romanick >> >> There were two bugs here. First, GL_EXT_blend_color and >> GL_EXT_blend_func_separate were only tested if the version is 1.4. This >> is unnecessary because those extensions are part of OpenGL 1.4.

[Piglit] [Bug 106370] /bin/sh: BYPRODUCTS: command not found

https://bugs.freedesktop.org/show_bug.cgi?id=106370 --- Comment #2 from Vinson Lee --- (In reply to Dylan Baker from comment #1) > > What version of cmake are you using? > 2.8.12.2 -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Piglit] [PATCH] find_static_tests.py: fix python2 compatibility

On 05/02/2018 11:52 AM, Dylan Baker wrote: Because python2 uses bytes, but python3 uses unicode. CC: Michel Dänzer Fixes: d42d909cd754d0e2c41eec60f3a1015f2d882b95 ("tests: Add script to find all hand written test files") --- tests/find_static_tests.py | 11 ++- 1 file changed

Re: [Piglit] [PATCH] find_static_tests.py: fix python2 compatibility

Brian, Ilia, This was the patch I had written. Dylan Quoting Dylan Baker (2018-05-02 10:52:47) > Because python2 uses bytes, but python3 uses unicode. > > CC: Michel Dänzer > Fixes: d42d909cd754d0e2c41eec60f3a1015f2d882b95 >("tests: Add script to find all hand written test files") > --

Re: [Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

Quoting Nicolai Hähnle (2018-05-03 01:43:52) > On 02.05.2018 22:57, Marek Ol\u0161ák wrote: > > On Wed, May 2, 2018 at 4:51 PM, Dylan Baker > > wrote: > > > > Quoting Marek Ol\u0161ák (2018-05-02 13:32:43) > > > From: Nicolai Hähnle >

Re: [Piglit] [PATCH] tests: fix unicode issue on MinGW in find_static_tests.py

Quoting Brian Paul (2018-05-03 07:53:04) > On 05/03/2018 06:23 AM, Ilia Mirkin wrote: > > On Wed, May 2, 2018 at 10:04 PM, Brian Paul wrote: > >> Explicity convert strings to unicode before writing. > >> This fixes an error when building with MinGW: > >> Traceback (most recent call last): > >>

[Piglit] [Bug 106277] [CI] spec@glsl-1.40-compat@execution@built-in-constants failing

https://bugs.freedesktop.org/show_bug.cgi?id=106277 Martin Peres changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #5 from Martin Peres

[Piglit] [Bug 106370] /bin/sh: BYPRODUCTS: command not found

https://bugs.freedesktop.org/show_bug.cgi?id=106370 --- Comment #1 from Dylan Baker --- What version of cmake are you using? I'm on mobile, please excuse autocorrect fail. On Wed, May 2, 2018, 23:01 wrote: > Bug ID 106370 > Summary /bin/sh

[Piglit] [Bug 106369] TypeError: must be unicode, not str

https://bugs.freedesktop.org/show_bug.cgi?id=106369 --- Comment #1 from Dylan Baker --- There's a patch for this on the list from me. I'm on mobile, please excuse autocorrect fail. On Wed, May 2, 2018, 22:31 wrote: > Bug ID 106369 > Summar

Re: [Piglit] [PATCH] tests: fix unicode issue on MinGW in find_static_tests.py

On 05/03/2018 06:23 AM, Ilia Mirkin wrote: On Wed, May 2, 2018 at 10:04 PM, Brian Paul wrote: Explicity convert strings to unicode before writing. This fixes an error when building with MinGW: Traceback (most recent call last): File "/var/workspace/tests/find_static_tests.py", line 74, in

Re: [Piglit] [PATCH 1/4] crucible: fix getting values from piglit.conf

I think patches 2 and 3 could be squashed in one. In any case, for the series: Reviewed-by: Juan A. Suarez J.A. On Wed, 2018-05-02 at 13:57 -0700, Dylan Baker wrote: > --- > tests/crucible.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/crucible.p

Re: [Piglit] [PATCH] tests: fix unicode issue on MinGW in find_static_tests.py

On Wed, May 2, 2018 at 10:04 PM, Brian Paul wrote: > Explicity convert strings to unicode before writing. > This fixes an error when building with MinGW: > Traceback (most recent call last): > File "/var/workspace/tests/find_static_tests.py", line 74, in > main() > File "/var/workspace/te