[Piglit] [PATCH] general: better test display lists in attribute test

2018-06-23 Thread Timothy Arceri
We weren't really testing that the displays list worked since the calls could have just been executed immediately. --- tests/general/attribs.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 05a0d4a1e..ddb0b060a 100644 ---

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-23 Thread Alejandro Piñeiro
On 22/06/18 19:14, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-20 05:40:38) >> So when executing shader tests, they will be executed with -glsl. This >> is the force GLSL mode, that is only relevant if the shader test >> includes SPIR-V shaders. > I'm not sure I understand what you're

[Piglit] [PATCH v4] unsized_array_member: It should expect link success instead of link error

2018-06-23 Thread Eleni Maria Stea
Modified the unsized_array_member.shader_test to expect successful linking instead of linker error. Section 4.2 (Scoping) of the OpenGL Shading Language Specification says: "An array implicitly sized in one shader can be explicitly sized by another shader in the same stage. If no shader in a

[Piglit] [PATCH] arb_draw_indirect: test when 0 bound to DRAW_INDIRECT_BUFFER in compat

2018-06-23 Thread Timothy Arceri
From the ARB_draw_indirect spec: "Initially zero is bound to DRAW_INDIRECT_BUFFER. In the compatibility profile, this indicates that DrawArraysIndirect and DrawElementsIndirect are to source their arguments directly from the pointer passed as their parameters." ---