[Piglit] [PATCH] arb_vertex_attrib_64bit: test display list interaction

2018-06-27 Thread Timothy Arceri
--- tests/opengl.py | 1 + .../execution/CMakeLists.gl.txt | 1 + .../execution/double_attribs_dlist.c | 297 ++ 3 files changed, 299 insertions(+) create mode 100644 tests/spec/arb_vertex_attrib_64bit/execution/double_attr

[Piglit] [PATCH v3] arb_compute_shader: test dispatch functions with display lists

2018-06-27 Thread Timothy Arceri
This change also splits apart some of the compute test common functions to make them easier to use with display lists. --- V3: I submitted a spec bug and it was decided the indirect dispatch should generate an error when called during display list compilation. tests/opengl.py

Re: [Piglit] [PATCH 4/9] tests/opengl: Add gl-3.3-vertex-attrib-p-types

2018-06-27 Thread Ian Romanick
Patches 4 and 5 are Reviewed-by: Ian Romanick On 06/27/2018 10:32 AM, Dylan Baker wrote: > Fixes: bcaa0cd75fd7b1d35817792b4802cce5eb47754d >("Test that VertexAttribP*() must use one of the appropriate types.") > CC: Ian Romanick > --- > > tests/opengl.py | 1 + > 1 file changed, 1 ins

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 28/06/18 08:58, Ian Romanick wrote: On 06/27/2018 03:44 PM, Timothy Arceri wrote: On 28/06/18 08:28, Timothy Arceri wrote: On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixe

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Ian Romanick
On 06/27/2018 03:44 PM, Timothy Arceri wrote: > > > On 28/06/18 08:28, Timothy Arceri wrote: >> On 27/06/18 21:58, Tapani Pälli wrote: >>> On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixed-arithme

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 28/06/18 08:28, Timothy Arceri wrote: On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++   1 file changed, 37 insertions

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++   1 file changed, 37 insertions(+)   create mode 100644 tests/spec/glsl-1.

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Ian Romanick
On 06/27/2018 04:58 AM, Tapani Pälli wrote: > > > On 06/27/2018 02:43 PM, Timothy Arceri wrote: >> --- >> >>   V2: Fix some spelling typos and the commit description >> >>   ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ >>   1 file changed, 37 insertions(+) >>   create mo

[Piglit] [PATCH 1/2] JSON: move info utilities out of root

2018-06-27 Thread Dylan Baker
And into a generic sub element in the output. This makes information like glxinfo and clinfo not a hard requirement and makes the format easier to generate from swineherd. --- framework/backends/json.py| 16 ++- framework/programs/run.py | 3 +- framework

[Piglit] [PATCH 0/2] Generalize some components of piglit json output

2018-06-27 Thread Dylan Baker
This little series aims to make some components of the piglit JSON result format more general. This is the culmination of some cleanups that I've had sitting around for a while. Dylan Baker (2): JSON: move info utilities out of root summary/html: generalize info output framework/backends/jso

[Piglit] [PATCH 2/2] summary/html: generalize info output

2018-06-27 Thread Dylan Baker
So that random keys show up somewhat nicely. --- framework/summary/html_.py | 5 + templates/testrun_info.mako | 32 2 files changed, 13 insertions(+), 24 deletions(-) diff --git a/framework/summary/html_.py b/framework/summary/html_.py index 945230bc6..f0cc

Re: [Piglit] [PATCH] tests/opengl.py: add couple missing arb_get_program_binary tests

2018-06-27 Thread Dylan Baker
I wrote the same patch today :) Reviewed-by: Dylan Baker Quoting Tapani Pälli (2018-06-26 23:49:37) > Signed-off-by: Tapani Pälli > --- > tests/opengl.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/opengl.py b/tests/opengl.py > index 2592fa404..cafda2576 100644 > --- a/t

[Piglit] [PATCH 1/9] tests/opengl: Add arb_get_program_binary-reset-uniform

2018-06-27 Thread Dylan Baker
Fixes: 51168665cfe1fda4a5d9c1a89e23b34c194622ff ("ARB_get_program_binary: Test that uniforms are reset on program reload (API)") CC: Jordan Justen --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/tests/opengl.py index 18b69a27e..d02aefc30 100644 --

[Piglit] [PATCH 9/9] tests/opengl.py: Replace tabs with spaces

2018-06-27 Thread Dylan Baker
--- tests/opengl.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index bc910ac69..69003c3d0 100644 --- a/tests/opengl.py +++ b/tests/opengl.py @@ -4845,8 +4845,8 @@ with profile.test_list.group_manager( # Group ARB_compute_va

[Piglit] [PATCH 6/9] tests/opengl: Add glx-swap-copy

2018-06-27 Thread Dylan Baker
Fixes: 2a7047a32bb3a9a4fad5bea0a8185d63af6bddf3 ("glx: Introduce a glx-swap-copy test v2") CC: Thomas Hellstrom CC: Brian Paul --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/tests/opengl.py index 00bce15af..a83d235c1 100644 --- a/tests/opengl.py

[Piglit] [PATCH 2/9] tests/opengl: Add arb_get_program_binary-restore-implict-use-program

2018-06-27 Thread Dylan Baker
Fixes: f1dc46ddf8c1f033ae24d322deff663889b2267d ("ARB_get_program_binary: Test that restoring active program takes effect") CC: Jordan Justen --- tests/opengl.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py index d02aefc30..ba11bfccc 100644 --- a

[Piglit] [PATCH 3/9] tests/opengl: Add arb_texture_view tests for gles3

2018-06-27 Thread Dylan Baker
These were converted to work with oes_texture_view, but never added to all.py (now opengl.py) Fixes: cde860ab32511812ecbf1d8b8d97f192273457a1 ("arb_texture_view: convert some more tests to run on ES 3.1") CC: Tapani Pälli --- tests/opengl.py | 13 + 1 file changed, 13 insertio

[Piglit] [PATCH 5/9] tests/opengl: Add gl-3.3-vertex-attrib-p-type-size-match

2018-06-27 Thread Dylan Baker
Fixes: ce69a7afc5eb4c6a3093d0bdd9a66f51444bd07a ("Test that if VertexAttribPointer uses a packed type, size must be 4 or BGRA.") CC: Ian Romanick --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/tests/opengl.py index 873cdac29..00bce15af 100644 ---

[Piglit] [PATCH 7/9] tests/opengl: Add intel_conservative_rasterization-invalid_gles3

2018-06-27 Thread Dylan Baker
Fixes: ed153b51b57762e43d44e8f49dbe9bf0422e1400 ("Add GL_INTEL_conservative_rasterization tests") CC: Lionel Landwerlin --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/tests/opengl.py index a83d235c1..e5addfbb7 100644 --- a/tests/opengl.py +++ b/te

[Piglit] [PATCH 8/9] tests/opengl: Add nv_image_formats-gles3

2018-06-27 Thread Dylan Baker
Fixes: 6ed37e5d2a58d36b4b04b09f8c069f2dbcff1968 ("Add nv_image_formats tests") CC: Lionel Landwerlin --- tests/opengl.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py index e5addfbb7..bc910ac69 100644 --- a/tests/opengl.py +++ b/tests/opengl.py

[Piglit] [PATCH 0/9] Add missing tests to opengl.py

2018-06-27 Thread Dylan Baker
Working in another area I'd noticed a few tests in opengl.py that didn't have binaries. That got me thinking that there are probably some binaries that don't have test entries, so I wrote a little script and found that to indeed be the case. This fixes most of the tests, but there are a few that I

[Piglit] [PATCH 4/9] tests/opengl: Add gl-3.3-vertex-attrib-p-types

2018-06-27 Thread Dylan Baker
Fixes: bcaa0cd75fd7b1d35817792b4802cce5eb47754d ("Test that VertexAttribP*() must use one of the appropriate types.") CC: Ian Romanick --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/tests/opengl.py index 6657cffdb..873cdac29 100644 --- a/tests/op

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-27 Thread Dylan Baker
Quoting Alejandro Piñeiro (2018-06-27 03:43:35) > On 26/06/18 17:35, Dylan Baker wrote: > > Quoting Alejandro Piñeiro (2018-06-26 03:44:53) > >> On 25/06/18 17:59, Dylan Baker wrote: > >>> Quoting Alejandro Piñeiro (2018-06-23 04:26:33) > On 22/06/18 19:14, Dylan Baker wrote: > > Quoting A

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Tapani Pälli
On 06/27/2018 02:43 PM, Timothy Arceri wrote: --- V2: Fix some spelling typos and the commit description ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/comparision-vec4-mixed-ar

[Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
--- V2: Fix some spelling typos and the commit description ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/comparision-vec4-mixed-arithmetic-input.shader_test diff --git a/tests/spec/g

[Piglit] [PATCH] glsl-1.10: test bug with lessThan() with input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
--- ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/comparision-vec4-mixed-arithmetic-input.shader_test diff --git a/tests/spec/glsl-1.10/execution/comparision-vec4-mixed-arithmetic-input

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-27 Thread Alejandro Piñeiro
On 26/06/18 17:35, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-26 03:44:53) >> On 25/06/18 17:59, Dylan Baker wrote: >>> Quoting Alejandro Piñeiro (2018-06-23 04:26:33) On 22/06/18 19:14, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-20 05:40:38) >> So when execut

[Piglit] [PATCH] arb_gpu_shader_fp64: Test the sign() function with abs() and negation of its argument

2018-06-27 Thread Ian Romanick
From: Ian Romanick The saturate version hits an assertion failure in the Mesa i965 driver: src/intel/compiler/brw_fs.cpp:2377: bool fs_visitor::opt_algebraic(): Assertion `!"unimplemented: saturate mixed types"' failed. Signed-off-by: Ian Romanick --- .../built-in-functions/fs-sign-neg-abs.s

Re: [Piglit] [PATCH] tests/opengl.py: add couple missing arb_get_program_binary tests

2018-06-27 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri On 27/06/18 16:49, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py index 2592fa404..cafda2576 100644 --- a/tests/opengl.py +++ b/tests/opengl.py