Re: [Piglit] [PATCH] cl: Add test for CSR VGPRs caused by SGPR spilling

2018-08-13 Thread Jan Vesely
On Mon, 2018-08-13 at 23:29 +0300, Matt Arsenault wrote: > > On May 8, 2018, at 18:45, Jan Vesely wrote: > > > > On Tue, 2018-05-08 at 13:28 +0300, Matt Arsenault wrote: > > > > On Apr 8, 2018, at 19:56, Jan Vesely wrote: > > > > > > > > On Fri, 2018-04-06 at 00:49 -0400, Matt Arsenault wrote:

Re: [Piglit] [PATCH] cl: Add bigger versions of calls with struct tests

2018-08-13 Thread Jan Vesely
On Mon, 2018-08-13 at 13:41 -0700, Matt Arsenault wrote: > These are just bigger versions of the existing struct > calls tests so that they stress using byval/sret. The > existing call with struct tests are now passed directly > in registers. > > v2: Rename struct member passes on POCL.

Re: [Piglit] [PATCH] cl: Fix types to be unsigned

2018-08-13 Thread Jan Vesely
On Mon, 2018-08-13 at 23:42 +0300, Matt Arsenault wrote: > ping Reviewed-by: Jan Vesely > > > On Oct 27, 2017, at 13:03, Matt Arsenault wrote: > > > > Doesn't really matter. so why change it? still passes on clover carrizo/iceland Jan > > --- > > tests/cl/program/execute/store-hi16.cl | 8

Re: [Piglit] [PATCH] cl: Fix types to be unsigned

2018-08-13 Thread Matt Arsenault
ping > On Oct 27, 2017, at 13:03, Matt Arsenault wrote: > > Doesn't really matter. > --- > tests/cl/program/execute/store-hi16.cl | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/cl/program/execute/store-hi16.cl > b/tests/cl/program/execute/store-hi16.cl >

[Piglit] [PATCH] cl: Add bigger versions of calls with struct tests

2018-08-13 Thread Matt Arsenault
These are just bigger versions of the existing struct calls tests so that they stress using byval/sret. The existing call with struct tests are now passed directly in registers. v2: Rename struct member --- .../cl/program/execute/calls-large-struct.cl | 156 ++

Re: [Piglit] [PATCH] cl: Add bigger versions of calls with struct tests

2018-08-13 Thread Matt Arsenault
> On Mar 23, 2018, at 23:07, Jan Vesely wrote: > > On Thu, 2018-03-15 at 11:41 -0400, Matt Arsenault wrote: >> ping >> >>> On Oct 12, 2017, at 16:19, Matt Arsenault wrote: >>> >>> These are just bigger versions of the existing struct >>> calls tests so that they stress using byval/sret. The

[Piglit] [PATCH] cl: Add test for call stack realignment

2018-08-13 Thread Matt Arsenault
v2: Use uintptr_t v3: Formatting --- tests/cl/program/execute/realign-stack.cl | 93 +++ 1 file changed, 93 insertions(+) create mode 100644 tests/cl/program/execute/realign-stack.cl diff --git a/tests/cl/program/execute/realign-stack.cl

Re: [Piglit] [PATCH] cl: Add test for CSR VGPRs caused by SGPR spilling

2018-08-13 Thread Matt Arsenault
> On May 8, 2018, at 18:45, Jan Vesely wrote: > > On Tue, 2018-05-08 at 13:28 +0300, Matt Arsenault wrote: >>> On Apr 8, 2018, at 19:56, Jan Vesely wrote: >>> >>> On Fri, 2018-04-06 at 00:49 -0400, Matt Arsenault wrote: ping >>> >>> I'll need to setup the rocm stack to test this. It

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

2018-08-13 Thread Nanley Chery
On Mon, Aug 13, 2018 at 02:59:39PM +0300, Tapani Pälli wrote: > > > On 08/13/2018 01:31 PM, Tapani Pälli wrote: > > > > > > On 08/11/2018 01:12 AM, Nanley Chery wrote: > > > On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: > > > > Test includes: > > > >     - texture uploads > > >

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

2018-08-13 Thread Tapani Pälli
On 08/13/2018 01:31 PM, Tapani Pälli wrote: On 08/11/2018 01:12 AM, Nanley Chery wrote: On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: Test includes:     - texture uploads     - mipmap generation     - framebuffer creation     - rendering to     - reading from     -

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

2018-08-13 Thread Tapani Pälli
On 08/11/2018 01:12 AM, Nanley Chery wrote: On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image I don't see any

Re: [Piglit] [PATCH] shaders: add a glslparsertest for bug 98699

2018-08-13 Thread Tapani Pälli
On 08/13/2018 06:15 AM, Timothy Arceri wrote: On 11/08/18 02:32, Dylan Baker wrote: I thought we'd stopped adding tests with "bugX" in the name and tried to give the test a descriptive name and we were trying not to add more tests to tests/shaders, but put them in tests/spec/. So maybe