Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? The file extension is also confusing. Maybe we should name these type of files .shader_source or something similar rather than .shader_test ??? On 09/08/18 21:36, Alejandro

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
Won't this cause shader runner to needlessly parse the .shader_test file? On 09/08/18 21:36, Alejandro Piñeiro wrote: From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts

Re: [Piglit] [PATCH v2] egl Add new test of EGL_EXT_platform_device

2018-08-17 Thread Mathias Fröhlich
Hi, Sorry for the late replay. I can also take a look at the mesa side but not before next week. Nevertheless, I still have one more comment inline below: On Tuesday, 14 August 2018 15:44:09 CEST Emil Velikov wrote: > From: Emil Velikov > > Since the functionality is more or less identical to