Re: [Piglit] [PATCH] ext_render_snorm-render: change verify_contents to use base_format size

On 08/29/2018 02:44 PM, Ilia Mirkin wrote: On Wed, Aug 29, 2018 at 3:33 AM, Tapani Pälli wrote: OpenGL ES 3.1 specification lists valid combinations for format, type and internalformat for transfer of pixel rectangles. This change follows the table 8.4 in spec so that we use exact same number

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

On 08/29/2018 08:57 PM, Nanley Chery wrote: On Wed, Aug 29, 2018 at 10:15:41AM +0300, Tapani Pälli wrote: On 29.08.2018 00:23, Nanley Chery wrote: On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: Test assumed that we can read back directly from R8, RG8 fbo but this is not actu

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

On Wed, Aug 29, 2018 at 10:15:41AM +0300, Tapani Pälli wrote: > > > On 29.08.2018 00:23, Nanley Chery wrote: > > On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: > > > Test assumed that we can read back directly from R8, RG8 fbo but > > > this is not actually enabled by the extension

Re: [Piglit] [PATCH] ext_render_snorm-render: change verify_contents to use base_format size

On Wed, Aug 29, 2018 at 3:33 AM, Tapani Pälli wrote: > OpenGL ES 3.1 specification lists valid combinations for format, type > and internalformat for transfer of pixel rectangles. This change follows > the table 8.4 in spec so that we use exact same number of components > for format as is expected

Re: [Piglit] [PATCH] glsl-1.30: add linker test for inter stage in/out vars usage

On 28/08/18 17:19, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review! Can you please push this patch ? Pushed. Thanks for the patch. вт, 28 авг. 2018 г. в 3:45, Timothy Arceri >: Reviewed-by: Timothy Arceri mailto:tarc...@itsqueeze.com>> On

[Piglit] [PATCH] ext_render_snorm-render: change verify_contents to use base_format size

OpenGL ES 3.1 specification lists valid combinations for format, type and internalformat for transfer of pixel rectangles. This change follows the table 8.4 in spec so that we use exact same number of components for format as is expected from corresponding internalformat. Signed-off-by: Tapani Päl

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

On 29.08.2018 00:23, Nanley Chery wrote: On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: Test assumed that we can read back directly from R8, RG8 fbo but this is not actually enabled by the extension. Patch introduces additional read from window to sanity check fbo contents. I