Re: [Piglit] [PATCH] glsl-1.10: Put an if-statement in a macro in the false path of an ifdef

2018-08-31 Thread Timothy Arceri
Thanks! I believe I have a fix I'm just running it in CI to confirm it doesn't cause any other issues. Reviewed-by: Timothy Arceri On 01/09/18 03:49, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772 Cc: Timot

Re: [Piglit] [PATCH] arb_vertex_array_object: Add test for deleting object zero

2018-08-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 31, 2018 at 3:21 AM, Ian Romanick wrote: > From: Ian Romanick > > As of commit 781a78914c7, this test fails with: > > arb_vertex_array-delete-object-0: src/mesa/main/hash.c:240: > _mesa_HashRemove_unlocked: Assertion `key' failed. > Aborted (core dum

[Piglit] [PATCH] glsl-1.10: Put an if-statement in a macro in the false path of an ifdef

2018-08-31 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772 Cc: Timothy Arceri Cc: Eero Tamminen Cc: Mark Janes --- .../if-statement-in-macro-in-false-ifdef.vert | 18 ++ 1 file changed, 18 insertions(+) create mode 1

Re: [Piglit] [PATCH] i965/glsl: don't add unused aoa elements to the program resource list

2018-08-31 Thread andrey simiklit
Hi all, Sorry wrong mailing list. Just ignore this message. Regards, Andrii. On Fri, Aug 31, 2018 at 5:08 PM wrote: > From: Andrii Simiklit > > It fixes a bit incorrectly implemented ARB_program_interface_query. > If input aoa element is unused in shader program > the 'glGetProgramResourceInde

[Piglit] [PATCH] i965/glsl: don't add unused aoa elements to the program resource list

2018-08-31 Thread asimiklit . work
From: Andrii Simiklit It fixes a bit incorrectly implemented ARB_program_interface_query. If input aoa element is unused in shader program the 'glGetProgramResourceIndex' function shouldn't return a valid resource index for it according to: ARB_program_interface_query spec: " For an active va

[Piglit] [PATCH] arb_program_interface_query: added subtests to getprogramresourceindex

2018-08-31 Thread asimiklit . work
From: Andrii Simiklit Added test cases to test arb_program_interface_query-getprogramresourceindex to check the 'glGetProgramResourceIndex' function more deeper. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92822 Signed-off-by: Andrii Simiklit --- tests/spec/arb_program_interface_que

[Piglit] [PATCH] arb_vertex_array_object: Add test for deleting object zero

2018-08-31 Thread Ian Romanick
From: Ian Romanick As of commit 781a78914c7, this test fails with: arb_vertex_array-delete-object-0: src/mesa/main/hash.c:240: _mesa_HashRemove_unlocked: Assertion `key' failed. Aborted (core dumped) Marek already has a patch on the Mesa list for this issue. Signed-off-by: Ian Romanick Cc: M