[Piglit] [PATCH] glsl-1.10: add tests for an array index on a swizzled vec lvalue

2018-10-05 Thread Ilia Mirkin
Current mesa fails both of these (in different ways!). Inspired by WebGL conformance test conformance2/glsl3/vector-dynamic-indexing-swizzled-lvalue.html Signed-off-by: Ilia Mirkin --- .../swizzled-writemask-indexing-nonconst.shader_test| 17 + .../execution/swizzled-writema

[Piglit] [PATCH 2/4] glsl-1.10: Verify that gl_TexCoord cannot be redeclared to change qualifier or type

2018-10-05 Thread Ian Romanick
From: Ian Romanick glslangValidator rejects all of the shaders that try to change the qualifier with errors like: ERROR: 0:8: 'redeclaration' : cannot change qualification of gl_TexCoord Mesa currently allows all of them to compile. Closed-source drivers have not been tested. glslangValid

[Piglit] [PATCH 4/4] glsl-1.50: Verify that gl_ClipDistance cannot be redeclared to change qualifier or type

2018-10-05 Thread Ian Romanick
From: Ian Romanick glslangValidator rejects all of the shaders that try to change the qualifier with errors like: ERROR: 0:8: 'redeclaration' : cannot change qualification of gl_ClipDistance Mesa currently allows all of them to compile. Closed-source drivers have not been tested. glslangV

[Piglit] [PATCH 3/4] glsl-1.30: Verify that gl_ClipDistance cannot be redeclared to change qualifier or type

2018-10-05 Thread Ian Romanick
From: Ian Romanick glslangValidator rejects all of the shaders that try to change the qualifier with errors like: ERROR: 0:8: 'redeclaration' : cannot change qualification of gl_ClipDistance Mesa currently allows all of them to compile. Closed-source drivers have not been tested. glslangV

[Piglit] [PATCH 1/4] glsl-1.50: Add missing out qualifier on gl_ClipDistance redeclaration

2018-10-05 Thread Ian Romanick
From: Ian Romanick See https://lists.freedesktop.org/archives/piglit/2013-October/007935.html for the discussion. Signed-off-by: Ian Romanick Cc: Andrii Simiklit --- .../glsl-1.50/execution/geometry/clip-distance-out-values.shader_test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Piglit] [PATCH] quick_shader: Do not exclude tests in sanity profile.

2018-10-05 Thread Dylan Baker
Quoting Rafael Antognolli (2018-10-05 12:44:02) > On Fri, Oct 05, 2018 at 12:16:53PM -0700, Dylan Baker wrote: > > Quoting Rafael Antognolli (2018-10-05 11:25:24) > > > On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote: > > > > Does this change the set of tests in the profile? I think it

Re: [Piglit] [PATCH] quick_shader: Do not exclude tests in sanity profile.

2018-10-05 Thread Rafael Antognolli
On Fri, Oct 05, 2018 at 12:16:53PM -0700, Dylan Baker wrote: > Quoting Rafael Antognolli (2018-10-05 11:25:24) > > On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote: > > > Does this change the set of tests in the profile? I think it will since > > > we'll > > > end up calling self.random

Re: [Piglit] [PATCH] quick_shader: Do not exclude tests in sanity profile.

2018-10-05 Thread Dylan Baker
Quoting Rafael Antognolli (2018-10-05 11:25:24) > On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote: > > Does this change the set of tests in the profile? I think it will since > > we'll > > end up calling self.random.random() a different number of times. > > That's the idea. Now a test

Re: [Piglit] [PATCH] quick_shader: Do not exclude tests in sanity profile.

2018-10-05 Thread Rafael Antognolli
On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote: > Does this change the set of tests in the profile? I think it will since we'll > end up calling self.random.random() a different number of times. That's the idea. Now a test always gets included if it's already in the sanity profile. An

Re: [Piglit] [PATCH] egl_ext_device_drm: don't fail the test if open("/dev/dri/cardX") errors

2018-10-05 Thread Dylan Baker
In other cases like this we return skip instead of warn. I think that it should be skip because: 1) warn doesn't have any real meaning 2) we couldn't actually run the test so there isn't a result Dylan Quoting Emil Velikov (2018-10-03 05:21:56) > From: Emil Velikov > > As pointed out by Mathia

Re: [Piglit] [PATCH] quick_shader: Do not exclude tests in sanity profile.

2018-10-05 Thread Dylan Baker
Does this change the set of tests in the profile? I think it will since we'll end up calling self.random.random() a different number of times. Quoting Rafael Antognolli (2018-10-03 10:51:28) > We randomly exclude 80% of the 'arb_vertex_attrib_64bit/execution/vs_in' > tests, but we want to keep at

Re: [Piglit] [PATCH] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-05 Thread Dylan Baker
Quoting Eric Engestrom (2018-10-05 08:22:38) > On Thursday, 2018-10-04 11:28:22 -0700, Dylan Baker wrote: > > Because wflinfo returns GL legacy (non-profile) for gles on glx. > > --- > > framework/wflinfo.py | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/fra

[Piglit] [PATCH v2] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-05 Thread Dylan Baker
Because wflinfo returns GL legacy (non-profile) for gles on glx. v2: - If the platform is pure GLX then warn that things aren't going to work. --- framework/wflinfo.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/framework/wflinfo.py b/framework

Re: [Piglit] [PATCH] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-05 Thread Eric Engestrom
On Thursday, 2018-10-04 11:28:22 -0700, Dylan Baker wrote: > Because wflinfo returns GL legacy (non-profile) for gles on glx. > --- > framework/wflinfo.py | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/framework/wflinfo.py b/framework/wflinfo.py > index a568bc344.