Re: [Piglit] [PATCH 0/4] summary/html: html fixes

On 1/21/19 10:44 PM, Ilia Mirkin wrote: Series is Reviewed-by: Ilia Mirkin As an aside, it appears that we're using xhtml? That's pretty much dead nowadays. The recommendation tends to be to have on the first line, and that's it. Was about to say the same .. and then set charset in the

[Piglit] [PATCH] arb_gpu_shader5: add more variants of the struct interpolateAt tests

--- ...ateAtCentroid-array-of-structs.shader_test | 63 +++ ...-interpolateAtCentroid-struct2.shader_test | 59 + 2 files changed, 122 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-interpolateAtCentroid-array-of-struct

Re: [Piglit] [PATCH 0/4] summary/html: html fixes

Series is Reviewed-by: Ilia Mirkin As an aside, it appears that we're using xhtml? That's pretty much dead nowadays. The recommendation tends to be to have on the first line, and that's it. Cheers, -ilia On Mon, Jan 21, 2019 at 11:01 AM Erik Faye-Lund wrote: > > After a recent update, it

[Piglit] [PATCH 4/4] summary/html: escape html

We currently emit characters like '<' and '>' in some places, let's avoid that so all browsers will render the result correctly. In particular, GNOME Web (Epiphany) refuse to render the result without this. Signed-off-by: Erik Faye-Lund --- templates/index.mako | 4 ++-- 1 file changed, 2 inser

[Piglit] [PATCH 0/4] summary/html: html fixes

After a recent update, it seems GNOME Web / Epiphany has gotten stricter about the HTML it accepts. This patch series fixes up the issues I noticed. Erik Faye-Lund (4): summary/html: close the right html-tag summary/html: open pre-tag instead of closing it summary/html: ensure xml-line is th

[Piglit] [PATCH 3/4] summary/html: ensure xml-line is the very first line

Otherwise, GNOME Web (Epiphany) refuse to render the result. Signed-off-by: Erik Faye-Lund --- templates/feature.mako | 3 ++- templates/index.mako | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/templates/feature.mako b/templates/feature.mako index 9abd5bc31..7d2c400d9

[Piglit] [PATCH 1/4] summary/html: close the right html-tag

Signed-off-by: Erik Faye-Lund --- templates/test_result.mako | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/test_result.mako b/templates/test_result.mako index ff08797bc..9505e6a68 100644 --- a/templates/test_result.mako +++ b/templates/test_result.mako @@ -26,7 +26

[Piglit] [PATCH 2/4] summary/html: open pre-tag instead of closing it

Signed-off-by: Erik Faye-Lund --- templates/test_result.mako | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/test_result.mako b/templates/test_result.mako index 9505e6a68..ad90b3ae5 100644 --- a/templates/test_result.mako +++ b/templates/test_result.mako @@ -72,7 +72