[Piglit] [PATCH 17/17] arb_gl_spirv: add ssbo test using std140 and std430

2018-09-15 Thread Alejandro Piñeiro
The test includes two ssbos, with the same content but different layouts, in order to ensure that works in both cases. Note that std140 and std430 layouts are used on the base GLSL shader used to generate the SPIR-V shaders. SPIR-V shaders doesn't include info about the layout. From ARB_gl_spirv

[Piglit] [PATCH 16/17] arb_gl_spirv: Add a test for SSBOs with an unsized array

2018-09-15 Thread Alejandro Piñeiro
From: Neil Roberts This tests handling of the OpTypeRuntimeArray opcode. --- .../execution/ssbo/unsized-array.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/ssbo/unsized-array.shader_test diff --git

[Piglit] [PATCH 15/17] arb_gl_spirv: adding complex ssbo matrix test

2018-09-15 Thread Alejandro Piñeiro
--- .../execution/ssbo/matrix/complex.shader_test | 699 + 1 file changed, 699 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/ssbo/matrix/complex.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/ssbo/matrix/complex.shader_test

[Piglit] [PATCH 14/17] arb_gl_spirv: add simple ssbo tests with matrices

2018-09-15 Thread Alejandro Piñeiro
--- .../execution/ssbo/matrix/column-major.shader_test | 109 .../ssbo/matrix/column-vs-row.shader_test | 196 + .../ssbo/matrix/indirect-column-major.shader_test | 131 ++ .../ssbo/matrix/indirect-row-major.shader_test | 131

[Piglit] [PATCH 12/17] arb_gl_spirv: add ubo array test with different array_stride

2018-09-15 Thread Alejandro Piñeiro
For more info, see the long explanation at the commit "arb_gl_spirv: add ubo matrix test with different matrix_stride" --- .../array-different-array-stride-ubo.shader_test | 147 + 1 file changed, 147 insertions(+) create mode 100644

[Piglit] [PATCH 09/17] arb_gl_spirv: add a array of ubo test, with complex ubo content

2018-09-15 Thread Alejandro Piñeiro
Specifically the ubo contains some basic types and a struct type. --- .../execution/ubo/array-complex.shader_test| 183 + 1 file changed, 183 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/ubo/array-complex.shader_test diff --git

[Piglit] [PATCH 11/17] arb_gl_spirv: add ubo matrix test with different matrix_stride

2018-09-15 Thread Alejandro Piñeiro
ARB_gl_spirv requires that the SPIR-V includes the explicit matrix stride. In general layouts are mapping with explicit offset, matrix stride and array stride. As far as it respect alignments and minimum offsets, matrix_stride doesn't need to be exactly what OpenGL GLSL computes, and in fact, the

[Piglit] [PATCH 10/17] arb_gl_spirv: Add tests for UBOs with explicit offsets

2018-09-15 Thread Alejandro Piñeiro
From: Neil Roberts Adds two tests, one which has an explicit offset in GLSL using the layout(offset) decoration on an interface member, and another which has a struct embedded in an interface. On SPIR-V it is possible to set an explicit offset even within this embedded struct. ---

[Piglit] [PATCH 13/17] arb_gl_spirv: add some simple ssbo tests

2018-09-15 Thread Alejandro Piñeiro
Equivalent to the ubo tests added with the commit "arb_gl_spirv: add some simple ubo tests", but without the linker tests and the regression-check test. --- .../execution/ssbo/array-indirect.shader_test | 121 .../execution/ssbo/array-inside-ssbo.shader_test | 104 ++

[Piglit] [PATCH 08/17] arb_gl_spirv: add complex ubo test with matrices

2018-09-15 Thread Alejandro Piñeiro
UBO test using several matrices on one block. All possible size combination, mixing row and column major. --- .../execution/ubo/matrix/complex.shader_test | 624 + 1 file changed, 624 insertions(+) create mode 100644

[Piglit] [PATCH 05/17] arb_gl_spirv: add GL_ACTIVE_UNIFORMS checks

2018-09-15 Thread Alejandro Piñeiro
Right now the main reason is to check that we are expanding uniforms for arrays and array of arrays of structs properly. This would be even more important with UBO/SSBO tests. The other reason is to check that hidden uniforms are really hidden. As far as we know, current arb_gl_spirv tests

[Piglit] [PATCH 03/17] shader_runner: add forcing_no_names mode

2018-09-15 Thread Alejandro Piñeiro
Right now UBO data filling is based on using the name of the ubo and their components, in order to get the block and uniform index. It also uses it to set the binding (so it forces block_index and block_binding to be equal). Since ARB_shading_language_420pack it is possible to set a explicit ubo

[Piglit] [PATCH 04/17] shader_runner: add support for glGetProgram queries

2018-09-15 Thread Alejandro Piñeiro
Similar to the already existing verify program_interface_query, but with the glGetProgramiv queries. Useful, for example, to verify the current number of active (via GL_ACTIVE_UNIFORMS). Note that now there are two ways to verify link success. With the already existing "link succes" shader

[Piglit] [PATCH 07/17] arb_gl_spirv: add simple ubo tests with matrices

2018-09-15 Thread Alejandro Piñeiro
--- .../execution/ubo/matrix/column-major.shader_test | 96 +++ .../execution/ubo/matrix/column-vs-row.shader_test | 176 + .../ubo/matrix/indirect-column-major.shader_test | 119 ++ .../ubo/matrix/indirect-row-major.shader_test | 119

[Piglit] [PATCH 06/17] arb_gl_spirv: add some simple ubo tests

2018-09-15 Thread Alejandro Piñeiro
Add two linker tests and several simple execution tests for ubo. Linker tests just checks for some basic linker errors (like mistmatched ubo on different stages). The execution tests include: * Simple one with just one ubo * Two different ubo on the same stage * Same ubo used on

[Piglit] [PATCH 00/17] ARB_gl_spirv: ubo/ssbo tests

2018-09-15 Thread Alejandro Piñeiro
, as they are patches that just improve the log when a test fail/skips on two specific cases. The tree for this series can be found on the following repository: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series5-ubo-ssbo-v1 Alejandro Piñeiro (15): shader_runner/spirv: log skip reason

[Piglit] [PATCH 03/17] shader_runner: add forcing_no_names mode

2018-09-15 Thread Alejandro Piñeiro
Right now UBO data filling is based on using the name of the ubo and their components, in order to get the block and uniform index. It also uses it to set the binding (so it forces block_index and block_binding to be equal). Since ARB_shading_language_420pack it is possible to set a explicit ubo

[Piglit] [PATCH 02/17] shader_runner/spirv: check if test really includes spirv

2018-09-15 Thread Alejandro Piñeiro
SPIRV YES/ONLY assumes that the test includes the SPIR-V shader, and that you should use it. This commit checks that this really happens, and prints a proper error message. Without this commit, a SPIRV YES/ONLY test that by mistake didn't include the [spirv xx] sections would be just skipped with

[Piglit] [PATCH 01/17] shader_runner/spirv: log skip reason on ARB_gl_spirv extension check

2018-09-15 Thread Alejandro Piñeiro
--- tests/shaders/shader_runner.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index cc377cb5e..1795d66ce 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -814,6 +814,8 @@ static enum

Re: [Piglit] [PATCH] shader_runner: Take spirv_replaces_glsl into account for current_config

2018-09-05 Thread Alejandro Piñeiro
On 05/09/18 18:44, Michel Dänzer wrote: > On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote: >> On 04/09/18 17:24, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Without this, validate_current_gl_context never returns true if >>> spirv_replaces_

Re: [Piglit] [PATCH] shader_runner: Take spirv_replaces_glsl into account for current_config

2018-09-05 Thread Alejandro Piñeiro
On 04/09/18 17:24, Michel Dänzer wrote: > From: Michel Dänzer > > Without this, validate_current_gl_context never returns true if > spirv_replaces_glsl == true, resulting in repeatedly calling > recreate_gl_context indefinitely after the first subtest. Hi, could you provide some extra details?

[Piglit] [PATCH] arb_tessellation_shader: add GL_EXT_shader_integer_mix on [require]

2018-08-24 Thread Alejandro Piñeiro
Needed by the tessellation evaluation shader. --- .../tes-patch-input-array-vec2-index-invalid-rd.shader_test | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_tessellation_shader/execution/variable-indexing/tes-patch-input-array-vec2-index-invalid-rd.shader_test

Re: [Piglit] [PATCH piglit] util: stop overallocating shader memory

2018-08-24 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 23/08/18 18:50, Eric Engestrom wrote: > Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" > Cc: Alejandro Piñeiro > Signed-off-by: Eric Engestrom > --- > tests/util/piglit-shader-test.c | 2 +- > 1 fil

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-20 Thread Alejandro Piñeiro
On 20/08/18 04:11, Timothy Arceri wrote: > On 18/08/18 19:30, Alejandro Piñeiro wrote: >> On 18/08/18 06:36, Timothy Arceri wrote: >>> On 18/08/18 14:32, Timothy Arceri wrote: >>>> Won't this cause shader runner to needlessly parse the .shader_test >>>>

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-18 Thread Alejandro Piñeiro
ous issue. As that would be a small change, I will make the change locally, while I wait for the review of the other patches. Thanks pointing that out > >> >> On 09/08/18 21:36, Alejandro Piñeiro wrote: >>> From: Neil Roberts >>> >>> v2: use shader_test f

Re: [Piglit] [PATCH] glsl-1.10: add a 'invalid-array-as-function-param' glslparsertest

2018-08-14 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 14/08/18 09:41, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 > --- > .../spec/glsl-1.10/compiler/invalid-array-as-function-param.vert | 9 > + > 1 file cha

[Piglit] [PATCH 22/35] arb_gl_spirv: Add a test for a uniform struct with struct members

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/embedded-structs.shader_test | 151 + 1 file changed, 151 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/embedded-structs.shader_test diff --git

[Piglit] [PATCH 35/35] arb_gl_spirv: adding basic va64 test

2018-08-09 Thread Alejandro Piñeiro
--- .../arb_gl_spirv/execution/va64-simple.shader_test | 136 + 1 file changed, 136 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/va64-simple.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/va64-simple.shader_test

[Piglit] [PATCH 28/35] arb_gl_spirv: add test that mixes atomic counters with a normal uniform

2018-08-09 Thread Alejandro Piñeiro
Under ARB_gl_spirv, most uniforms require a explicit location. There are some exceptions like atomic counters. In that case, some drivers like mesa, still sets internally a location for those. This test purpose is checking that mixing "normal" uniforms with uniforms without location works

[Piglit] [PATCH 20/35] arb_gl_spirv: Add a test for non-sequential explicit uniform locations

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts Tests using two uniforms that have explicit uniform locations with a gap between them. --- .../uniform/nonsequential-locations.shader_test| 69 ++ 1 file changed, 69 insertions(+) create mode 100644

[Piglit] [PATCH 27/35] arb_gl_spirv: add tests for atomic counter operations in CS

2018-08-09 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification in a CS with local_size_x, y, z equal to 3, 2 and 1 respectively. Includes 3 tests: atomic_uint, arrays of atomic_uint and AOA of

[Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 1

[Piglit] [PATCH 26/35] arb_gl_spirv: add tests for atomic counter operations in FS

2018-08-09 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification. They check the final values for the atomic counters and that the values returned by the atomic counter operations are the expected ones.

[Piglit] [PATCH 33/35] arb_enhanced_layouts: Test doubles

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include a SPIR-V binary binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 2 +- .../shader_test

[Piglit] [PATCH 34/35] util/vbo: Accept integer attribute names

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- tests/util/piglit-vbo.cpp | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/tests/util/piglit-vbo.cpp b/tests/util/piglit-vbo.cpp index 86d5081de..3ef6b1107 100644 --- a/tests/util/piglit-vbo.cpp +++

[Piglit] [PATCH 30/35] util: Add utilities to handle shader_test files

2018-08-09 Thread Alejandro Piñeiro
v2: fix memory leak (Antia Puentes) --- tests/util/CMakeLists.txt | 1 + tests/util/piglit-shader-test.c | 156 tests/util/piglit-shader-test.h | 43 +++ 3 files changed, 200 insertions(+) create mode 100644

[Piglit] [PATCH 29/35] util: Add a utility to assemble SPIR-V sources

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts Adds piglit_assemble_spirv which invokes spirv-as to assemble a SPIR-V source. The function is based on a static helper function that was in shader_runner. --- tests/shaders/shader_runner.c | 45 ++- tests/util/piglit-shader.c| 37

[Piglit] [PATCH 32/35] arb_enhanced_layouts: Test XFB layout qualifiers via SPIR-V

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 22 +- .../shader_test

[Piglit] [PATCH 24/35] arb_gl_spirv: Add a fiddly test for uniform index calculation

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts This is a somewhat convoluted test to catch a particular problem with the code we were using to assign a uniform index to a variable. A uniform’s location starts off being the explicit location. Previously while recursing through the uniform’s type, whenever the location

[Piglit] [PATCH 21/35] arb_gl_spirv: Add a test for a struct uniform

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct.shader_test | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test

[Piglit] [PATCH 23/35] arb_gl_spirv: Add a test for an array of structs uniform

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct-array.shader_test | 140 + 1 file changed, 140 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct-array.shader_test diff --git

[Piglit] [PATCH 25/35] shader_runner: add command 'probe atomic counter buffer'

2018-08-09 Thread Alejandro Piñeiro
From: Antia Puentes Extends the already existing 'probe atomic counter' command to allow comparing the value of an atomic counter stored in an ATOMIC_COUNTER_BUFFER with a binding different from zero, and at a chosen offset. In other words, adds support to test the atomic counter layout

[Piglit] [PATCH 17/35] arb_gl_spirv: Add a test for nonconst array of sampler structs

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts This is a simple port of arb_arrays_of_arrays/execution/sampler/ fs-nested-struct-arrays-nonconst-nested-array.shader_test --- .../sampler2d-nonconst-nested-array.shader_test| 225 + 1 file changed, 225 insertions(+) create mode 100644

[Piglit] [PATCH 19/35] arb_gl_spirv: Add 4 tests for uniform initializers

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts This includes a basic test with uniform initializers, one using a mat4x3 type, one using a dvec4 and finally a complex one using a combination of types (arrays, structs and mats). # This is the commit message #2: --- .../uniform/initializer-complex.shader_test| 180

[Piglit] [PATCH 18/35] arb_gl_spirv: add two linking tests for uniform multisample images

2018-08-09 Thread Alejandro Piñeiro
-by: Alejandro Piñeiro Signed-off-by: Antia Puentes --- .../linker/uniform/multisampler-array.shader_test | 68 ++ .../linker/uniform/multisampler.shader_test| 67 + 2 files changed, 135 insertions(+) create mode 100644 tests/spec/arb_gl_spirv

[Piglit] [PATCH 16/35] arb_gl_spirv: Add a test for a sampler within a struct

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/sampler2d-struct.shader_test | 98 ++ 1 file changed, 98 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d-struct.shader_test diff --git

[Piglit] [PATCH 15/35] arb_gl_spirv: Add tests for sampler2D uniform binding initialisers

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../uniform/sampler2d-binding-array.shader_test| 85 ++ .../uniform/sampler2d-binding.shader_test | 70 ++ 2 files changed, 155 insertions(+) create mode 100644

[Piglit] [PATCH 08/35] arb_gl_spirv: Add a test using specializations

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/vs-ps-specializations.shader_test| 181 + 1 file changed, 181 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/vs-ps-specializations.shader_test diff --git

[Piglit] [PATCH 07/35] arb_gl_spirv: add really simple execution test

2018-08-09 Thread Alejandro Piñeiro
Really basic VS-PS pipeline, without uniforms. --- .../execution/vs-ps-simple.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test diff --git

[Piglit] [PATCH 05/35] shader_runner/spirv: Add support for SPIR-V specializations

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts There can now be extra sections such as the following in the shader_test file: [vertex shader specializations] uint 0 3 These will get passed to glSpecializeShader when compiling the corresponding shader. --- tests/shaders/shader_runner.c | 181

[Piglit] [PATCH 13/35] arb_gl_spirv: add execution test for multi-dimensional (aoa) uniform

2018-08-09 Thread Alejandro Piñeiro
--- .../execution/uniform/arrays-of-arrays.shader_test | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/arrays-of-arrays.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/arrays-of-arrays.shader_test

[Piglit] [PATCH 14/35] arb_gl_spirv: uniform sampler2D

2018-08-09 Thread Alejandro Piñeiro
--- .../execution/uniform/sampler2d.shader_test| 70 ++ 1 file changed, 70 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test

[Piglit] [PATCH 02/35] shader_runner/spirv: support loading SPIR-V shaders

2018-08-09 Thread Alejandro Piñeiro
te that in GLSL mode, ARB_gl_spirv is not required. For that reason, we will not add ARB_gl_spirv on the [require] section of the tests. We check for this extension when assembling the SPIR-V shader. Signed-off-by: Nicolai Hähnle Signed-off-by: Alejandro Piñeiro Signed-off-by: Neil

[Piglit] [PATCH 06/35] shader_runner: debug prints if running on SPIR-V mode.

2018-08-09 Thread Alejandro Piñeiro
Fancy to be sure that shader_runner is trying to run in SPIR-V mode. Didn't print if it is running on GLSL mode as that is the default. Initially only some small amount of tests will run on SPIR-V mode. --- tests/shaders/shader_runner.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Piglit] [PATCH 11/35] arb_gl_spirv: add basic test with two uniforms

2018-08-09 Thread Alejandro Piñeiro
--- .../execution/uniform/two-uniforms.shader_test | 132 + 1 file changed, 132 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test

[Piglit] [PATCH 12/35] arb_gl_spirv: add a small test with an array of uniforms

2018-08-09 Thread Alejandro Piñeiro
--- .../execution/uniform/array.shader_test| 137 + 1 file changed, 137 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/array.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/array.shader_test

[Piglit] [PATCH 04/35] shader_runner/spirv: add vertex shader passthrough support on SPIR-V

2018-08-09 Thread Alejandro Piñeiro
Adds a equivalent to the existing GLSL passthrough_vertex_shader_source, but with an SPIR-V assembly one. As it is somewhat big, moved to a different header. An alternative would be kept the assembly on a file, and open it when required. --- tests/shaders/shader_runner.c| 8

[Piglit] [PATCH 09/35] arb_gl_spirv: basic uniform test with names still present

2018-08-09 Thread Alejandro Piñeiro
From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle Signed-off-by: Neil Roberts --- .../execution/uniform/simple.shader_test | 124 + 1 file changed, 124 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/simple.shader_test diff --git

[Piglit] [PATCH 10/35] arb_gl_spirv: add basic uniform test without names

2018-08-09 Thread Alejandro Piñeiro
From: Nicolai Hähnle The names were removed from the text-format SPIR-V by hand. Signed-off-by: Alejandro Piñeiro Signed-off-by: Nicolai Hähnle --- .../uniform/simple-without-names.shader_test | 111 + 1 file changed, 111 insertions(+) create mode 100644 tests

[Piglit] [PATCH 03/35] framework: add --glsl option

2018-08-09 Thread Alejandro Piñeiro
So when executing shader tests, they will be executed with -glsl. This is the force GLSL mode, that is only relevant if the shader test includes SPIR-V shaders. So for example: ./piglit run tests/shader.py -t ARB_gl_spirv --glsl results/results Will try to run all the shader tests for

[Piglit] [PATCH 01/35] util: Add a utility to stream data through an external process

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts The data is given as a buffer which is streamed through the standard in of the child process. The standard output is captured into a buffer. --- tests/util/CMakeLists.txt | 1 + tests/util/piglit-subprocess.c | 207 +

[Piglit] [PATCH 00/35] ARB_gl_spirv: all tests so far

2018-08-09 Thread Alejandro Piñeiro
n be found here: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series4-misc-v1 Alejandro Piñeiro (12): framework: add --glsl option shader_runner/spirv: add vertex shader passthrough support on SPIR-V shader_runner: debug prints if running on SPIR-V mode. arb_gl_spirv: add really simple

Re: [Piglit] [PATCH 2/4] util: Add utilities to handle shader_test files

2018-08-09 Thread Alejandro Piñeiro
On 09/08/18 13:19, Antia Puentes wrote: > Hi Alejandro, > > > On 20/07/18 17:16, Alejandro Piñeiro wrote: >> + >> +bool >> +piglit_load_source_from_shader_test(const char *filename, >> +    GLenum shader_type, >> +  

Re: [Piglit] [PATCH] ext_texture_norm16-render: add more API coverage

2018-07-24 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 23/07/18 14:16, Tapani Pälli wrote: > Add tests for glRenderbufferStorage and glCopyTexImage2D. > > Signed-off-by: Tapani Pälli > --- > tests/spec/ext_texture_norm16/render.c | 53 > -- > 1 file changed

[Piglit] [PATCH 4/4] arb_enhanced_layouts: Test XFB layout qualifiers via SPIR-V

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 22 +- .../shader_test

[Piglit] [PATCH 3/4] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 1

[Piglit] [PATCH 2/4] util: Add utilities to handle shader_test files

2018-07-20 Thread Alejandro Piñeiro
--- tests/util/CMakeLists.txt | 1 + tests/util/piglit-shader-test.c | 154 tests/util/piglit-shader-test.h | 43 +++ 3 files changed, 198 insertions(+) create mode 100644 tests/util/piglit-shader-test.c create mode 100644

[Piglit] [PATCH 1/4] util: Add a utility to assemble SPIR-V sources

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts Adds piglit_assemble_spirv which invokes spirv-as to assemble a SPIR-V source. The function is based on a static helper function that was in shader_runner. --- tests/shaders/shader_runner.c | 45 ++- tests/util/piglit-shader.c| 37

[Piglit] [PATCH 0/4] ARB_gl_spirv: xfb tests

2018-07-20 Thread Alejandro Piñeiro
specific features. Alejandro Piñeiro (1): util: Add utilities to handle shader_test files Neil Roberts (3): util: Add a utility to assemble SPIR-V sources arb_gpu_shader5: Add support for testing spirv with XFB streams arb_enhanced_layouts: Test XFB layout qualifiers via SPIR-V tests

Re: [Piglit] [PATCH 02/24] shader_runner/spirv: support loading SPIR-V shaders

2018-07-12 Thread Alejandro Piñeiro
, Alejandro Piñeiro wrote: > From: Nicolai Hähnle > > This commit add support to load a SPIR-V shader, possible since > ARB_gl_spirv. > > The SPIR-V shader is included on the shader_test script on new shader > stage versions ([vertex shader spirv], [fragment

[Piglit] [PATCH 4/4] arb_gl_spirv: add test that mixes atomic counters with a normal uniform

2018-06-29 Thread Alejandro Piñeiro
Under ARB_gl_spirv, most uniforms require a explicit location. There are some exceptions like atomic counters. In that case, some drivers like mesa, still sets internally a location for those. This test purpose is checking that mixing "normal" uniforms with uniforms without location works

[Piglit] [PATCH 2/4] arb_gl_spirv: add tests for atomic counter operations in FS

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification. They check the final values for the atomic counters and that the values returned by the atomic counter operations are the expected ones.

[Piglit] [PATCH 3/4] arb_gl_spirv: add tests for atomic counter operations in CS

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification in a CS with local_size_x, y, z equal to 3, 2 and 1 respectively. Includes 3 tests: atomic_uint, arrays of atomic_uint and AOA of

[Piglit] [PATCH 1/4] shader_runner: add command 'probe atomic counter buffer'

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Extends the already existing 'probe atomic counter' command to allow comparing the value of an atomic counter stored in an ATOMIC_COUNTER_BUFFER with a binding different from zero, and at a chosen offset. In other words, adds support to test the atomic counter layout

[Piglit] [PATCH 0/4] ARB_gl_spirv: atomic counters tests

2018-06-29 Thread Alejandro Piñeiro
for ARB_gl_spirv: https://lists.freedesktop.org/archives/piglit/2018-June/024605.html You can find both series on the following branch: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series2-atomic-counters-v1 Alejandro Piñeiro (1): arb_gl_spirv: add test that mixes atomic counters with a normal

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-27 Thread Alejandro Piñeiro
On 26/06/18 17:35, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-26 03:44:53) >> On 25/06/18 17:59, Dylan Baker wrote: >>> Quoting Alejandro Piñeiro (2018-06-23 04:26:33) >>>> On 22/06/18 19:14, Dylan Baker wrote: >>>>> Quoting Alejandro

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-26 Thread Alejandro Piñeiro
On 25/06/18 17:59, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-23 04:26:33) >> On 22/06/18 19:14, Dylan Baker wrote: >>> Quoting Alejandro Piñeiro (2018-06-20 05:40:38) >>>> So when executing shader tests, they will be executed with -glsl. This >>>

Re: [Piglit] [PATCH v2] ARB_vertex_attrib_64bit: add doubles support to attributes test

2018-06-25 Thread Alejandro Piñeiro
LGTM. Just a nitpick below. But in any case: Reviewed-by: Alejandro Piñeiro On 25/06/18 10:45, Timothy Arceri wrote: > --- > > V2: Add missing opengl.py entry. > > tests/general/attribs.c | 68 +++-- > tests/opengl.py | 3 +- >

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-23 Thread Alejandro Piñeiro
On 22/06/18 19:14, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-06-20 05:40:38) >> So when executing shader tests, they will be executed with -glsl. This >> is the force GLSL mode, that is only relevant if the shader test >> includes SPIR-V shaders. > I'm not sure

Re: [Piglit] [PATCH v2 00/24] ARB_gl_spirv: support for loading SPIR-V binaries, plus first set of tests

2018-06-20 Thread Alejandro Piñeiro
I forgot to mention that you can find this series, rebased against today master, here: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series1-uniforms-v2 On 20/06/18 14:40, Alejandro Piñeiro wrote: > Hi, > > this is the second version of the first series of patches to

[Piglit] [PATCH 16/24] arb_gl_spirv: Add a test for a sampler within a struct

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/sampler2d-struct.shader_test | 98 ++ 1 file changed, 98 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d-struct.shader_test diff --git

[Piglit] [PATCH v2 00/24] ARB_gl_spirv: support for loading SPIR-V binaries, plus first set of tests

2018-06-20 Thread Alejandro Piñeiro
dependency to piglit. Withougo spirv-tools, those tests would just fail, but it would be good if people thinks that's ok. Alejandro Piñeiro (9): framework: add --glsl option shader_runner/spirv: add vertex shader passthrough support on SPIR-V shader_runner: debug prints if running on S

[Piglit] [PATCH 20/24] arb_gl_spirv: Add a test for non-sequential explicit uniform locations

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts Tests using two uniforms that have explicit uniform locations with a gap between them. --- .../uniform/nonsequential-locations.shader_test| 69 ++ 1 file changed, 69 insertions(+) create mode 100644

[Piglit] [PATCH 17/24] arb_gl_spirv: Add a test for nonconst array of sampler structs

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This is a simple port of arb_arrays_of_arrays/execution/sampler/ fs-nested-struct-arrays-nonconst-nested-array.shader_test --- .../sampler2d-nonconst-nested-array.shader_test| 225 + 1 file changed, 225 insertions(+) create mode 100644

[Piglit] [PATCH 14/24] arb_gl_spirv: uniform sampler2D

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/sampler2d.shader_test| 70 ++ 1 file changed, 70 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test

[Piglit] [PATCH 15/24] arb_gl_spirv: Add tests for sampler2D uniform binding initialisers

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../uniform/sampler2d-binding-array.shader_test| 85 ++ .../uniform/sampler2d-binding.shader_test | 70 ++ 2 files changed, 155 insertions(+) create mode 100644

[Piglit] [PATCH 09/24] arb_gl_spirv: basic uniform test with names still present

2018-06-20 Thread Alejandro Piñeiro
From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle Signed-off-by: Neil Roberts --- .../execution/uniform/simple.shader_test | 124 + 1 file changed, 124 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/simple.shader_test diff --git

[Piglit] [PATCH 23/24] arb_gl_spirv: Add a test for an array of structs uniform

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct-array.shader_test | 140 + 1 file changed, 140 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct-array.shader_test diff --git

[Piglit] [PATCH 12/24] arb_gl_spirv: add a small test with an array of uniforms

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/array.shader_test| 137 + 1 file changed, 137 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/array.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/array.shader_test

[Piglit] [PATCH 05/24] shader_runner/spirv: Add support for SPIR-V specializations

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts There can now be extra sections such as the following in the shader_test file: [vertex shader specializations] uint 0 3 These will get passed to glSpecializeShader when compiling the corresponding shader. --- tests/shaders/shader_runner.c | 181

[Piglit] [PATCH 24/24] arb_gl_spirv: Add a fiddly test for uniform index calculation

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This is a somewhat convoluted test to catch a particular problem with the code we were using to assign a uniform index to a variable. A uniform’s location starts off being the explicit location. Previously while recursing through the uniform’s type, whenever the location

[Piglit] [PATCH 21/24] arb_gl_spirv: Add a test for a struct uniform

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct.shader_test | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test

[Piglit] [PATCH 22/24] arb_gl_spirv: Add a test for a uniform struct with struct members

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/embedded-structs.shader_test | 151 + 1 file changed, 151 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/embedded-structs.shader_test diff --git

[Piglit] [PATCH 19/24] arb_gl_spirv: Add 4 tests for uniform initializers

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This includes a basic test with uniform initializers, one using a mat4x3 type, one using a dvec4 and finally a complex one using a combination of types (arrays, structs and mats). # This is the commit message #2: --- .../uniform/initializer-complex.shader_test| 180

[Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-20 Thread Alejandro Piñeiro
So when executing shader tests, they will be executed with -glsl. This is the force GLSL mode, that is only relevant if the shader test includes SPIR-V shaders. So for example: ./piglit run tests/shader.py -t ARB_gl_spirv --glsl results/results Will try to run all the shader tests for

[Piglit] [PATCH 10/24] arb_gl_spirv: add basic uniform test without names

2018-06-20 Thread Alejandro Piñeiro
From: Nicolai Hähnle The names were removed from the text-format SPIR-V by hand. Signed-off-by: Alejandro Piñeiro Signed-off-by: Nicolai Hähnle --- .../uniform/simple-without-names.shader_test | 111 + 1 file changed, 111 insertions(+) create mode 100644 tests

[Piglit] [PATCH 04/24] shader_runner/spirv: add vertex shader passthrough support on SPIR-V

2018-06-20 Thread Alejandro Piñeiro
Adds a equivalent to the existing GLSL passthrough_vertex_shader_source, but with an SPIR-V assembly one. As it is somewhat big, moved to a different header. An alternative would be kept the assembly on a file, and open it when required. --- tests/shaders/shader_runner.c| 8

[Piglit] [PATCH 07/24] arb_gl_spirv: add really simple execution test

2018-06-20 Thread Alejandro Piñeiro
Really basic VS-PS pipeline, without uniforms. --- .../execution/vs-ps-simple.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test diff --git

[Piglit] [PATCH 18/24] arb_gl_spirv: add two linking tests for uniform multisample images

2018-06-20 Thread Alejandro Piñeiro
-by: Alejandro Piñeiro Signed-off-by: Antia Puentes --- .../linker/uniform/multisampler-array.shader_test | 68 ++ .../linker/uniform/multisampler.shader_test| 67 + 2 files changed, 135 insertions(+) create mode 100644 tests/spec/arb_gl_spirv

[Piglit] [PATCH 11/24] arb_gl_spirv: add basic test with two uniforms

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/two-uniforms.shader_test | 132 + 1 file changed, 132 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test

<    1   2   3   4   5   >