Re: [Piglit] [PATCH 2/2] polygon-mode: also test polygon culling

2018-07-20 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, July 20, 2018 8:48:12 AM To: piglit@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Brian Paul Subject: [PATCH 2/2] polygon-mode: also test polygon culling Test polygon

Re: [Piglit] [PATCH] gl-1.5-get-array-attribs: exercise glGetIntegerv, etc. with vertex arrays

2018-05-09 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Wednesday, May 9, 2018 8:30:05 AM To: piglit@lists.freedesktop.org Cc: xuelian@samsung.com; Neha Bhende; Charmaine Lee; Brian Paul Subject: [P

Re: [Piglit] [PATCH] ext_transform_feedback-max-varyings: reduce output upon failures

2017-12-18 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Monday, December 18, 2017 2:28:14 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] ext_transform_

Re: [Piglit] [PATCH] generators: fix incorrect generated_tests/spec/glsl-110, etc. dir names

2017-11-17 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Friday, November 17, 2017 12:03:40 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Dylan Baker; Brian Paul Subject: [PATCH] gen

Re: [Piglit] [PATCH] gl-1.0-logicop: allow testing single mode on the command line

2017-11-10 Thread Charmaine Lee
>From: Brian Paul <bri...@vmware.com> >Sent: Thursday, November 9, 2017 12:52 PM >To: piglit@lists.freedesktop.org >Cc: Charmaine Lee; Brian Paul >Subject: [PATCH] gl-1.0-logicop: allow testing single mode on the command line >And require GL 1.1 since that's when color

Re: [Piglit] [PATCH] framework: specify GL_NEAREST filter for FBO textures

2017-11-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Thursday, November 9, 2017 12:52:42 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] framework: specify GL_NE

Re: [Piglit] [PATCH] framework: decrement argc in delete_arg()

2017-11-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Thursday, November 9, 2017 8:18:31 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] framework: decrement argc i

Re: [Piglit] [PATCH] cmake: create Win10 manifest files for particular executables

2017-10-27 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Friday, October 27, 2017 9:12:33 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca; Brian Paul Subject: [PATCH] c

Re: [Piglit] [PATCH 2/2] framework: fix proces/process_isolation typo

2017-09-25 Thread Charmaine Lee
For both patches, Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Monday, September 25, 2017 3:47:24 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH 2/

Re: [Piglit] [PATCH 2/2] gl-2.0-vertex-attr-0: new test of glVertexAttrib(index=0)

2017-08-22 Thread Charmaine Lee
For the series: Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Tuesday, August 22, 2017 1:21:40 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH 2/2] g

Re: [Piglit] [PATCH] arb_texture_multisample/sample-mask-execution: check GL_MAX_SAMPLES

2017-07-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Monday, July 24, 2017 9:37 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] arb_texture_multisample

Re: [Piglit] [PATCH] clipflat: refactor some code

2017-07-14 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Friday, July 14, 2017 9:06 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] clipflat: refactor som

Re: [Piglit] [PATCH 3/3] glx-multi-window-single-context: new GLX test

2017-07-11 Thread Charmaine Lee
>From: Brian Paul <bri...@vmware.com> >Sent: Friday, July 7, 2017 11:02 AM >To: piglit@lists.freedesktop.org >Cc: Charmaine Lee; Brian Paul >Subject: [PATCH 3/3] glx-multi-window-single-context: new GLX test >To exercise rendering into multiple windows with one cont

Re: [Piglit] [PATCH] glx-multi-context-single-window: new GLX test

2017-07-11 Thread Charmaine Lee
>From: Brian Paul <bri...@vmware.com> >Sent: Tuesday, July 11, 2017 10:28 AM >To: piglit@lists.freedesktop.org >Cc: Charmaine Lee; Brian Paul >Subject: [PATCH] glx-multi-context-single-window: new GLX test >Test rendering into one window with multiple contexts. >Cu

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

2017-06-07 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Wednesday, June 7, 2017 8:51:52 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] util: call fflush()

Re: [Piglit] [PATCH] xor-copypixels: simple test of glCopyPixels in XOR mode

2016-05-16 Thread Charmaine Lee
Reviewed-by: Charmaine Lee <charmai...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Monday, May 16, 2016 12:58 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] xor-copypixels: simple test of glCopyP

Re: [Piglit] [PATCH] gl-2.0-large-point-fs: new test of large points with fragment shaders

2015-07-07 Thread Charmaine Lee
Thanks for adding the test, Brian. Reviewed-by: Charmaine Lee charmai...@vmware.com From: Brian Paul bri...@vmware.com Sent: Tuesday, July 7, 2015 3:32 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca; Brian Paul Subject: [PATCH] gl-2.0

Re: [Piglit] [PATCH] ext_transform_feedback-points: a new, simple xfb test

2014-11-03 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Monday, November 3, 2014 4:07 PM To: piglit@lists.freedesktop.org Subject: [Piglit

Re: [Piglit] [PATCH 3/3] ext_texture_array: add simple 1D/2D array rendering tests

2014-08-05 Thread Charmaine Lee
Series looks good to me. Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Friday, August 1, 2014 8:07 AM To: piglit@lists.freedesktop.org Subject: [Piglit

Re: [Piglit] [PATCH 2/2] arb_provoking_vertex/xfb-before-flatshading: use default window size

2014-07-03 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Thursday, July 3, 2014 10:41 AM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH 2/2

Re: [Piglit] [PATCH] arb_texture_buffer_object-get: use piglit_get_gl_enum_name() in error msg

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 8:45 AM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH

Re: [Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 8:45 AM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH] util/framework

Re: [Piglit] [PATCH 1/2] piglit-dispatch: fix get_core_proc_address() for Windows

2014-06-25 Thread Charmaine Lee
The series looks good to me. Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 10:50 AM To: piglit@lists.freedesktop.org Subject

Re: [Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 12:27 PM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH