Re: [Piglit] [PATCH 1/1] Tests for compressed cubemaps

On Tue, 2019-01-08 at 15:23 +0200, Eleni Maria Stea wrote: > The compressed-cubemap.c tests the rendering of compressed cubemaps. > The compressed-cubemap-teximage.c tests that compressed cubemaps > created > using dumped compressed 2D faces have the same values with compressed > cubemaps that

Re: [Piglit] [PATCH] tests: update documentation to include GL46 in khr_gl.py

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2018-01-29 at 01:27 +0200, Andres Gomez wrote: > Cc: Kenneth Graunke <kenn...@whitecape.org> > Cc: Dylan Baker <dy...@pnwbakers.com> > Signed-off-by: Andres Gomez <ago...@igalia.com> > --- > tests/

Re: [Piglit] [PATCH] arb_enhanced_layouts: add test for location aliasing with non-numerical type

On Thu, 2017-11-09 at 12:43 +1100, Timothy Arceri wrote: > On 06/11/17 23:22, Iago Toral Quiroga wrote: > > This is not allowed so we check that we produce a linker error. > > It's not 100% obvious why this wouldn't be allowed. Can we have a > spec  > quote

[Piglit] [PATCH] arb_enhanced_layouts: add test for location aliasing with non-numerical type

This is not allowed so we check that we produce a linker error. --- .../vs-to-fs-type-not-numerical.shader_test| 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/linker/component-layout/vs-to-fs-type-not-numerical.shader_test

Re: [Piglit] [PATCH] glsl-1.50: do not link interface-blocks-containing-unsized-arrays.geom

If nobody has comments about this, I'd like to push it tomorrow together with the corresponding patch in Mesa. Iago On Fri, 2016-11-04 at 13:33 +0100, Iago Toral Quiroga wrote: > Linking means that we will validate in/out blocks between consumer > and > producer stages. In this case

[Piglit] [PATCH] glsl-1.50: do not link interface-blocks-containing-unsized-arrays.geom

Linking means that we will validate in/out blocks between consumer and producer stages. In this case it should fail because for geometry shaders piglit will include a dummy vertex shader that does not have a matching output block. This has not been a problem until now because the linker was not

[Piglit] [PATCH] arb_enhanced_layouts: fix shader GLSL version requirement

The test declares that only GLSL 1.40 is required, but then shaders use version 4.20, leading to execution failures if the platform does not support 4.20. Just require GLSL 1.40 in the shaders too, since that is sufficient and consistent with other similar tests. ---

Re: [Piglit] [PATCH] arb_tessellation_shader: add basic read/write variable indexing fp64 tests

Any comments about this? If not I would like to push it in a couple of days. Iago On Fri, 2016-07-15 at 08:52 +0200, Iago Toral Quiroga wrote: > --- >  .../tcs-input-array-dvec4-index-rd.shader_test |  99 > >  .../tcs-output-array-dvec4-index-wr.shader_t

[Piglit] [PATCH] arb_tessellation_shader: add basic read/write variable indexing fp64 tests

--- .../tcs-input-array-dvec4-index-rd.shader_test | 99 .../tcs-output-array-dvec4-index-wr.shader_test| 97 +++ .../tes-input-array-dvec4-index-rd.shader_test | 93 +++ ...put-array-dvec4-index-wr-before-tcs.shader_test | 103

[Piglit] [PATCH] shaders: add test for recursive variable indexing into arrays

--- ...l-recursive-variable-array-indexing.shader_test | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 tests/shaders/glsl-recursive-variable-array-indexing.shader_test diff --git a/tests/shaders/glsl-recursive-variable-array-indexing.shader_test

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: Test linking programs with large copies

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> I guess you will also send the struct version of this, right? Iago On Fri, 2015-11-20 at 10:58 -0800, Jordan Justen wrote: > We test linking of programs that copy a large array, and a large > structure. > > Signed-off

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: Test copying a large SSBO item

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> If the only point of this test is to reproduce the link failure, notice that it is sufficient to do this: [fragment shader] #version 330 #extension GL_ARB_shader_storage_buffer_object: require #define SIZE 16 layout (std430) buffe

Re: [Piglit] [PATCH v2] gles-3.0: NV_read_depth extension test

On Tue, 2015-10-13 at 14:43 +0300, Tapani Pälli wrote: > > On 10/13/2015 09:23 AM, Iago Toral wrote: > > On Mon, 2015-10-12 at 15:42 +0300, Tapani Pälli wrote: > >> v2: review feedback from Iago Toral and Ian Romanick > >> > >> Signed-off-b

Re: [Piglit] [PATCH v2] gles-3.0: NV_read_depth extension test

On Mon, 2015-10-12 at 15:42 +0300, Tapani Pälli wrote: > v2: review feedback from Iago Toral and Ian Romanick > > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> > --- > tests/all.py | 5 + > tests/spec/gles-3.0/CMakeLists.gles3.txt |

Re: [Piglit] [PATCH] gles-3.0: NV_read_depth extension test

On Fri, 2015-10-09 at 11:00 +0300, Tapani Pälli wrote: > > On 10/09/2015 10:56 AM, Tapani Pälli wrote: > > > > > > On 10/09/2015 10:26 AM, Iago Toral wrote: > >> On Thu, 2015-10-08 at 15:13 +0300, Tapani Pälli wrote: > >>> Signed

Re: [Piglit] [PATCH] gles-3.0: NV_read_depth extension test

On Thu, 2015-10-08 at 15:13 +0300, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > tests/all.py | 5 + > tests/spec/gles-3.0/CMakeLists.gles3.txt | 1 + > tests/spec/gles-3.0/read-depth.c | 176 >

Re: [Piglit] [PATCH 1/2] ext_transform_feedback: Fix default precision qualifiers

Hi Timothy, On Mon, 2015-08-03 at 18:39 +1000, Timothy Arceri wrote: On Mon, 2015-08-03 at 08:47 +0200, Iago Toral wrote: If no body has issues with these two patches I'd like to push them later this week. Iago On Tue, 2015-07-28 at 13:52 +0200, Iago Toral Quiroga wrote

Re: [Piglit] [PATCH 1/2] ext_transform_feedback: Fix default precision qualifiers

If no body has issues with these two patches I'd like to push them later this week. Iago On Tue, 2015-07-28 at 13:52 +0200, Iago Toral Quiroga wrote: Default ES precision qualifiers for integer types in the VS and FS are different and that should make the test fail to compile/link if Mesa

[Piglit] [PATCH 2/2] varying-struct-centroid: Fix default precision qualifiers

Default ES precision qualifiers for float types in the VS and FS are different and that should make the test fail to compile/link if Mesa actually checked for these things (because it would realize that VS outputs and FS inputs do not have the exact same type as a consequence). Fix this by

Re: [Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

Hi, if nobody else has comments or objections to this patch I'd like to push it later this week. If someone wants to have a look but needs more time, let me know. Iago On Wed, 2015-03-11 at 08:56 +0100, Iago Toral Quiroga wrote: The textureProj tests multiply expected texture coordinates

Re: [Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

On Wed, 2015-03-11 at 12:52 -0400, Ilia Mirkin wrote: On Wed, Mar 11, 2015 at 9:59 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Mar 11, 2015 at 3:56 AM, Iago Toral Quiroga ito...@igalia.com wrote: The textureProj tests multiply expected texture coordinates by the projector

[Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

The textureProj tests multiply expected texture coordinates by the projector in advance so that when the driver does the division we obtain the same coordinates. However, the division can lead to small rounding errors that can affect the selected layer and fail the tests. This is currently

Re: [Piglit] [PATCH v2] spec/arb_blend_func_extended: Add test for SIMD16 dual source blending

Thanks for reviewing Matt, I'll do all these changes before pushing. Iago On Tue, 2015-03-10 at 18:18 -0700, Matt Turner wrote: On Thu, Mar 5, 2015 at 11:49 PM, Iago Toral Quiroga ito...@igalia.com wrote: On Intel hardware at least, SIMD16 dual source rendering requires handling pixel data

[Piglit] [PATCH] spec/arb_blend_func_extended: Add test for SIMD16 dual source blending

-pattern.c + * @author Iago Toral Quiroga ito...@igalia.com + * + * On Intel hardware at least, SIMD16 dual source rendering requires handling + * pixel data in two sets of 8 pixels each. Incorrect implementations may fail + * to map correct colors for each pixel group (for example by using the color

[Piglit] [PATCH v2] spec/arb_blend_func_extended: Add test for SIMD16 dual source blending

, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +/** + * @file fbo-extended-blend-pattern.c + * @author Iago Toral Quiroga ito...@igalia.com

[Piglit] [PATCH] tex-upload-scale-bias: tests texture upload with scale/bias transfer options

+ * IN THE SOFTWARE. + */ + +/* + * Test texture upload with scale and bias pixel transfer options + * + * Iago Toral Quiroga ito...@igalia.com + * Feb 13, 2015 + */ + +#include piglit-util-gl.h + +PIGLIT_GL_TEST_CONFIG_BEGIN + + config.supports_gl_compat_version = 10; + + config.window_visual

Re: [Piglit] [PATCH] glsl-1.50-geometry-primitive-id-restart: Add workaround for Intel SandyBrige

Jordan has completed the review of the SandyBridge Geometry Shader implementation and I would like to push the series to Mesa, but we need this patch in piglit too so that people running piglit tests on SandyBridge do not run into the GPU hang. If nobody has objections I'll push this patch later

[Piglit] [PATCH] spec/arb_blend_func_extended: Add test for SIMD16 dual source blending

. + */ + +/** + * @file fbo-extended-blend-pattern.c + * @author Iago Toral Quiroga ito...@igalia.com + * + * On Intel hardware at least, SIMD16 dual source rendering requires handling + * pixel data in two sets of 8 pixels each. Incorrect implementations may fail + * to map correct colors for each pixel group

Re: [Piglit] [PATCH v3] polygon-line-aa test case added.

This has been hanging here for a while, so if nobody says otherwise I'd like to push this next week. Iago On jue, 2014-06-12 at 09:00 +0200, Iago Toral Quiroga wrote: This tests correct rendering of polygons using antialised GL_LINE mode for one face and GL_FILL for the other one. On some

Re: [Piglit] [PATCH v3 0/5] arb_gpu_shader5: tests to verify 'stream' layout qualifier

These tests has been in the list for a while and now that drivers are starting to expose ARB_gpu_shader5 it would be nice to have these tests for multi-stream included in the suite, so if nobody says otherwise we would like to push them next week. Iago On mié, 2014-08-20 at 16:30 +0200, Samuel

Re: [Piglit] [PATCH v3] polygon-line-aa test case added.

Hi Paul, I'll make these two changes before pushing next week. Thanks for reviewing this. Iago El 2014-09-09 16:23, Brian Paul escribió: Two comments below. -Brian On 09/09/2014 03:23 AM, Iago Toral Quiroga wrote: This has been hanging here for a while, so if nobody says otherwise I'd like

[Piglit] [PATCH] polygon-line-aa test case added.

This tests correct rendering of polygons using antialised GL_LINE mode for one face and GL_FILL for the other one. On some Intel hardware at least this used to require special handling that has caused regressions in the past. The test checks that the GL_FILL face of the polygon renders properly.

[Piglit] [PATCH v2] polygon-line-aa test case added.

. + * + * Author: Iago Toral ito...@igalia.com + */ + +#include piglit-util-gl-common.h + +PIGLIT_GL_TEST_CONFIG_BEGIN + + config.supports_gl_compat_version = 10; + config.window_width = 100; + config.window_height = 100; + config.window_visual = PIGLIT_GL_VISUAL_RGBA; + +PIGLIT_GL_TEST_CONFIG_END