[Piglit] [PATCH 4/4] arb_tessellation_shader/tes-gs-max-output: new test for TES/GS amplification

From: Nicolai Hähnle Test extremes of GS amplification under tessellation. --- tests/opengl.py | 1 + .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + .../tes-gs-max-output.cpp | 817 ++ 3 files changed, 819 insertions

[Piglit] [PATCH 3/4] glsl-1.50/gs-max-output: new test for geometry shader amplification

From: Nicolai Hähnle Test the extremes of # of GS output vertices / components per GS input primitive. Existing tests only cover cases of high # of components per vertex, but not cases of low # of components per vertex and high # of output vertices. --- tests/opengl.py

[Piglit] [PATCH 1/4] fbo-drawbuffers-maxtargets: fix a warning

From: Nicolai Hähnle Ensure that the allocated buffer is guaranteed to be big enough. --- tests/fbo/fbo-drawbuffers-maxtargets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-drawbuffers-maxtargets.c b/tests/fbo/fbo-drawbuffers-maxtargets.c index f5e2a48ed

[Piglit] [PATCH 2/4] glsl-1.20/fs-deref-literal-array-of-structs-with-multiple-members-large-array: Fix it

From: Nicolai Hähnle Hard to believe that this was never noticed... --- ...f-structs-with-multiple-members-large-array.shader_test | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/spec/glsl-1.20/execution/fs-deref-literal-array-of-structs-with-multiple-members

[Piglit] [PATCH 0/4] Autumn cleaning: misc test case additions and fixes

Hi all, These are a bunch of patches that I've had locally for a while now, hopefully cleaned up enough to be useful :) The big ones are #3 and #4, which add tests for extreme GS and GS+tess amplification cases. Please review! Thanks, Nicolai ___

Re: [Piglit] [PATCH] arb_compute_variable_group_size: check gl_GlobalInvocationID

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 21.10.2017 21:21, Ilia Mirkin wrote: An implementation bug in mesa caused these values to be computed incorrectly. Make sure that they work as defined. Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> --- .../exec

Re: [Piglit] [PATCH 11/11] all.py: run ARB_draw_buffers tests concurrently

For the series: Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 14.10.2017 05:33, Brian Paul wrote: --- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 046c02b..9f37ba2 100644 --- a/tests/all.py +++ b

Re: [Piglit] [PATCH] all.py: add missing argument to arb_sample_shading-samplemask test

On 14.10.2017 05:49, Brian Paul wrote: As it was, argc != 4 caused the test to print usage info and exit with PIGLIT_FAIL. Fixes bbc27395cfc93d3f3 "arb_sample_shading: add more extensive gl_SampleMask(In) tests". Thanks! Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com&g

[Piglit] [RFC 03/10] framework: add Test.name attribute

From: Nicolai Hähnle <nicolai.haeh...@amd.com> So that we can just pass Test objects around instead of (name, test) pairs. --- framework/backends/abstract.py | 8 framework/profile.py | 26 +++--- framework/programs/run.py | 2 +- framewor

[Piglit] [RFC 09/10] framework: allow specifying the number of jobs for concurrency

From: Nicolai Hähnle <nicolai.haeh...@amd.com> The default remains the same: number of CPUs. But on systems with lots of cores but comparatively little (V)RAM it can make sense to reduce the number of jobs to avoid random failures caused by out-of-memory conditions. --- framework/opti

[Piglit] [RFC 10/10] framework/resume: properly parse the no_retry option

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/programs/run.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index bf8a0e612..ecef3dead 100644 --- a/framework/programs/run.py +++ b/framework/pr

[Piglit] [RFC 05/10] framework: add various helper functions to TestResult

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/results.py | 46 ++ 1 file changed, 46 insertions(+) diff --git a/framework/results.py b/framework/results.py index 26ebbe7a6..c13379b3e 100644 --- a/framework/results.py +++ b/fra

[Piglit] [RFC 00/10] Running dEQP tests without process isolation

Hi all, This series allows running dEQP tests (including GL CTS) without process isolation. I've been using it quite successfully for the last few weeks, though there are a bunch of loose ends, off the top of my head: 1. One remaining spurious failure in the `gpu` profile 2. Only tested on gpu,

[Piglit] [RFC 04/10] framework: fix grouptools.commonprefix when len(args) == 1

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/grouptools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/grouptools.py b/framework/grouptools.py index 2ee74ed9f..1a65c0dcd 100644 --- a/framework/grouptools.py +++ b/framework/grouptools.py @@

[Piglit] [RFC 01/10] framework: refactor subtest handling

From: Nicolai Hähnle <nicolai.haeh...@amd.com> The old design of TestResult and TestrunResult has two related limitations that prevent us from relaxing process isolation more than what is done for shader tests: 1. A TestResult can only have subtests one level below its 'root' group. 2.

[Piglit] [RFC 02/10] framework: update JSON storage format to version 10

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Reflect the refactoring of TestResult and TestrunResult in the on-disk storage format. --- framework/backends/abstract.py | 6 +++--- framework/backends/json.py | 39 ++- framework/results.py

[Piglit] [RFC 06/10] framework: refactor test running to use explicit TestWorkItems and TestRunners

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Factor out the execution of tests into TestRunner objects, to allow a cleaner approach to running multiple tests without process isolation. After this patch, which already adapts the shader tests, each individual test is unaffected by w

[Piglit] [RFC 07/10] framework: add a dEQP runner that can run without process isolation

From: Nicolai Hähnle --- framework/test/deqp.py | 202 ++--- 1 file changed, 141 insertions(+), 61 deletions(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index 8627feabb..f62d731b1 100644 ---

[Piglit] [RFC 08/10] framework/deqp: allow loading a *-master.txt file as mustpass list

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/test/deqp.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index f62d731b1..f54135b0e 100644 --- a/framework/test/deqp.py +++ b/framewor

[Piglit] [PATCH 7/7] shader_runner: don't use glMapNamedBufferRange

From: Nicolai Hähnle <nicolai.haeh...@amd.com> We want to be able to run atomic counter tests even when the DSA entry points are unavailable (e.g. in GLES). --- tests/shaders/shader_runner.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/s

[Piglit] [PATCH 6/7] tests/deqp: remove redundant constructors

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/deqp_gles3.py | 4 tests/deqp_vk.py| 3 --- 2 files changed, 7 deletions(-) diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py index 210c6e4ed..6441a9600 100644 --- a/tests/deqp_gles3.py +++ b/tests/deqp_gles3.py @@

[Piglit] [PATCH 4/7] framework: fix a comment

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/profile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 53358868b..a19b4d2d2 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -365,22 +

[Piglit] [PATCH 1/7] framework: fix typos in comments

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/backends/abstract.py | 2 +- framework/backends/json.py | 8 framework/core.py | 2 +- framework/grouptools.py| 2 +- framework/profile.py | 2 +- framework/results.py

[Piglit] [PATCH 0/7] framework, shader_runner: misc fixed and cleanups

Hi all, Mostly no-op changes in comments, but a few functional changes as well. Please review! Thanks, Nicolai -- framework/backends/abstract.py | 2 +- framework/backends/json.py | 12 +--- framework/core.py | 2 +- framework/grouptools.py| 2 +-

[Piglit] [PATCH 3/7] framework: fix outdated comment

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- framework/backends/json.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/framework/backends/json.py b/framework/backends/json.py index c810dcaa5..440202612 100644 --- a/framework/backends/json.py +++ b/framework/ba

[Piglit] [PATCH 2/7] framework: fix a comment

From: Nicolai Hähnle <nicolai.haeh...@amd.com> See ReducedProcessMixin._run_command: if not self._is_cherry(): ... rerun path ... --- framework/test/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/test/base.py b/framework/test/base.py

[Piglit] [PATCH] arb_gpu_shader_int64: test two operands with indirect access simultaneously

From: Nicolai Hähnle <nicolai.haeh...@amd.com> This hits a bug in Mesa st/glsl_to_tgsi. --- .../indirect-array-two-accesses.shader_test| 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/arb_gpu_shader_int64/execution/indirect-arr

[Piglit] [PATCH] arb_gpu_shader_fp64: add tests for frexp() corner cases

From: Nicolai Hähnle <nicolai.haeh...@amd.com> The only-{exponent,mantissa} tests hit a bug in Mesa's st/glsl_to_tgsi. --- .../fs-frexp-dvec4-only-exponent.shader_test | 37 + .../fs-frexp-dvec4-only-mantissa.shader_test | 38 + .../fs-frexp-dvec4-va

[Piglit] [PATCH] fbo-viewport: fix false error caused by slight rounding differences

From: Nicolai Hähnle <nicolai.haeh...@amd.com> This test compares rendering to the window system framebuffer with rendering to an FBO, and it does so by rendering rotated quads. There can be slight differences in rounding if the Y axis is flipped between those buffers causing ren

Re: [Piglit] [PATCH] arb_texture_query_lod: add tolerance for some comparisons

Seems reasonable. Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 15.09.2017 00:59, Roland Scheidegger wrote: ping? Am 09.09.2017 um 07:31 schrieb srol...@vmware.com: From: Roland Scheidegger <srol...@vmware.com> Tolerance was added for the tests a while ago, but i

[Piglit] [PATCH 2/2] arb_sample_shading: run more tests concurrently

From: Nicolai Hähnle <nicolai.haeh...@amd.com> There doesn't seem to be a reason for not running those tests concurrently. Looks like they were just missed. --- tests/all.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index 286

[Piglit] [PATCH 1/2] arb_sample_shading: add more extensive gl_SampleMask(In) tests

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Test the interaction of gl_SampleMask and gl_SampleMaskIn with different sample shading rates. It used to fail on radeonsi. --- tests/all.py | 4 + .../arb_sample_shading/execution/CMakeLists.gl.txt

[Piglit] [PATCH 1/2] arb_query_buffer_object: extract some common code for running queries

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../spec/arb_query_buffer_object/CMakeLists.gl.txt | 2 +- tests/spec/arb_query_buffer_object/common.c| 169 + tests/spec/arb_query_buffer_object/common.h| 58 +++ tests/spec/arb_query_buffer_

[Piglit] [PATCH 2/2] arb_query_buffer_object: add additional coherency tests

From: Nicolai Hähnle <nicolai.haeh...@amd.com> The existing tests only test that shaders receive the query result. The new tests also check for earlier pipeline stages. --- tests/all.py | 1 + .../spec/arb_query_buffer_object/CMakeLists.gl.txt

[Piglit] [PATCH] arb_arrays_of_arrays: remove an unused variable

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../execution/atomic_counters/fs-indirect-index.shader_test | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/spec/arb_arrays_of_arrays/execution/atomic_counters/fs-indirect-index.shader_test b/test

[Piglit] [PATCH] arb_gpu_shader_fp64: relax ldexp test due to denorms

From: Nicolai Hähnle <nicolai.haeh...@amd.com> ldexp(0.5, -1028) will be different from 0.0 on implementations that support denorms. Simply crank up the exponents to exclude the possibility of denorms. --- .../execution/built-in-functions/fs-ldexp-dvec4.shader_test | 8 ++--

[Piglit] [PATCH v2 3/4] arb_gpu_shader5: add interpolateAt* tests with input in a struct

From: Nicolai Hähnle <nicolai.haeh...@amd.com> The fact that this should be allowed was clarified in GLSL 4.60. --- .../fs-interpolateAtCentroid-struct.shader_test| 59 .../fs-interpolateAtOffset-struct.shader_test | 63 ++

[Piglit] [PATCH v2 1/4] arb_gpu_shader5: add execution tests for interpolateAt* with input in an interface block

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> --- ...s-interpolateAtCentroid-block-array.shader_test | 73 + .../fs-interpolateAtCentroid-block.shader_test | 62 ++ .../fs-interpolateAt

[Piglit] [PATCH v2 0/4] More interpolateAt*() tests

Now with clarifications that made their way into GLSL 4.60. Please review! Thanks, Nicolai ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH v2 4/4] glsl-4.40: add tests for interpolateAt* with swizzles / array subscripts on vectors

From: Nicolai Hähnle <nicolai.haeh...@amd.com> For swizzles, the language changed in GLSL 4.40. For array subscripts, it's not entirely clear whether the clarification wrt interpolant being an l-value should be backdated even earlier or not. Keeping it a 4.40 test should be enough for pra

[Piglit] [PATCH v2 2/4] arb_gpu_shader5: add interpolateAtSample tests with input in an array

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> --- ...nterpolateAtSample-array-nonuniform.shader_test | 59 + ...-interpolateAtSample-array-of-array.shader_test | 76 ++ 2 files changed, 13

[Piglit] [PATCH 2/2] arb_transform_feedback_overflow_query-basic: add any_inverted subtest

From: Nicolai Hähnle <nicolai.haeh...@amd.com> There is a bug in VI+ with conditional render for any-stream overflow that depends on whether the condition is inverted or not. --- .../arb_transform_feedback_overflow_query/basic.c| 20 1 file changed, 20 inse

[Piglit] [PATCH 1/2] arb_transform_feedback_overflow_query-basic: fix subtest selection

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/spec/arb_transform_feedback_overflow_query/basic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_transform_feedback_overflow_query/basic.c b/tests/spec/arb_transform_feedback_overflow

Re: [Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

On 20.06.2017 13:32, Nicolai Hähnle wrote: On 19.06.2017 23:46, Ian Romanick wrote: That's actually a little surprising... do other drivers reject this? If so, I'll agree with Timothy that a spec quote would be nice. So, I guess I was going off of what was in the Mesa source already, plus

Re: [Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

issed it. More digging needed... Honestly, I'd interpret the spec language above in a way that forbids using struct elements. The other compilers I can test disagree, but both of them aren't exactly known for their high quality... Cheers, Nicolai On 06/16/2017 01:34 PM, Nicolai Hähnle wrote: From

[Piglit] [PATCH 1/3] arb_gpu_shader5: add execution tests for interpolateAt* with input in an interface block

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- ...s-interpolateAtCentroid-block-array.shader_test | 73 + .../fs-interpolateAtCentroid-block.shader_test | 62 ++ .../fs-interpolateAtOffset-block-array.shader_test | 75 ++

[Piglit] [PATCH 2/3] arb_gpu_shader5: add interpolateAtSample tests with input in an array

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- ...nterpolateAtSample-array-nonuniform.shader_test | 59 + ...-interpolateAtSample-array-of-array.shader_test | 76 ++ 2 files changed, 135 insertions(+) create mode 100644 tests/spec/arb_gpu_s

[Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../fs-interpolateAtCentroid-struct.frag| 17 + .../fs-interpolateAtOffset-struct.frag | 17 + .../fs-interpolateAtSampler-struct.frag | 17 ++

Re: [Piglit] [PATCH] arb_bindless_texture: add new compiler tests for struct with image arrays

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 05.06.2017 16:34, Samuel Pitoiset wrote: ping? On 05/25/2017 08:02 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../nested-struct-arrays-mismatch-format.fr

[Piglit] [PATCH 2/4] shader_runner: add "relative probe rect rgba" command

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/shaders/shader_runner.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 39922d3..b990887 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/s

[Piglit] [PATCH 0/4] Test gl_PrimitiveID in instanced draws

Hi all, these tests add coverage for checking that gl_PrimitiveID resets at the start of a new instance. Radeon GPUs require a few subtleties in hardware to make sure that works correctly, and we were missing some of them. Please review! Thanks, Nicolai -- tests/shaders/shader_runner.c

[Piglit] [PATCH 1/4] shader_runner: add "draw arrays instanced" command

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/shaders/shader_runner.c | 54 +++ 1 file changed, 34 insertions(+), 20 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 6ac5f98..39922d3

[Piglit] [PATCH 3/4] arb_tessellation_shader: test gl_PrimitiveID in instanced draws

From: Nicolai Hähnle <nicolai.haeh...@amd.com> These tests expose a couple of bugs related to gl_PrimitiveID in radeonsi with tessellation enabled: - garbage gl_PrimitiveID in fragment shader if no geometry shader is present - gl_PrimitiveIDIn in geometry shaders is not reset at the

[Piglit] [PATCH 4/4] glsl-1.50: test gl_PrimitiveID in fragment shader when instancing is used

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../primitive-id-no-gs-instanced.shader_test | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/primitive-id-no-gs-instanced.shader_test diff --git a/tests/spec/gls

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: add member-memory-qualifiers.frag

On 29.04.2017 16:23, Samuel Pitoiset wrote: There is actually no positive test which validates the memory qualifiers with members of shader storage blocks. Nice one. Should using readonly/writeonly variables incorrectly be a compile-time error? Reviewed-by: Nicolai Hähnle <nicolai.h

Re: [Piglit] [PATCH] arb_bindless_texture: add new execution tests with sampler/image arrays

On 28.04.2017 14:17, Samuel Pitoiset wrote: Tests loosely based on arb_arrays_of_arrays but with resident textures/images. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../fs-const-index-three-dimensions

Re: [Piglit] [PATCH 2/2] arb_bindless_texture: add struct-inside-uniform-block.frag compiler tests

On 28.04.2017 11:48, Samuel Pitoiset wrote: The spec doesn't clearly state this, but the spec authors say it's allowed. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Both patches: Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../images/struct-in

Re: [Piglit] [PATCH 1/6] arb_bindless_texture: test bound samplers/image with glUniform1i()

On 27.04.2017 22:12, Samuel Pitoiset wrote: On 04/27/2017 10:02 PM, Nicolai Hähnle wrote: On 27.04.2017 00:52, Samuel Pitoiset wrote: From section 2.14.16 of the ARB_bindless_texture spec: "When used as uniforms in the default block, the value of sampler variables may be spec

Re: [Piglit] [PATCH 5/6] arb_bindless_texture: add inout-non-matching-type.frag compiler tests

place, so it's fine if they're trivial to optimize away. The execution tests are what checks that later stages of the compiler pipeline are working correctly. With that in mind, patches 2-5 are: Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 27/04/17 08:52, Samuel Pi

Re: [Piglit] [PATCH 1/6] arb_bindless_texture: test bound samplers/image with glUniform1i()

On 27.04.2017 00:52, Samuel Pitoiset wrote: From section 2.14.16 of the ARB_bindless_texture spec: "When used as uniforms in the default block, the value of sampler variables may be specified with either Uniform1i{v} or UniformHandleui64{v}ARB." From section 2.14.X of the

Re: [Piglit] [PATCH] shader_runner: clean up resident handles at exit time

I wonder whether this should also be cleaned up after each test when running multiple tests at a time. But I don't think we're doing that with textures and other objects either... Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 27.04.2017 10:42, Samuel Pitoiset wrote: Sign

Re: [Piglit] [PATCH] arb_shader_image_load_store: add memory-qualifier-with-non-image-type.frag

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 26.04.2017 18:42, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../memory-qualifier-with-non-image-type.frag | 25 ++ 1 file changed, 25 insertions(+) create

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

- current_alpha) * previous_color Multisampling is also enabled and tested at 2, 4, 8 and 16. Signed-off-by: Plamena Manolova <plamena.manol...@intel.com> Thanks for the v2! Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 5 +

Re: [Piglit] [PATCH] arb_shader_image_load_store: add format-layout-with-non-image-type.frag compiler test

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 26.04.2017 18:28, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../format-layout-with-non-image-type.frag | 24 ++ 1 file changed, 24 insertions(+) create

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

Hi Plamena, On 24.04.2017 23:04, Manolova, Plamena wrote: [snip] + static const char *fs_text = + "#version 430\n" + "#extension GL_ARB_fragment_shader_interlock: require\n" +

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

On 19.04.2017 02:58, Plamena Manolova wrote: A test to check whether GL_ARB_fragment_shader_interlock operates as expected. This test simulates blending behaviour by using image loads/stores to a 3D texture. The bledning formula used is: Type: blending result = current_alpha * current_color

Re: [Piglit] [PATCH] arb_enhanced_layouts: Remove unused variable.

; ^ Fixes: b81ecc9d3c68 ("arb_enhanced_layouts: add test for location aliasing across GS vertex streams") Signed-off-by: Vinson Lee <v...@freedesktop.org> Thanks, and sorry for the noise. Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/spec/arb_enhanced_layo

[Piglit] [PATCH v2 3/5] arb_sparse_buffer: add basic rendering test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> v2: also add a test where the vbuf is stored outside the committed region Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> (v1) --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMake

[Piglit] [PATCH v2 2/5] arb_sparse_buffer: minmax test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> --- tests/all.py | 5 +++ tests/spec/CMakeLists.txt | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 12 ++

[Piglit] [PATCH v2 1/5] util: add MIN3/MAX3 convenience macros

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/util/piglit-util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-util.h b/tests/util/piglit-util.h index 7e9c840..b30ae07 100644 --- a/tests/util/piglit-util.h +++ b/tests/util/piglit-util.h @@ -176,20 +

[Piglit] [PATCH v2 5/5] arb_sparse_buffer: add tests for various *BufferSubData commands

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 1 + tests/spec/arb_sparse_buffer/buffer-data.c | 593 + 3 files changed, 595 insertions(+) creat

[Piglit] [PATCH v2 0/5] ARB_sparse_buffer tests (less rudimentary version)

Hi all, some more additions to the sparse buffer tests I posted some time ago. This allows you to stress the commit/uncommit logic and buffer ops. Cheers, Nicolai ___ Piglit mailing list Piglit@lists.freedesktop.org

[Piglit] [PATCH v2 4/5] arb_sparse_buffer: add an extended commit test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Test sequences of commit / uncommit. Verify that the committed pages are there and retain their data using ClearNamedBufferData and GetBufferSubData. --- tests/all.py | 1 + tests/spec/arb_sparse_

Re: [Piglit] [PATCH] gl-1.4: test some glMultiDrawArrays error conditions

I added some spec quotes before pushing, thanks for taking a look! Cheers, Nicolai On 14.04.2017 10:33, Samuel Pitoiset wrote: On 04/13/2017 09:38 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 1 + test

[Piglit] [PATCH] gl-1.4: test some glMultiDrawArrays error conditions

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 1 + tests/spec/gl-1.4/CMakeLists.gl.txt| 1 + tests/spec/gl-1.4/multidrawarrays-errors.c | 114 + 3 files changed, 116 insertions(+) create mode 100644

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

Thanks, Dorian 2017-04-05 15:58 GMT+02:00 Nicolai Hähnle <nhaeh...@gmail.com <mailto:nhaeh...@gmail.com>>: On 05.04.2017 09:55, Dorian Apanel wrote: From: Dorian Apanel <dorian.apanel+pig...@gmail.com <mailto:dorian.apanel%2bpig...@gmail.com

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

On 05.04.2017 09:55, Dorian Apanel wrote: From: Dorian Apanel Textures created by image load/store tests are not complete (max level defaults to 1000). Load/Store on incomplete textures should return zeros/change nothing. This fix sets proper base and max level

Re: [Piglit] [PATCH] arb_texture_buffer_range: test glTexBufferRange() with wrong target

On 04.04.2017 14:50, Samuel Pitoiset wrote: From OpenGL 4.5 spec, section 8.9 Buffer Textures: "An INVALID_ENUM error is generated if the effective target is not TEXTURE_BUFFER." Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Reviewed-by: Nicolai Hähn

Re: [Piglit] [PATCH] glslparsertest: Add test case for FDO bug #100438.

On 01.04.2017 01:25, Vinson Lee wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100438 Signed-off-by: Vinson Lee <v...@freedesktop.org> Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/glslparsertest/glsl2/fdo100438.frag | 10 ++ 1 file

Re: [Piglit] [PATCH] arb_cull_distance: Fix sometimes-uninitialized warnings.

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 01.04.2017 01:27, Vinson Lee wrote: exceed-limits.c:75:6: warning: variable 'clip_distances' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (strcmp(argv[1], "

[Piglit] [PATCH 5/6] arb_shader_ballot: test ballotARB inside if/else control flow

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../execution/fs-ballot-if-else.shader_test| 83 ++ 1 file changed, 83 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-ballot-if-else.shader_test diff --git a/test

[Piglit] [PATCH 6/6] arb_shader_ballot: test peeling away the first invocation

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../fs-readFirstInvocation-uint-if.shader_test | 32 ++ .../fs-readFirstInvocation-uint-loop.shader_test | 49 ++ 2 files changed, 81 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/exe

[Piglit] [PATCH 2/6] arb_shader_ballot: add readInvocationARB tests

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../fs-readInvocation-uint-uniform.shader_test | 39 ++ .../execution/fs-readInvocation-uint.shader_test | 37 2 files changed, 76 insertions(+) create mode 100644 tests/spec/arb_shader_

[Piglit] [PATCH 0/6] ARB_shader_ballot tests

Hi, this series adds some basic tests for the builtin functions and variables of the ARB_shader_ballot extension. I have only tested this against my own work-in-progress implementation. If somebody got to test it against the AMD or Nvidia blobs, that would be much appreciated. Please review!

[Piglit] [PATCH 3/6] arb_shader_ballot: add readFirstInvocationARB test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- ...fs-readFirstInvocation-uint-uniform.shader_test | 39 .../fs-readFirstInvocation-uint.shader_test| 52 ++ 2 files changed, 91 insertions(+) create mode 100644 tests/spec/arb_shader_

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

On 30.03.2017 15:03, Ilia Mirkin wrote: On Thu, Mar 30, 2017 at 8:19 AM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: On 30.03.2017 14:07, Ilia Mirkin wrote: Time could roll over... not sure what to do about that though. Maybe check if the top 2 bits are set in the old value and are

Re: [Piglit] [PATCH] glsl: update assumption in array out of bounds test

On 31.03.2017 01:53, Timothy Arceri wrote: Section 5.7 of the GLSL 4.5 spec says: "Behavior is undefined if a shader subscripts an array with an index less than 0 or greater than or equal to the size the array was declared with." So we cannot be sure which path the shader will take.

[Piglit] [PATCH] arb_gpu_shader_int64: add bit-shift tests

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Exposes a bug in st/glsl_to_tgsi. --- .../fs-shift-scalar-by-scalar.shader_test | 78 ++ .../fs-shift-vector-by-scalar.shader_test | 77 + .../fs-shift-vector-by-vector.shade

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

res in these tests...] Shouldn't roll-over be covered by the cast to int followed by comparison with 0? Cheers, Nicolai On Thu, Mar 30, 2017 at 3:23 AM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../arb_shader_clock/execution/cl

[Piglit] [PATCH] arb_shader_clock: add basic execution tests

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../arb_shader_clock/execution/clock.shader_test | 54 +++ .../execution/clock2x32.shader_test| 63 ++ 2 files changed, 117 insertions(+) create mode 100644 tests/spec/arb_shader

Re: [Piglit] [RFC PATCH 0/5] Add tests for ARB_bindless_texture

On 28.03.2017 00:05, Samuel Pitoiset wrote: Hi, This series introduces some tests for ARB_bindless_texture. The series has been splitted into 4 different parts to try to help reviewers because it's a bunch of new code. Although this seems huge at first look, I don't cover 100% of the spec but

Re: [Piglit] [RFC PATCH 3/5] arb_bindless_texture: add compiler-related tests

On 29.03.2017 01:09, Samuel Pitoiset wrote: diff --git a/tests/spec/arb_bindless_texture/compiler/images/indexing.vert b/tests/spec/arb_bindless_texture/compiler/images/indexing.vert new file mode 100644 index 0..dd865b22f --- /dev/null +++

[Piglit] [PATCH] get-active-attrib-array: allocate a sufficiently large buffer

From: Nicolai Hähnle <nicolai.haeh...@amd.com> Found by ASAN. --- tests/spec/glsl-1.50/execution/get-active-attrib-array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/glsl-1.50/execution/get-active-attrib-array.c b/tests/spec/glsl-1.50/execution/get-

Re: [Piglit] [PATCH] draw-elements: test glMultiDrawElements(GL_UNSIGNED_BYTE)

Thanks for doing this. Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> On 17.02.2017 13:08, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> this was broken in radeonsi --- tests/general/draw-elements.c | 34 +++--- 1 file changed, 3

Re: [Piglit] [PATCH] glsl-shaders: test correct shader source is use on cache fallback

ts/shaders/glsl-cache-fallback-shader-source.c b/tests/shaders/glsl-cache-fallback-shader-source.c new file mode 100644 index 000..f764617 --- /dev/null +++ b/tests/shaders/glsl-cache-fallback-shader-source.c @@ -0,0 +1,187 @@ +/* + * Copyright (c) 2009 Nicolai Hähnle I suspect your copy

[Piglit] [PATCH 1/2] arb_sparse_buffer: minmax test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 5 +++ tests/spec/CMakeLists.txt | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 12 ++ tests/spec/arb_sparse_buffer/CMakeLists.txt| 1 + test

[Piglit] [PATCH 2/2] arb_sparse_buffer: add basic rendering test

From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 1 + tests/spec/arb_sparse_buffer/basic.c | 190 + 3 files changed, 192 insertions(+) creat

[Piglit] [PATCH 0/2] Very rudimentary ARB_sparse_buffer tests

The GLCTS has tests for the extension as well, but perhaps other people also find simple tests like this one easier to work with... Cheers, Nicolai ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

On 05.02.2017 20:28, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> this happened to me once Thanks, I vaguely remember seeing something like this as well. Both patches: Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> ... though you might want to wait

Re: [Piglit] [PATCH] arb_gpu_shader_int64: allow shift tests to be generated

On 04.02.2017 22:10, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> Looks reasonable. Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- generated_tests/builtin_function.py | 24 +++- 1 file changed, 19 insertions(+), 5 deleti

  1   2   3   >