Re: [Piglit] [PATCH 0/2] shader_runner: fix gles3 glMapBuffer workaround

Verified access bitfield values from spec, series: Reviewed-by: Tapani Pälli On 4/11/19 12:14 PM, Alejandro Piñeiro wrote: Alejandro Piñeiro (2): shader_runner: fix error checking on MapBuffer gles workaround shader_runner: get proper access bitfield when calling MapBufferRange

Re: [Piglit] [PATCH] glsl-1.10: test unreachable code in a loop is not accessed

Reviewed-by: Tapani Pälli On 3/21/19 3:38 AM, Timothy Arceri wrote: --- .../vs-loop-with-dead-code-unroll.shader_test | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-with-dead-code-unroll.shader_test diff --git

[Piglit] [PATCH] arb_shading_language_420pack: test invalid function return type

Extension adds implicit conversion for return types. This test checks that driver does not incorrectly allow invalid return type. Signed-off-by: Tapani Pälli --- .../implicit-conversion-invalid-type.frag | 21 +++ 1 file changed, 21 insertions(+) create mode 100644 tests

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add support for XYUV format

FYI I've pushed this test to master. On 2/18/19 9:35 AM, Tapani Pälli wrote: Reviewed-by: Tapani Pälli On 2/16/19 3:43 AM, Vivek Kasireddy wrote: This format is similar to AYUV except that the alpha channel is ignored. Cc: Tapani Palli Cc: Lionel Landwerlin Signed-off-by: Vivek Kasireddy

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add support for XYUV format

Reviewed-by: Tapani Pälli On 2/16/19 3:43 AM, Vivek Kasireddy wrote: This format is similar to AYUV except that the alpha channel is ignored. Cc: Tapani Palli Cc: Lionel Landwerlin Signed-off-by: Vivek Kasireddy --- tests/opengl.py | 2 ++ tests/spec

Re: [Piglit] [PATCH 1/2] util: make it easier to use probe functions on ES

Reviewed-by: Tapani Pälli On 2/13/19 5:40 AM, Ilia Mirkin wrote: With float color buffers, one can use glReadPixels with GL_FLOAT. Allow that usage scenario. Signed-off-by: Ilia Mirkin --- tests/util/piglit-util-gl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH 2/2] ext_color_buffer_float: check fp32 blend enforcement

On 2/13/19 9:15 AM, Tapani Pälli wrote: On 2/13/19 5:40 AM, Ilia Mirkin wrote: Without EXT_float_blend, fp32 blending should be disallowed. Ensure that this is the case. If it is supported, ensure that blending works as expected. Signed-off-by: Ilia Mirkin ---   tests/opengl.py

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add P12, P16 format support

v2: fix indentation and add /* Y */ comment to P16 Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c | 28 +++ .../piglit-framework-gl

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add P12, P16 format support

Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c | 27 +++ .../piglit-framework-gl/piglit_drm_dma_buf.c | 4 +++ .../piglit-framework-gl

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: test alpha channel for AYUV format

Patches changes expected result to have a alpha ramp in case format supports alpha, each alpha supporting format should make sure data matches this expectation. Signed-off-by: Tapani Pälli --- .../ext_image_dma_buf_import/sample_yuv.c | 60 --- 1 file changed, 39 insertions

Re: [Piglit] [PATCH 2/2] ext_color_buffer_float: check fp32 blend enforcement

On 2/13/19 5:40 AM, Ilia Mirkin wrote: Without EXT_float_blend, fp32 blending should be disallowed. Ensure that this is the case. If it is supported, ensure that blending works as expected. Signed-off-by: Ilia Mirkin --- tests/opengl.py | 5 +

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add P10 format support

v2: use correct range for P10 Signed-off-by: Tapani Pälli Signed-off-by: Harish Krupo --- tests/opengl.py| 2 ++ .../spec/ext_image_dma_buf_import/sample_common.c | 1 + .../spec/ext_image_dma_buf_import/sample_common.h | 1 + tests/spec

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add P10 format support

Signed-off-by: Tapani Pälli Signed-off-by: Harish Krupo --- I also made MR of this but only then realized MR's are not used with Piglit just yet! tests/opengl.py| 2 ++ .../spec/ext_image_dma_buf_import/sample_common.c | 1 + .../spec

Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

ith 2D tex. Signed-off-by: Aditya Swarup Cc: Tapani Pälli Cc: Kenneth Graunke --- This test case covers the scenario of binding a texture ID of type GL_TEXTURE_EXTERNAL with EGLImage created using 2D texture. This test is not covered in deqp but in CTS SKQP test - CtsSkQPTestCases "#unitTe

Re: [Piglit] [PATCH 0/4] summary/html: html fixes

On 1/22/19 12:42 PM, Erik Faye-Lund wrote: On Tue, 2019-01-22 at 10:46 +0100, Erik Faye-Lund wrote: On Tue, 2019-01-22 at 08:00 +0200, Tapani Pälli wrote: On 1/21/19 10:44 PM, Ilia Mirkin wrote: Series is Reviewed-by: Ilia Mirkin As an aside, it appears that we're using xhtml? That's

Re: [Piglit] [PATCH v2 1/2] test: fix core dump for depthstencil-render-miplevels

seems included as +1 to max_miplevel Alternatively I guess one could change those loops to not exceed max level, use < operator instead of <= (?) If no more any objections - will update to '<' No worries, I'm OK with using this patch too. On Tue, Jan 15, 2019 at 3:07 PM Tap

Re: [Piglit] [PATCH v2 1/2] test: fix core dump for depthstencil-render-miplevels

On 1/14/19 12:51 PM, Sergii Romantsov wrote: Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes core dump on exit. Fixed: array of pointers is allocated to size max_miplevel, but used as max_miplevel + 1. Yep, it seems valgrind outputs bunch of invalid reads and writes with this

Re: [Piglit] [PATCH 1/3] cmake: use proper WAYLAND_INCLUDE_DIRS variable

in ${WAYLAND_INCLUDE_DIRS} variable (when printing using message during cmake), I'm testing this on Fedora. On the other hand it seems ${WAYLAND_wayland-client_INCLUDEDIR} is empty as well so I guess this is just because the pc file points to the default include path? Acked-by: Tapani Pälli Ross

Re: [Piglit] Piglit website in sphinx

On 12/18/18 9:58 AM, Jordan Justen wrote: On 2018-12-17 22:07:21, Tapani Pälli wrote: Hi; On 12/17/18 11:50 AM, Jordan Justen wrote: Although I doubt it generates much traffic, I wanted to try to convert the https://piglit.freedesktop.org/ homepage into an 'auto-building' gitlab branch. I

Re: [Piglit] Piglit website in sphinx

Hi; On 12/17/18 11:50 AM, Jordan Justen wrote: Although I doubt it generates much traffic, I wanted to try to convert the https://piglit.freedesktop.org/ homepage into an 'auto-building' gitlab branch. I think the current site was built by ikiwiki, but I was after spending way more time that I

Re: [Piglit] [PATCH 1/2] EGL_EXT_image_dma_buf_import: drop alpha-one to sample yuv tests

Reviewed-by: Tapani Pälli On 11/13/18 4:40 PM, Lionel Landwerlin wrote: This option only applies to the sample_rgb tests. Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index

Re: [Piglit] [PATCH] program_interface_query: don't expect a valid location for TCS output

e extension are quite complicated. However, I'm convinced now and this LGTM :) Reviewed-by: Tapani Pälli Also I fixed some conflicting comments. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108612 Signed-off-by: Andrii Simiklit --- .../getprogramresourceiv.c |

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add AYUV format support

It would be indeed nice to test the alpha channel too, especially if we enable XYUV too but it can be added later ... with Eric's comment addressed; Reviewed-by: Tapani Pälli On 11/9/18 7:27 PM, Lionel Landwerlin wrote: v2: Forgot to add the new test to opengl.py Drop some code to deal

Re: [Piglit] [PATCH] khr_debug: fix invalid enum usage on gles3

Reviewed-by: Tapani Pälli On 11/8/18 12:09 PM, Erik Faye-Lund wrote: GL_SAMPLES_PASSED isn't allowed on gles3, so doing a quiery with it isn't going to work. But GL_ANY_SAMPLES_PASSED is allowed, so so let's use that one instead on gles. Signed-off-by: Erik Faye-Lund --- This bug came up

Re: [Piglit] [PATCH 1/1] tests: enable test case egl-context-priority on all egl platforms

Reviewed-by: Tapani Pälli On 10/29/18 7:01 PM, James Xiong wrote: From: "Xiong, James" Signed-off-by: Xiong, James --- tests/egl/egl-context-priority.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/egl/egl-context-priority.c b/tests/egl/e

Re: [Piglit] [PATCH 0/7] New preemption test.

On 10/9/18 8:49 PM, Rafael Antognolli wrote: On Tue, Oct 09, 2018 at 12:59:00PM +0300, Tapani Pälli wrote: Hi Rafael; This looks very much along the lines of what thoughts I had when writing this test: https://patchwork.freedesktop.org/patch/156779/ Oh, I think I missed that, otherwise I

Re: [Piglit] [PATCH 3/7] egl-context-preemption: Add a high priority thread/context.

On 10/4/18 6:35 PM, Rafael Antognolli wrote: Start a new thread right after dispatching the render commands from the main thread, after glFlush(). This second thread creates a high priority EGL context, and uses it to render to a frame buffer multiple times. These draw calls are supposed to

Re: [Piglit] [PATCH 2/7] egl-context-preemption: Add check for high priority contexts.

On 10/4/18 6:35 PM, Rafael Antognolli wrote: Check if we can create high priority contexts, otherwise just fail the test immediately. There's no reason to test for preemption if we can't create high priority contexts. --- tests/egl/egl-context-preemption.c | 57 ++

Re: [Piglit] [PATCH 0/7] New preemption test.

Hi Rafael; This looks very much along the lines of what thoughts I had when writing this test: https://patchwork.freedesktop.org/patch/156779/ I think I may have somewhere a GL_TIMESTAMP version attempt about that one :) but your test looks much more complete, thanks for doing this! On

Re: [Piglit] [PATCH 1/2] tests: Split out ASTC formats into a header

Hi; I'm not really familiar with single color block ("void extent") encoding but the test looks good to me! Series is: Reviewed-by: Tapani Pälli On 10/3/18 2:39 AM, Nanley Chery wrote: This array will be reused in the next patch. --- .../khr_texture_compression_astc/common.

Re: [Piglit] [PATCH] gles-3.0: test for vertex attribute aliasing

considered aliasing. On 9/25/18 9:13 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833 --- tests/opengl.py | 1 + tests/spec/gles-3.0/CMakeLists.gles3.txt | 1 + tests/spec/gles-3.0/attribute-alias

Re: [Piglit] [PATCH] glsl-sdl-sincos-accuracy: Add a new test for a vc4 bug with SDL2.

One small nit below, otherwise LGTM Reviewed-by: Tapani Pälli On 9/22/18 3:23 AM, Eric Anholt wrote: Our sin(0.0) and cos(0.0) were too inaccurate, causing twisting in SDL2's rendering. --- .../glsl-sdl-sincos-accuracy.shader_test | 36 +++ 1 file changed, 36

[Piglit] [PATCH] gles-3.0: test for vertex attribute aliasing

Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833 --- tests/opengl.py | 1 + tests/spec/gles-3.0/CMakeLists.gles3.txt | 1 + tests/spec/gles-3.0/attribute-aliasing.c | 91 3 files changed, 93 insertions

[Piglit] [PATCH] glsl-1.10: test some arithmetic on non-existing struct member

Signed-off-by: Tapani Pälli https://bugs.freedesktop.org/show_bug.cgi?id=108012 --- ...rithmetic-on-non-existing-struct-member.vert | 17 + 1 file changed, 17 insertions(+) create mode 100644 tests/spec/glsl-1.10/compiler/struct/arithmetic-on-non-existing-struct-member.vert

Re: [Piglit] [PATCH] ext_render_snorm-render: change verify_contents to use base_format size

On 08/29/2018 02:44 PM, Ilia Mirkin wrote: On Wed, Aug 29, 2018 at 3:33 AM, Tapani Pälli wrote: OpenGL ES 3.1 specification lists valid combinations for format, type and internalformat for transfer of pixel rectangles. This change follows the table 8.4 in spec so that we use exact same

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

On 08/29/2018 08:57 PM, Nanley Chery wrote: On Wed, Aug 29, 2018 at 10:15:41AM +0300, Tapani Pälli wrote: On 29.08.2018 00:23, Nanley Chery wrote: On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: Test assumed that we can read back directly from R8, RG8 fbo

[Piglit] [PATCH] ext_render_snorm-render: change verify_contents to use base_format size

OpenGL ES 3.1 specification lists valid combinations for format, type and internalformat for transfer of pixel rectangles. This change follows the table 8.4 in spec so that we use exact same number of components for format as is expected from corresponding internalformat. Signed-off-by: Tapani

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

On 29.08.2018 00:23, Nanley Chery wrote: On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: Test assumed that we can read back directly from R8, RG8 fbo but this is not actually enabled by the extension. Patch introduces additional read from window to sanity check fbo contents

[Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

Test assumed that we can read back directly from R8, RG8 fbo but this is not actually enabled by the extension. Patch introduces additional read from window to sanity check fbo contents. Signed-off-by: Tapani Pälli --- tests/spec/ext_render_snorm/render.c | 32

Re: [Piglit] [PATCH v2] ext_render_snorm-render: test for GL_EXT_render_snorm

On 08/15/2018 08:00 PM, Nanley Chery wrote: On Wed, Aug 15, 2018 at 02:26:27PM +0300, Tapani Pälli wrote: Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from This test includes only GL_BYTE based formats. R16_SNORM

[Piglit] [PATCH v2] ext_render_snorm-render: test for GL_EXT_render_snorm

-off-by: Tapani Pälli --- tests/opengl.py | 5 + tests/spec/CMakeLists.txt| 1 + tests/spec/ext_render_snorm/CMakeLists.gles2.txt | 7 + tests/spec/ext_render_snorm/CMakeLists.txt | 1 + tests/spec/ext_render_snorm/render.c

Re: [Piglit] [PATCH] glsl-1.10: add a 'invalid-array-as-function-param' glslparsertest

On 14.08.2018 23:07, Ian Romanick wrote: On 08/14/2018 12:41 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 --- .../spec/glsl-1.10/compiler/invalid-array-as-function-param.vert | 9 + 1 file changed, 9 insertions

[Piglit] [PATCH] glsl-1.10: add a 'invalid-array-as-function-param' glslparsertest

Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 --- .../spec/glsl-1.10/compiler/invalid-array-as-function-param.vert | 9 + 1 file changed, 9 insertions(+) create mode 100644 tests/spec/glsl-1.10/compiler/invalid-array-as-function-param.vert

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

On 08/13/2018 07:59 PM, Nanley Chery wrote: On Mon, Aug 13, 2018 at 02:59:39PM +0300, Tapani Pälli wrote: On 08/13/2018 01:31 PM, Tapani Pälli wrote: On 08/11/2018 01:12 AM, Nanley Chery wrote: On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: Test includes:     - texture

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

On 08/13/2018 01:31 PM, Tapani Pälli wrote: On 08/11/2018 01:12 AM, Nanley Chery wrote: On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: Test includes:     - texture uploads     - mipmap generation     - framebuffer creation     - rendering to     - reading from

Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

On 08/11/2018 01:12 AM, Nanley Chery wrote: On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote: Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image I don't see any

Re: [Piglit] [PATCH] shaders: add a glslparsertest for bug 98699

st reading the bug and trying to come up with something). Otherwise this test looks good, so with the rename: Reviewed-by: Dylan Baker Quoting Tapani Pälli (2018-08-09 23:12:44) Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98699 ---   tests/shaders/gls

[Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm

-off-by: Tapani Pälli --- tests/opengl.py | 5 + tests/spec/CMakeLists.txt| 1 + tests/spec/ext_render_snorm/CMakeLists.gles2.txt | 7 + tests/spec/ext_render_snorm/CMakeLists.txt | 1 + tests/spec/ext_render_snorm/render.c

[Piglit] [PATCH] ext_texture_norm16-render: read SNORM formats if EXT_render_snorm

This was missed from commit a440e4390. Signed-off-by: Tapani Pälli --- tests/spec/ext_texture_norm16/render.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/spec/ext_texture_norm16/render.c b/tests/spec/ext_texture_norm16/render.c index 46cc7c91b..08a84501c

[Piglit] [PATCH] ext_texture_norm16-render: add more API coverage

Add tests for glRenderbufferStorage and glCopyTexImage2D. Signed-off-by: Tapani Pälli --- tests/spec/ext_texture_norm16/render.c | 53 -- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/tests/spec/ext_texture_norm16/render.c b/tests/spec

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

On 06/27/2018 02:43 PM, Timothy Arceri wrote: --- V2: Fix some spelling typos and the commit description ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644

[Piglit] [PATCH] tests/opengl.py: add couple missing arb_get_program_binary tests

Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py index 2592fa404..cafda2576 100644 --- a/tests/opengl.py +++ b/tests/opengl.py @@ -1687,6 +1687,10 @@ with profile.test_list.group_manager

[Piglit] [PATCH] ARB_get_program_binary: Test that XFB varying info works on program reload

Signed-off-by: Tapani Pälli --- .../spec/arb_get_program_binary/CMakeLists.gl.txt | 1 + tests/spec/arb_get_program_binary/xfb-varyings.c | 126 + 2 files changed, 127 insertions(+) create mode 100644 tests/spec/arb_get_program_binary/xfb-varyings.c diff --git a/tests

[Piglit] [PATCH v2] ext_texture_norm16-render: support EXT_render_snorm interactions

v2: EXT_render_snorm does not add new formats for glTexBuffer, add separate flag to indicate glTexBuffer support (separate from req_render that matched before) Signed-off-by: Tapani Pälli --- tests/spec/ext_texture_norm16/render.c | 39 ++ 1 file changed

Re: [Piglit] [PATCH] util: Silence GCC unused-function warning.

his change (or 77a4b73436c0) interacts with building GLES 1.x tests... if at all. It should not affect as those tests are not using the 'probe_texel' functions (using probe_pixel instead). It should be fine to go with this: Reviewed-by: Tapani Pälli static GLuint create_fbo_from_text

[Piglit] [PATCH] ext_texture_norm16-render: support EXT_render_snorm interactions

Signed-off-by: Tapani Pälli --- tests/spec/ext_texture_norm16/render.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/spec/ext_texture_norm16/render.c b/tests/spec/ext_texture_norm16/render.c index 32f601ad0..14299569a 100644 --- a/tests/spec

[Piglit] [PATCH v3] util: provide way to read a texture in ES compatible way

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/util/piglit-util-gl.c | 131 ++-- 1 file changed, 125 insertions(+), 6 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 2443be03e..76ee0d0a0

Re: [Piglit] [PATCH v2] util: provide way to read a texture in ES compatible way

On 21.05.2018 18:01, Brian Paul wrote: On 05/21/2018 05:53 AM, Tapani Pälli wrote: Implementation supports GL_TEXTURE_2D, GL_TEXTURE_2D_ARRAY and affects following functions:     - piglit_probe_texel_rect_rgba     - piglit_probe_texel_volume_rgba v2: use read_texture only on GL ES fix

[Piglit] [PATCH v2] util: provide way to read a texture in ES compatible way

Implementation supports GL_TEXTURE_2D, GL_TEXTURE_2D_ARRAY and affects following functions: - piglit_probe_texel_rect_rgba - piglit_probe_texel_volume_rgba v2: use read_texture only on GL ES fix indentation issues Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- test

Re: [Piglit] [PATCH 1/2] util: provide way to read a texture in ES compatible way

Any comments? I'm planning to push this in soon to be able to push oes_texture_view changes to Mesa. On 05/11/2018 01:17 PM, Tapani Pälli wrote: Implementation supports GL_TEXTURE_2D, GL_TEXTURE_2D_ARRAY and affects following functions: - piglit_probe_texel_rect_rgba

Re: [Piglit] [PATCH] util: add includes when building for Wayland

systems because the header is found from default include path (/usr/include) but in case of Tumbleweed it seems '/usr/include/wayland'. Change looks good to me! Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106477 Sign

[Piglit] [PATCH 1/2] util: provide way to read a texture in ES compatible way

Implementation supports GL_TEXTURE_2D, GL_TEXTURE_2D_ARRAY and affects following functions: - piglit_probe_texel_rect_rgba - piglit_probe_texel_volume_rgba Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/util/piglit-util-gl.c

[Piglit] [PATCH 2/2] arb_texture_view: convert some more tests to run on ES 3.1

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/spec/arb_texture_view/CMakeLists.gles3.txt | 6 ++ tests/spec/arb_texture_view/clear-into-view-2d-array.c | 5 + tests/spec/arb_texture_view/clear-into-view-2d.c | 5 + tests/spec/arb_texture_view/clear-int

[Piglit] [PATCH] ext_texture_norm16-render: refactor subtest execution

Patch moves subtest execution in a separate function that returns total result for each format, this fixes issues in test with current pass/fail reporting. Also remove reporting from verify_contents_float, this caused duplicate subtest result reporting. Signed-off-by: Tapani Pälli <tapani

Re: [Piglit] [PATCH v2] ext_texture_norm16-render: test for GL_EXT_texture_norm16

On 02.05.2018 21:29, Eric Anholt wrote: Tapani Pälli <tapani.pa...@intel.com> writes: Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image v2: code cleanup Sign

[Piglit] [PATCH v3] ext_texture_norm16-render: test for GL_EXT_texture_norm16

Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image - interaction with GL_OES_texture_buffer v2: code cleanup v3: add a subtest for TBOs Signed-off-by: Tapani Pälli <tapani

[Piglit] [PATCH v2] ext_texture_norm16-render: test for GL_EXT_texture_norm16

Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image v2: code cleanup Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/all.py

[Piglit] [PATCH] ext_texture_norm16-render: test for GL_EXT_texture_norm16

Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/all.py | 5 + test

Re: [Piglit] [PATCH] tests: intel_blackhole_render: use GLSL ES 1.0 on ES profiles

One nit that you can consider below .. Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 09.04.2018 14:00, Lionel Landwerlin wrote: Not all of our platforms support GLSL ES 3.0 so extend the coverage by lowering the GLSL requirements. Signed-off-by: Lionel Landwerlin <lionel.

Re: [Piglit] [PATCH] add new indexing test with dynamic indexing of integer vector

On 04/03/2018 12:03 PM, Alejandro Piñeiro wrote: On 03/04/18 09:01, Tapani Pälli wrote: Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105438 --- tests/shaders/glsl-fs-vec4-indexing-8.shader_test | 24 +

[Piglit] [PATCH] add new indexing test with dynamic indexing of integer vector

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105438 --- tests/shaders/glsl-fs-vec4-indexing-8.shader_test | 24 +++ 1 file changed, 24 insertions(+) create mode 100644 tests/shaders/glsl-fs-vec4-inde

Re: [Piglit] [PATCH] func.sync.semaphore-fd: put _EXT in priority enums

On 02/28/2018 11:41 PM, Jason Ekstrand wrote: I just pushed an equivalent of this.  Also, I pushed a patch to add Vulkan headers to crucible so that it builds off the latest and not off whatever's on your system. Thanks Jason! On Wed, Feb 28, 2018 at 10:28 AM, Tapani Pälli <tapani

Re: [Piglit] [PATCH] func.sync.semaphore-fd: put _EXT in priority enums

On 28.02.2018 20:26, Tapani Pälli wrote: Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- Mark, this should fix Crucible for you. I don't understand why headers shipped by Fedora (version 65) do not have _EXT in these enums (?) and this meaning vulkan header version 65, not

[Piglit] [PATCH] func.sync.semaphore-fd: put _EXT in priority enums

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- Mark, this should fix Crucible for you. I don't understand why headers shipped by Fedora (version 65) do not have _EXT in these enums (?) src/tests/func/sync/semaphore-fd.c | 14 +++--- 1 file changed, 7 insertions(+), 7 del

Re: [Piglit] [PATCH 2/3] func.sync.semaphore-fd: use queue priorities if supported

On 27.02.2018 23:59, Jason Ekstrand wrote: On Tue, Feb 27, 2018 at 12:10 AM, Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> wrote: Patch adds VK_EXT_global_priority support. This should not affect test results. Signed-off-by: Tapani Päll

[Piglit] [PATCH 1/3] framework: add helper for checking extension existence

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- include/tapi/t_result.h | 1 + src/framework/test/t_result.c | 16 +++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/include/tapi/t_result.h b/include/tapi/t_result.h index 71bc980..7a4a898

[Piglit] [PATCH 2/3] func.sync.semaphore-fd: use queue priorities if supported

Patch adds VK_EXT_global_priority support. This should not affect test results. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/tests/func/sync/semaphore-fd.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/tests/func/sync/sem

[Piglit] [PATCH 3/3] func.sync.semaphore-fd: new opaque-fd-no-sync test

Patch adds a new test that is expected to fail, new option and some minor refactor done to check_memory_contents to allow this. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/tests/func/sync/semaphore-fd.c | 105 +++-- 1 file changed, 101 inse

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

On 01/25/2018 07:28 PM, Emil Velikov wrote: On 21 December 2017 at 09:26, Tapani Pälli <tapani.pa...@intel.com> wrote: On 12/18/2017 04:37 PM, Emil Velikov wrote: On 13 December 2017 at 12:54, Tapani Pälli <tapani.pa...@intel.com> wrote: The test doesn't care how well eg

Re: [Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

On 25.01.2018 10:47, Tapani Pälli wrote: On 25.01.2018 10:27, Tapani Pälli wrote: On 25.01.2018 07:27, Jason Ekstrand wrote: On Wed, Jan 24, 2018 at 6:53 AM, Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> wrote:     This fixes test for me after

Re: [Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

On 25.01.2018 10:27, Tapani Pälli wrote: On 25.01.2018 07:27, Jason Ekstrand wrote: On Wed, Jan 24, 2018 at 6:53 AM, Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> wrote:     This fixes test for me after Mesa commit 1f79d986af which will     make d

Re: [Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

On 25.01.2018 07:27, Jason Ekstrand wrote: On Wed, Jan 24, 2018 at 6:53 AM, Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> wrote: This fixes test for me after Mesa commit 1f79d986af which will make device expose entrypoints only for enable

[Piglit] [PATCH] require VK_KHR_external_semaphore_fd in func.sync.semaphore-fd.sync-fd

This fixes test for me after Mesa commit 1f79d986af which will make device expose entrypoints only for enabled extensions. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/tests/func/sync/semaphore-fd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/tests/fun

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

On 12/18/2017 04:37 PM, Emil Velikov wrote: On 13 December 2017 at 12:54, Tapani Pälli <tapani.pa...@intel.com> wrote: The test doesn't care how well eglCopyBuffers itself works - aim it to illustrate the buggy validation in Mesa. Hence the wait + pixmap readback are not really

[Piglit] [PATCH] egl: API test for EGL_ANDROID_blob_cache extension

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- I had here also shader compilation, and checks that get and set were called when same same shader was compiled and linked again but I'm not sure if that can be required from the driver, driver might just skip cache if it wants. So,

Re: [Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

Patches 1,2,3,4 Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 11.12.2017 22:15, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> A couple of tests were calling eglBindAPI before eglInitialize. Some versions of Mesa had problem with such invo

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

On 13.12.2017 14:22, Emil Velikov wrote: Hi Tapani, Thanks for having a look! On 13 December 2017 at 06:10, Tapani Pälli <tapani.pa...@intel.com> wrote: Hi; On 11.12.2017 22:15, Emil Velikov wrote: + /* Set the env. variable to force the platform 'detection'

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

Hi; On 11.12.2017 22:15, Emil Velikov wrote: From: Emil Velikov Current Mesa implementation was overly cautious, flagging an error where it shouldn't - patch for Mesa is on the list. See the test for details. Cc: Ian Romanick

Re: [Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

On 12/12/2017 10:23 AM, Tapani Pälli wrote: On 12/11/2017 10:15 PM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> A couple of tests were calling eglBindAPI before eglInitialize. Some versions of Mesa had problem with such invocation order and the seeming con

Re: [Piglit] [PATCH] egl_khr_fence_sync: don't require ES3 support

On 12/02/2017 03:06 AM, Stefan Schake wrote: Bits in EGL_RENDERABLE_TYPE act as ANDs. Since we only create ES2 contexts, we can drop the requirement for ES3 context support. Yes, ES3 is not needed. Actually the whole config_attribs is useless. My suggestion is to just remove the whole thing

Re: [Piglit] [PATCH] crucible: fix m32 build errors due to formatting for uint64 and size_t

Thanks for fixing this; Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 12/07/2017 04:49 AM, Clayton Craft wrote: This fixes compile errors when building crucible for m32 targets, mainly that %lu means something different on m32 than it does on m64. Bugzilla:

[Piglit] [PATCH] all.py: add entry for ext_occlusion_query_boolean

commit 68a003409 forgot to add this Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/all.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/all.py b/tests/all.py index c4cbe0bd9..ab1bed0f9 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3172,6 +3

Re: [Piglit] [PATCH v2] ext_disjoint_timer_query-simple: basic API test

On 12/08/2017 11:30 PM, Eric Anholt wrote: Tapani Pälli <tapani.pa...@intel.com> writes: v2: cleanup code, remove some GL_NO_ERROR checks add to all.py (Eric) Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> diff --git a/tests/all.py b/tests/all.py index 0c99bff0

Re: [Piglit] [PATCH] tests/egl/egl-context-priority.c: Use piglit_egl_get_default_display

I've changed commit msg to reuse the text from 45095dc08b and pushed the patch in, thanks! On 11/27/2017 03:44 PM, Emil Velikov wrote: On 27 November 2017 at 07:27, Tapani Pälli <tapani.pa...@intel.com> wrote: Right, this works because Mali 450 driver does not s

[Piglit] [PATCH v2] ext_disjoint_timer_query-simple: basic API test

v2: cleanup code, remove some GL_NO_ERROR checks add to all.py (Eric) Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/all.py | 5 + tests/spec/CMakeLists.txt | 1 + .../ext_disjoint_timer_query/CMakeLists

Re: [Piglit] [PATCH] tests/egl/egl-context-priority.c: Use piglit_egl_get_default_display

Right, this works because Mali 450 driver does not support EGL_MESA_platform_surfaceless, LGTM Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 11/24/2017 06:31 PM, Aníbal Limón wrote: From: Aníbal Limón <anibal.li...@linaro.org> Some EGL implementations do not actually ship

Re: [Piglit] [PATCH] ext_disjoint_timer_query-simple: basic API test

On 11/21/2017 10:42 PM, Eric Anholt wrote: Tapani Pälli <tapani.pa...@intel.com> writes: Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/spec/CMakeLists.txt | 1 + .../ext_disjoint_timer_query/CMakeLists.gles2.txt | 7 ++

[Piglit] [PATCH] ext_disjoint_timer_query-simple: basic API test

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/spec/CMakeLists.txt | 1 + .../ext_disjoint_timer_query/CMakeLists.gles2.txt | 7 ++ tests/spec/ext_disjoint_timer_query/CMakeLists.txt | 1 + tests/spec/ext_disjoint_timer_query/simple-query.c

[Piglit] [PATCH v2] ext_occlusion_query_boolean: basic API test

v2: add enum test for GL_QUERY_COUNTER_BITS_ARB Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gles2.txt | 7 ++ .../ext_occlusion_query_boolean/CMakeLists.txt | 1 + ..

[Piglit] [PATCH] ext_occlusion_query_boolean: basic query test

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gles2.txt | 7 ++ .../ext_occlusion_query_boolean/CMakeLists.txt | 1 + .../spec/ext_occlusion_query_boolean/any-samples.c

  1   2   3   4   >