Reviewed-by: Ilia Mirkin
I can't say I read this in *extensive* detail, but it basically looks
right. Thanks!
On Thu, Jun 18, 2015 at 9:28 AM, Timothy Arceri wrote:
> fragment shader tests already exist, this adds vertex and
> geometry tests for completeness.
>
> Test results:
> Nvidia GeForce
fragment shader tests already exist, this adds vertex and
geometry tests for completeness.
Test results:
Nvidia GeForce 840M - NVIDIA 346.47: pass
Cc: Ilia Mirkin
---
.../gs-struct-nonconst-sampler-const.shader_test | 91
...gs-struct-nonconst-sampler-nonconst.shader_test
Hi Ilia,
I only did fs as it satisfied what I was trying to show. I found this
issue while working on arrays of arrays support.
The tests also fail for nir on i965, I was also hoping someone might
take a look at the failing tests before I got around to adding the
arrays of array support.
I've jus
BTW, Tim, any reason you only did fs? The reason I ask is that it
fails on i965 without nir, which is what vs/gs uses. [And I happened
to copy that approach in st/mesa, so this doesn't work in gallium
either... maybe having a failing piglit on i965 will cause the intel
folk to figure out how to pro
Hi Neil,
No problem. I'll update the tests give them a run on Nvidia and cc you
in on the patch.
Tim
On Mon, 2015-06-15 at 16:06 +0100, Neil Roberts wrote:
> Hi,
>
> I've just pushed this patch which changes the other
> sampler_array_indexing tests so that the textures are not just a solid
> co
Hi,
I've just pushed this patch which changes the other
sampler_array_indexing tests so that the textures are not just a solid
colour. The idea is that that way it will ensure that the texture
coordinates are being used correctly.
http://cgit.freedesktop.org/piglit/commit/?id=4f9caf084eda7353af7b
Looks good to me.
Reviewed-by: Chris Forbes
On Thu, Jun 4, 2015 at 2:28 PM, Timothy Arceri wrote:
> Test results:
>
> Nvidia GeForce 840M - NVIDIA 346.47: pass
> ---
> .../fs-struct-nonconst-sampler-const.shader_test | 72
> ...fs-struct-nonconst-sampler-nonconst.shader_
Test results:
Nvidia GeForce 840M - NVIDIA 346.47: pass
---
.../fs-struct-nonconst-sampler-const.shader_test | 72
...fs-struct-nonconst-sampler-nonconst.shader_test | 77 ++
.../fs-struct-nonconst-sampler.shader_test | 72
3
