From: Piglit on behalf of Anthony Pesch
Sent: Friday, May 24, 2019 8:21 PM
To: Pierre-Eric Pelloux-Prayer; Anthony Pesch; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] arb_texture_buffer_range: Fix buffer alignment in
ranges-2 test
[CAUTION
8:51 PM
To: Pelloux-prayer, Pierre-eric; Pierre-Eric Pelloux-Prayer; Anthony Pesch;
piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] arb_texture_buffer_range: Fix buffer alignment in
ranges-2 test
I think I should have noted, I don't have commit access.
Would someone mind pushing
on behalf of Anthony Pesch
Sent: Friday, May 24, 2019 8:21 PM
To: Pierre-Eric Pelloux-Prayer; Anthony Pesch; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] arb_texture_buffer_range: Fix buffer alignment in
ranges-2 test
[CAUTION: External Email]
Hi Pierre,
Thanks!
I've modifed
] arb_texture_buffer_range: Fix buffer alignment in
ranges-2 test
[CAUTION: External Email]
Hi Pierre,
Thanks!
I've modifed the patch to cast data, and added an additional check to
ensure unaligned offsets produce INVALID_VALUE. I'm not sure how to use
git send-mail to update a review, so I've just
Hi Pierre,
Thanks!
I've modifed the patch to cast data, and added an additional check to
ensure unaligned offsets produce INVALID_VALUE. I'm not sure how to use
git send-mail to update a review, so I've just inlined the updated patch
here and attached it as well.
- Anthony
commit
Hi,
The patch looks good, except ranges-2.c now cause a compiler warning:
tests/spec/arb_texture_buffer_range/ranges-2.c:152:20: warning: assignment to
‘uint8_t *’ {aka ‘unsigned char *’} from incompatible pointer type ‘float *’
[-Wincompatible-pointer-types]
for (i = 0, chunk = data; i <
Pinging to see if anyone has the time to review.
- Anthony
On 4/15/19 4:24 PM, Anthony Pesch wrote:
From: Anthony Pesch
The ranges-2 test was failing due to glTexBufferRange returning GL_INVALID_VALUE
when the offset parameter wasn't GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT byte
aligned.
From
From: Anthony Pesch
The ranges-2 test was failing due to glTexBufferRange returning GL_INVALID_VALUE
when the offset parameter wasn't GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT byte
aligned.
From the OpenGL 4.6 Core spec:
An INVALID_VALUE error is generated if offset is not an integer multiple of the
