Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-30 Thread Nanley Chery
On Mon, Nov 23, 2015 at 1:28 PM, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 4:16 PM, Ian Romanick wrote: > > On 11/23/2015 12:43 PM, Ilia Mirkin wrote: > >> On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick > wrote: > >>> On

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ian Romanick
On 11/21/2015 04:08 PM, Ilia Mirkin wrote: > In the check_error case, decompressed_tex is completely uninitialized > and might point to any texture. This can wreak various havoc. I might suggest a different approach. In the check_error case, ensure that decompress_texture is zero. Remove the

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick wrote: > On 11/21/2015 04:08 PM, Ilia Mirkin wrote: >> In the check_error case, decompressed_tex is completely uninitialized >> and might point to any texture. This can wreak various havoc. > > I might suggest a different

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-23 Thread Ian Romanick
On 11/23/2015 12:43 PM, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick wrote: >> On 11/21/2015 04:08 PM, Ilia Mirkin wrote: >>> In the check_error case, decompressed_tex is completely uninitialized >>> and might point to any texture. This can wreak

[Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-21 Thread Ilia Mirkin
In the check_error case, decompressed_tex is completely uninitialized and might point to any texture. This can wreak various havoc. Signed-off-by: Ilia Mirkin --- tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree.c | 3 ++- 1 file changed, 2