Re: [Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Dylan Baker
On Wednesday, June 11, 2014 03:31:26 AM Dylan Baker wrote: > If the except block is hit in Test._run_command(), the test has a status > of skip, but the test continues to run anyway. This is not consistent > with the way Test.check_for_skip_scenario() works, and means more time > is spent in python

Re: [Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Jose Fonseca
Yes, that looks sensible and I've confirmed it fixed the mis-categorized skip->crashes too. Thanks Dylan. Reviewed-by: Jose Fonseca Jose - Original Message - > If the except block is hit in Test._run_command(), the test has a status > of skip, but the test continues to run anyway. Thi

[Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Dylan Baker
If the except block is hit in Test._run_command(), the test has a status of skip, but the test continues to run anyway. This is not consistent with the way Test.check_for_skip_scenario() works, and means more time is spent in python than needs to be. This patch adds a small check after _run_comman