Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-20 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > Quoting Martin Peres (2017-10-20 00:38:18) >> On 19/10/17 19:50, Dylan Baker wrote: >> > Quoting Martin Peres (2017-10-19 07:17:25) >> >> On 30/09/17 23:42, Dylan Baker wrote: >> >>> Actually CC'ing him this time >>

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-20 Thread Martin Peres
On 19/10/17 19:50, Dylan Baker wrote: Quoting Martin Peres (2017-10-19 07:17:25) On 30/09/17 23:42, Dylan Baker wrote: Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) Quoting Arkadiusz Hiler (2017-09-26 03:27:50) Because in Python we have `bool([]}) == False`,

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-19 Thread Dylan Baker
Quoting Martin Peres (2017-10-19 07:17:25) > On 30/09/17 23:42, Dylan Baker wrote: > > Actually CC'ing him this time > > > > Quoting Dylan Baker (2017-09-29 20:29:34) > >> Quoting Arkadiusz Hiler (2017-09-26 03:27:50) > >>> Because in Python we have `bool([]}) == False`, providing empty test

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-10-19 Thread Martin Peres
On 30/09/17 23:42, Dylan Baker wrote: Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) Quoting Arkadiusz Hiler (2017-09-26 03:27:50) Because in Python we have `bool([]}) == False`, providing empty test list resulted in hitting the same code path as not providing it

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-09-30 Thread Dylan Baker
Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) > Quoting Arkadiusz Hiler (2017-09-26 03:27:50) > > Because in Python we have `bool([]}) == False`, providing empty test > > list resulted in hitting the same code path as not providing it at all, > > meaning that we run

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

2017-09-29 Thread Dylan Baker
Quoting Arkadiusz Hiler (2017-09-26 03:27:50) > Because in Python we have `bool([]}) == False`, providing empty test > list resulted in hitting the same code path as not providing it at all, > meaning that we run everything. > > Let's just exit early with an appropriate message instead. > > This

[Piglit] [PATCH] framework: Do not run with an empty test list

2017-09-26 Thread Arkadiusz Hiler
Because in Python we have `bool([]}) == False`, providing empty test list resulted in hitting the same code path as not providing it at all, meaning that we run everything. Let's just exit early with an appropriate message instead. This will get rid of the rather surprising behavior and will