Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-19 Thread Roland Scheidegger
Am 19.01.2018 um 06:35 schrieb Eric Anholt: > Brian Paul writes: > >> On 01/18/2018 01:27 PM, Eric Anholt wrote: >>> Brian Paul writes: >>> To avoid an infinite loop. See code comments for details. >>> >>> Skipping a failing test and returning pass is

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Eric Anholt
Brian Paul writes: > On 01/18/2018 01:27 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> To avoid an infinite loop. See code comments for details. >> >> Skipping a failing test and returning pass is wrong to me. > > It's not ideal. But the bug is in

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Brian Paul
On 01/18/2018 01:27 PM, Eric Anholt wrote: Brian Paul writes: To avoid an infinite loop. See code comments for details. Skipping a failing test and returning pass is wrong to me. It's not ideal. But the bug is in LLVM and cannot readily be fixed in llvmpipe. I

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Roland Scheidegger
Am 18.01.2018 um 21:04 schrieb Brian Paul: > On 01/18/2018 12:38 PM, Roland Scheidegger wrote: >> Am 18.01.2018 um 20:07 schrieb Brian Paul: >>> To avoid an infinite loop.  See code comments for details. >>> --- >>>   tests/spec/gl-1.0/blend.c | 39 +++ >>>   1

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Eric Anholt
Brian Paul writes: > To avoid an infinite loop. See code comments for details. Skipping a failing test and returning pass is wrong to me. signature.asc Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Brian Paul
On 01/18/2018 12:38 PM, Roland Scheidegger wrote: Am 18.01.2018 um 20:07 schrieb Brian Paul: To avoid an infinite loop. See code comments for details. --- tests/spec/gl-1.0/blend.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Roland Scheidegger
Am 18.01.2018 um 20:07 schrieb Brian Paul: > To avoid an infinite loop. See code comments for details. > --- > tests/spec/gl-1.0/blend.c | 39 +++ > 1 file changed, 39 insertions(+) > > diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c >

[Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

2018-01-18 Thread Brian Paul
To avoid an infinite loop. See code comments for details. --- tests/spec/gl-1.0/blend.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c index 35e940f..e69ed31 100644 --- a/tests/spec/gl-1.0/blend.c