Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-05 Thread Jason Ekstrand
Yeah, on second thought, not quite working... I'll poke at it a bit. On Thu, Sep 4, 2014 at 10:11 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Thanks a bunch Dylan. It's working great for me. --Jason On Thu, Sep 4, 2014 at 5:11 PM, Dylan Baker baker.dyla...@gmail.com wrote: On

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-05 Thread Jason Ekstrand
Dylan, There's one more on line 196 that you're missing. Wrapping that one in escape_pathname fixes it up nicely. With that change, Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com --Jason On Fri, Sep 5, 2014 at 11:35 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Yeah, on second

[Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. CC: Jason Ekstrand ja...@jlekstrand.net Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/summary.py | 14 ++ 1 file changed, 10 insertions(+), 4

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Ilia Mirkin
On Thu, Sep 4, 2014 at 4:54 PM, Dylan Baker baker.dyla...@gmail.com wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. CC: Jason Ekstrand ja...@jlekstrand.net Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Emil Velikov
On 04/09/14 21:54, Dylan Baker wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. From a quick look it seems that it might help with a funny issue that I'm seeing: Whenever piglit is ran on Windows the testname uses

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: On 04/09/14 21:54, Dylan Baker wrote: This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. From a quick look it seems that it might help with a funny issue