Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-12-03 Thread Chad Versace
On 12/03/2014 05:16 AM, Emil Velikov wrote: > On 01/12/14 18:17, Chad Versace wrote: >> >> >> On 12/01/2014 09:41 AM, Chad Versace wrote: >>> On 11/26/2014 01:11 AM, Emil Velikov wrote: >>> Things are not as black and white as you might think. Most of piglit uses what I call "target-less

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-12-03 Thread Emil Velikov
On 01/12/14 18:17, Chad Versace wrote: > > > On 12/01/2014 09:41 AM, Chad Versace wrote: >> On 11/26/2014 01:11 AM, Emil Velikov wrote: >> >>> Things are not as black and white as you might think. Most of piglit >>> uses what I call "target-less rules", which means that when one does >>> >>>a

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-12-01 Thread Chad Versace
On 12/01/2014 09:41 AM, Chad Versace wrote: > On 11/26/2014 01:11 AM, Emil Velikov wrote: > >> Things are not as black and white as you might think. Most of piglit >> uses what I call "target-less rules", which means that when one does >> >>add_definitions ( -DPIGLIT_USE_GLX ) >> or >>li

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-11-26 Thread Emil Velikov
On 25/11/14 18:45, Mark Janes wrote: > This patched fixed the gl tests, but I encountered the same error for > gles1/gles2/gles3. > > Piglit built for me when I added the same link instruction to: > > tests/util/CMakeLists.gles1.txt > tests/util/CMakeLists.gles2.txt > tests/util/CMakeLists.gles3.

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-11-25 Thread Mark Janes
This patched fixed the gl tests, but I encountered the same error for gles1/gles2/gles3. Piglit built for me when I added the same link instruction to: tests/util/CMakeLists.gles1.txt tests/util/CMakeLists.gles2.txt tests/util/CMakeLists.gles3.txt Is there a more specific (GLES) link instruction

[Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-11-24 Thread Emil Velikov
Similar to the earlier patch for waffle-less (glut) builds. The need for this patch became apparent as we removed the libGL link dependency in waffle. Cc: Mark Janes Reported-by: Mark Janes Signed-off-by: Emil Velikov --- tests/util/CMakeLists.gl.txt | 4 1 file changed, 4 insertions(+)

[Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

2014-11-24 Thread Emil Velikov
Similar to the earlier patch for waffle-less (glut) builds. The need for this patch became apparent as we removed the libGL link dependency in waffle. Cc: Mark Janes Reported-by: Mark Janes Signed-off-by: Emil Velikov --- tests/util/CMakeLists.gl.txt | 4 1 file changed, 4 insertions(+)