Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-11-05 Thread Marek Olšák
Why hasn't this patch been pushed yet? I guess we could later drop the ALPHA flag and have just RGB and RGBA. Marek On Mon, Oct 15, 2012 at 8:41 PM, Chad Versace chad.vers...@linux.intel.com wrote: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-11-05 Thread Chad Versace
On 11/05/2012 03:57 PM, Marek Olšák wrote: Why hasn't this patch been pushed yet? I simply forgot. It's now pushed. I guess we could later drop the ALPHA flag and have just RGB and RGBA. I agree that we should. But I just haven't found enough time and intereset yet to write a script to do

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-19 Thread Ian Romanick
On 10/17/2012 09:42 AM, Chad Versace wrote: On 10/16/2012 05:12 PM, Ian Romanick wrote: On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-18 Thread Marek Olšák
On Wed, Oct 17, 2012 at 2:12 AM, Ian Romanick i...@freedesktop.org wrote: On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless,

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-16 Thread Marek Olšák
There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless, but also we'd end up with the RGBX framebuffer config mostly untested. While it's useful to have RGBA framebuffers in most

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-16 Thread Ian Romanick
On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless, but also we'd end up with the RGBX framebuffer config mostly untested. While

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-16 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: On 10/16/2012 12:57 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote the waffle backend, I misunderstood the meaning of