Re: [Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-17 Thread Matt Turner
On Wed, Oct 15, 2014 at 11:24 AM, Laura Ekstrand la...@jlekstrand.net wrote: It's really not a good use of time to check for overlaps between the glsl1 tests and the shader runner tests, because that would take a lot of searching. I don't really think so. I've already deleted a pile of these

Re: [Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-15 Thread Brian Paul
On 10/13/2014 07:12 PM, Laura Ekstrand wrote: --- tests/all.py |1 + tests/spec/glsl-1.10/execution/CMakeLists.gl.txt |1 + tests/spec/glsl-1.10/execution/glean-glsl1.c | 2104 ++ 3 files changed, 2106 insertions(+)

Re: [Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-15 Thread Matt Turner
On Wed, Oct 15, 2014 at 8:13 AM, Brian Paul bri...@vmware.com wrote: I'm not sure that porting this test to Piglit is worthwhile. I'd bet that most of the little subtests here are already sufficiently covered by existing piglit shader tests. It would probably be simpler to make shader test

Re: [Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-15 Thread Laura Ekstrand
It's really not a good use of time to check for overlaps between the glsl1 tests and the shader runner tests, because that would take a lot of searching. So, the basic question is: do we want to convert these tests to shader runner (and not care about overlap), keep glsl1.c, or just throw glsl1.c

Re: [Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-14 Thread Laura Ekstrand
I applied the style fixes pointed out by Brian Paul and Dylan Baker in the blend func patch to my local repo (see http://cgit.freedesktop.org/~ldeks/piglit/?h=glsl1). Laura P.S.: I apologize if this is a repeat email. ___ Piglit mailing list

[Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

2014-10-13 Thread Laura Ekstrand
--- tests/all.py |1 + tests/spec/glsl-1.10/execution/CMakeLists.gl.txt |1 + tests/spec/glsl-1.10/execution/glean-glsl1.c | 2104 ++ 3 files changed, 2106 insertions(+) create mode 100644