Re: [Piglit] [PATCH 1/2] shader_draw_parameters: Also test using glDrawArrays with first > 0

2018-01-25 Thread Antia Puentes
Reviewed-by: Antia Puentes On 10/11/17 19:05, Neil Roberts wrote: The ‘first’ parameter should not affect the value of gl_BaseVertex put it should be added to gl_VertexID. This patch adds an extra rectangle to the drawn area to test a non-zero ‘first’ parameter. This is

[Piglit] [PATCH 1/2] shader_draw_parameters: Also test using glDrawArrays with first > 0

2017-11-10 Thread Neil Roberts
The ‘first’ parameter should not affect the value of gl_BaseVertex put it should be added to gl_VertexID. This patch adds an extra rectangle to the drawn area to test a non-zero ‘first’ parameter. This is worth testing because Mesa is currently getting this wrong. ---