Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2014-03-16 Thread Daniel Vetter
On Sat, Mar 15, 2014 at 07:41:13PM -0700, Dylan Baker wrote: On Saturday, March 15, 2014 03:09:33 PM you wrote: I've been thinking about it and I think the best solution would be to add 2 new pages: - feature changes containing changes from skip to anything but skip and notrun and vice

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2014-03-15 Thread Daniel Vetter
On Fri, Nov 22, 2013 at 12:10:43AM +0100, Marek Olšák wrote: It looks like people have different expectations from notrun and skip, so I have a proposal: - add a notrun page similar to the skipped page - don't include the notrun and skip statuses in the regression and fixes pages - add the

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2014-03-15 Thread Marek Olšák
I've been thinking about it and I think the best solution would be to add 2 new pages: - feature changes containing changes from skip to anything but skip and notrun and vice versa. - test changes containing changes from notrun to anything but notrun and vice versa. Marek On Sat, Mar 15, 2014 at

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2014-03-15 Thread Dylan Baker
On Saturday, March 15, 2014 03:09:33 PM you wrote: I've been thinking about it and I think the best solution would be to add 2 new pages: - feature changes containing changes from skip to anything but skip and notrun and vice versa. - test changes containing changes from notrun to anything

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-21 Thread Daniel Vetter
On Wed, Nov 20, 2013 at 03:04:34PM -0800, Dylan Baker wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Dylan Baker
On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6 ++--- framework/tests/summary.py | 66

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Kenneth Graunke
On 11/18/2013 06:33 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. IMO, Not Run should never appear on the fixes or regressions page. Not Run means that there is no status whatsoever in one of your files. It means the two results columns you gave

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Marek Olšák
On Thu, Nov 21, 2013 at 12:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Dylan Baker
On Thursday, November 21, 2013 12:30:53 AM Marek Olšák wrote: On Thu, Nov 21, 2013 at 12:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. ---

[Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-18 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6 ++--- framework/tests/summary.py | 66 -- 3 files changed, 44 insertions(+), 76