Re: [Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

2015-11-27 Thread Pohjolainen, Topi
On Fri, Nov 27, 2015 at 11:03:05AM +0100, Neil Roberts wrote: > "Pohjolainen, Topi" writes: > > >>glBindFramebuffer(GL_FRAMEBUFFER, piglit_winsys_fbo); > >>piglit_draw_rect(offset * 16 * 2.0f / piglit_width - 1.0f, > > > > This is a question regarding the existing logic. Earlier the test

Re: [Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

2015-11-27 Thread Neil Roberts
"Pohjolainen, Topi" writes: >> glBindFramebuffer(GL_FRAMEBUFFER, piglit_winsys_fbo); >> piglit_draw_rect(offset * 16 * 2.0f / piglit_width - 1.0f, > > This is a question regarding the existing logic. Earlier the test > calls "glBindFramebuffer(GL_FRAMEBUFFER, fbo)" and clears the > fram

Re: [Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

2015-11-27 Thread Pohjolainen, Topi
On Wed, Nov 25, 2015 at 06:11:50PM +0100, Neil Roberts wrote: There is a typo in the subject: "mulitsample-fast-clear" ^ > If ???enable-fb-srgb??? is given on the command line to the fast clear > test it will now enable GL_FRAMEBUFFER_SRGB before clearing the >

[Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

2015-11-25 Thread Neil Roberts
If ‘enable-fb-srgb’ is given on the command line to the fast clear test it will now enable GL_FRAMEBUFFER_SRGB before clearing the buffer. This should cause the clear color to be converted from SRGB to linear before being written to the framebuffer. The expected color is therefore converted to matc