Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-27 Thread Tapani Pälli
Huh, first of all thanks for taking time to add the 'crosschecking' (consistency_check) .. this test has impressive amount of subtests and validation of the results! I did not find any errors from the subtests (excluding that one that should be PROGRAM_INPUT not OUTPUT but that you already

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-27 Thread Martin Peres
On 27/03/15 09:58, Tapani Pälli wrote: Huh, first of all thanks for taking time to add the 'crosschecking' (consistency_check) .. this test has impressive amount of subtests and validation of the results! I did not find any errors from the subtests (excluding that one that should be

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-27 Thread Tapani Pälli
On 03/27/2015 10:12 AM, Martin Peres wrote: On 27/03/15 09:58, Tapani Pälli wrote: Huh, first of all thanks for taking time to add the 'crosschecking' (consistency_check) .. this test has impressive amount of subtests and validation of the results! I did not find any errors from the subtests

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-26 Thread Martin Peres
On 25/03/15 18:01, Martin Peres wrote: This tests primarily glGetProgramInterfaceiv in various (potentially tricky) program pipelines. All the calls are supposed to succeed as this test is purely functional. This test requires a OpenGL 3.2 core context but also has optional subtests that depend

[Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-25 Thread Martin Peres
This tests primarily glGetProgramInterfaceiv in various (potentially tricky) program pipelines. All the calls are supposed to succeed as this test is purely functional. This test requires a OpenGL 3.2 core context but also has optional subtests that depend on the following extensions: -