On 10/06/18 16:06, Jordan Justen wrote:
On 2018-06-09 21:56:33, Timothy Arceri wrote:
Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a
missing something?
They are close. Patch 6 tests that the uniform is reset by examining
the result of drawing. Patch 8 tests by reading the
On 2018-06-09 21:56:33, Timothy Arceri wrote:
> Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a
> missing something?
They are close. Patch 6 tests that the uniform is reset by examining
the result of drawing. Patch 8 tests by reading the uniform value via
the GL API.
I guess
Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a
missing something?
Otherwise, this series looks great thanks for working on it :)
Reviewed-by: Timothy Arceri
On 09/06/18 15:47, Jordan Justen wrote:
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 16
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 16
1 file changed, 16 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 794524e8f..c4e25a33d 100644
--- a/tests/shaders/shader_runner.c
+++
